* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
@ 2020-04-20 11:57 ` Ray Kinsella
2020-04-20 12:20 ` David Marchand
2020-04-23 6:41 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
` (4 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Ray Kinsella @ 2020-04-20 11:57 UTC (permalink / raw)
To: dev
Cc: haiyue.wang, matan, anoobj, ferruh.yigit, david.marchand,
mchalla, echaudro, cristian.dumitrescu, thomas, jingjing.wu,
wenzhuo.lu, shahafs, viacheslavo, jerinj, ndabilpuram,
cardigliano, Neil Horman
Travis ABI check warnings, can be safely ignored in this case, I think.
https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
Ray K
On 20/04/2020 10:34, Ray Kinsella wrote:
> Change references to abi 20.0.1 to use abi v21.0, add myself as the map
> file maintainer to more closely monitor future abi changes.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> ---
> MAINTAINERS | 2 ++
> drivers/common/iavf/rte_common_iavf_version.map | 2 +-
> drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
> drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
> drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
> drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
> drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
> lib/librte_meter/rte_meter_version.map | 2 +-
> 8 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1bf00d7e5..c352e7815 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -86,6 +86,8 @@ F: doc/
> ABI Policy
> M: Ray Kinsella <mdr@ashroe.eu>
> F: doc/guides/contributing/abi_*.rst
> +F: drivers/*/*/*.map
> +F: lib/*/*.map
>
> Developers and Maintainers Tools
> M: Thomas Monjalon <thomas@monjalon.net>
> diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
> index 2f11d67c0..b9ca81aea 100644
> --- a/drivers/common/iavf/rte_common_iavf_version.map
> +++ b/drivers/common/iavf/rte_common_iavf_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> iavf_init_adminq;
> diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
> index aede2a0a5..7bfea95fb 100644
> --- a/drivers/common/mlx5/rte_common_mlx5_version.map
> +++ b/drivers/common/mlx5/rte_common_mlx5_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> mlx5_class_get;
> diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> index 8f2404bd9..68392ff79 100644
> --- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
> +++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> @@ -34,7 +34,7 @@ DPDK_20.0 {
> local: *;
> };
>
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> otx2_eth_dev_is_sec_capable;
> diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
> index bc8fd6d4d..cd8100ee4 100644
> --- a/drivers/net/ionic/rte_pmd_ionic_version.map
> +++ b/drivers/net/ionic/rte_pmd_ionic_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
>
> local: *;
> };
> diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> index bc8fd6d4d..cd8100ee4 100644
> --- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> +++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
>
> local: *;
> };
> diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> index 179f7f1ae..299ae632d 100644
> --- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> +++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
> @@ -1,3 +1,3 @@
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> local: *;
> };
> diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
> index fc12cc0bf..10c56756c 100644
> --- a/lib/librte_meter/rte_meter_version.map
> +++ b/lib/librte_meter/rte_meter_version.map
> @@ -13,7 +13,7 @@ DPDK_20.0 {
> local: *;
> };
>
> -DPDK_20.0.1 {
> +DPDK_21.0 {
> global:
>
> rte_meter_trtcm_rfc4115_color_aware_check;
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-20 11:57 ` Ray Kinsella
@ 2020-04-20 12:20 ` David Marchand
2020-04-20 15:25 ` Ray Kinsella
2020-04-22 8:07 ` Ray Kinsella
0 siblings, 2 replies; 24+ messages in thread
From: David Marchand @ 2020-04-20 12:20 UTC (permalink / raw)
To: Ray Kinsella
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob Kollanukkaran,
Nithin Dabilpuram, Alfredo Cardigliano, Neil Horman
On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Travis ABI check warnings, can be safely ignored in this case, I think.
>
> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
How about comparing to 19.11 ABI then?
--- a/.travis.yml
+++ b/.travis.yml
@@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
env:
global:
- - REF_GIT_TAG=v20.02
+ - REF_GIT_TAG=v19.11
jobs:
include:
--
David Marchand
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-20 12:20 ` David Marchand
@ 2020-04-20 15:25 ` Ray Kinsella
2020-04-22 8:07 ` Ray Kinsella
1 sibling, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-20 15:25 UTC (permalink / raw)
To: David Marchand
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob Kollanukkaran,
Nithin Dabilpuram, Alfredo Cardigliano, Neil Horman
On 20/04/2020 13:20, David Marchand wrote:
> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>
>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>
>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>
> How about comparing to 19.11 ABI then?
Theory is we should always be checking against v19.11 abi.
So this _should_ be v19.11 ...
I will change in v2 and see what it throws up.
>
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
>
> env:
> global:
> - - REF_GIT_TAG=v20.02
> + - REF_GIT_TAG=v19.11
>
> jobs:
> include:
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-20 12:20 ` David Marchand
2020-04-20 15:25 ` Ray Kinsella
@ 2020-04-22 8:07 ` Ray Kinsella
2020-04-22 8:11 ` David Marchand
2020-04-22 8:18 ` Thomas Monjalon
1 sibling, 2 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-22 8:07 UTC (permalink / raw)
To: David Marchand
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob Kollanukkaran,
Nithin Dabilpuram, Alfredo Cardigliano, Neil Horman
Concluded on separate thread it is best to leave this as v20.02.
Thanks,
Ray K
On 20/04/2020 13:20, David Marchand wrote:
> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>
>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>
>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>
> How about comparing to 19.11 ABI then?
>
>
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh
>
> env:
> global:
> - - REF_GIT_TAG=v20.02
> + - REF_GIT_TAG=v19.11
>
> jobs:
> include:
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-22 8:07 ` Ray Kinsella
@ 2020-04-22 8:11 ` David Marchand
2020-04-22 8:18 ` Thomas Monjalon
1 sibling, 0 replies; 24+ messages in thread
From: David Marchand @ 2020-04-22 8:11 UTC (permalink / raw)
To: Ray Kinsella
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob Kollanukkaran,
Nithin Dabilpuram, Alfredo Cardigliano, Neil Horman
On Wed, Apr 22, 2020 at 10:08 AM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Concluded on separate thread it is best to leave this as v20.02.
Ok, thanks for confirming.
--
David Marchand
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-22 8:07 ` Ray Kinsella
2020-04-22 8:11 ` David Marchand
@ 2020-04-22 8:18 ` Thomas Monjalon
2020-04-22 8:28 ` Ray Kinsella
1 sibling, 1 reply; 24+ messages in thread
From: Thomas Monjalon @ 2020-04-22 8:18 UTC (permalink / raw)
To: David Marchand, Ray Kinsella
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu, Jingjing Wu,
Wenzhuo Lu, Shahaf Shuler, Viacheslav Ovsiienko,
Jerin Jacob Kollanukkaran, Nithin Dabilpuram,
Alfredo Cardigliano, Neil Horman
22/04/2020 10:07, Ray Kinsella:
> On 20/04/2020 13:20, David Marchand wrote:
> > On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
> >>
> >> Travis ABI check warnings, can be safely ignored in this case, I think.
> >>
> >> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
> >
> > How about comparing to 19.11 ABI then?
> >
> Concluded on separate thread it is best to leave this as v20.02.
It means the ABI tool will be reporting a failure?
The tool needs to reliably report zero false positive.
How can we mitigate this issue?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21
2020-04-22 8:18 ` Thomas Monjalon
@ 2020-04-22 8:28 ` Ray Kinsella
0 siblings, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-22 8:28 UTC (permalink / raw)
To: Thomas Monjalon, David Marchand
Cc: dev, Wang, Haiyue, Matan Azrad, Anoob Joseph, Yigit, Ferruh,
Mahipal Challa, Eelco Chaudron, Cristian Dumitrescu, Jingjing Wu,
Wenzhuo Lu, Shahaf Shuler, Viacheslav Ovsiienko,
Jerin Jacob Kollanukkaran, Nithin Dabilpuram,
Alfredo Cardigliano, Neil Horman
On 22/04/2020 09:18, Thomas Monjalon wrote:
> 22/04/2020 10:07, Ray Kinsella:
>> On 20/04/2020 13:20, David Marchand wrote:
>>> On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>>>>
>>>> Travis ABI check warnings, can be safely ignored in this case, I think.
>>>>
>>>> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
>>>
>>> How about comparing to 19.11 ABI then?
>>>
>> Concluded on separate thread it is best to leave this as v20.02.
>
> It means the ABI tool will be reporting a failure?
> The tool needs to reliably report zero false positive.
> How can we mitigate this issue?
>
>
So I suggest we handle by adding
[suppress_function]
symbol_version = 20.0.1
[suppress_variable]
symbol_version = 20.0.1
to libabigail.abignore.
libabigail will then ignore the removals?
Ray K
^ permalink raw reply [flat|nested] 24+ messages in thread
* [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
2020-04-20 11:57 ` Ray Kinsella
@ 2020-04-23 6:41 ` Ray Kinsella
2020-04-24 9:15 ` Thomas Monjalon
2020-04-24 14:10 ` David Marchand
2020-04-27 9:06 ` [dpdk-dev] [PATCH v3] " Ray Kinsella
` (3 subsequent siblings)
5 siblings, 2 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-23 6:41 UTC (permalink / raw)
To: dev
Cc: aostruszka, stephen, Ray Kinsella, Thomas Monjalon, Neil Horman,
Jingjing Wu, Wenzhuo Lu, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu
Change references to abi 20.0.1 to use abi v21, add myself as the map
file maintainer to more closely monitor future abi changes. Add
suppressions that were missed on changes to librte_lpm.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 2 ++
devtools/libabigail.abignore | 13 ++++++++++++-
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
.../octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
.../rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7b81e2d1b..c24fd374d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,6 +86,8 @@ F: doc/
ABI Policy
M: Ray Kinsella <mdr@ashroe.eu>
F: doc/guides/contributing/abi_*.rst
+F: drivers/*/*/*.map
+F: lib/*/*.map
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index cd86d89ca..20c821cee 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -2,7 +2,6 @@
symbol_version = EXPERIMENTAL
[suppress_variable]
symbol_version = EXPERIMENTAL
-
; Explicit ignore for driver-only ABI
[suppress_type]
name = rte_cryptodev_ops
@@ -18,3 +17,15 @@
[suppress_type]
type_kind = struct
name = rte_event_ring
+; Explicit ignore ABI 20.0.1
+[suppress_function]
+ symbol_version = DPDK_20.0.1
+[suppress_variable]
+ symbol_version = DPDK_20.0.1
+; Explicit ignore of const lpm6_lookup change
+[suppress_function]
+ name = rte_lpm6_delete
+ parameter = '1 uint8_t*
+[suppress_function]
+ name = rte_lpm6_is_rule_present
+ parameter = '1 uint8_t*
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67c0..92ceac108 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index aede2a0a5..fe151fe0d 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404bd9..01279c339 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1ae..4a76d1d52 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0bf..2c7dadbca 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;
--
2.17.1
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-23 6:41 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
@ 2020-04-24 9:15 ` Thomas Monjalon
2020-04-24 14:10 ` David Marchand
1 sibling, 0 replies; 24+ messages in thread
From: Thomas Monjalon @ 2020-04-24 9:15 UTC (permalink / raw)
To: Ray Kinsella
Cc: dev, aostruszka, stephen, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu
23/04/2020 08:41, Ray Kinsella:
> Change references to abi 20.0.1 to use abi v21, add myself as the map
> file maintainer to more closely monitor future abi changes. Add
> suppressions that were missed on changes to librte_lpm.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Please could you add a reference to the doc chapter stating this rule,
in the commit log? Thanks
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-23 6:41 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
2020-04-24 9:15 ` Thomas Monjalon
@ 2020-04-24 14:10 ` David Marchand
2020-04-24 14:50 ` Ray Kinsella
1 sibling, 1 reply; 24+ messages in thread
From: David Marchand @ 2020-04-24 14:10 UTC (permalink / raw)
To: Ray Kinsella, Dodji Seketeli
Cc: dev, Andrzej Ostruszka, Stephen Hemminger, Thomas Monjalon,
Neil Horman, Jingjing Wu, Wenzhuo Lu, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu, Wang,
Haiyue
On Thu, Apr 23, 2020 at 8:48 AM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Change references to abi 20.0.1 to use abi v21, add myself as the map
> file maintainer to more closely monitor future abi changes. Add
> suppressions that were missed on changes to librte_lpm.
About the lpm change below, this might be because you are using an old
version of libabigail.
I think the change went in:
$ git describe --contains 215b7eb4
libabigail-1.4~8
I use either libabigail 1.7 or the current master (when testing Dodji
enhancements).
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index cd86d89ca..20c821cee 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -2,7 +2,6 @@
> symbol_version = EXPERIMENTAL
> [suppress_variable]
> symbol_version = EXPERIMENTAL
> -
> ; Explicit ignore for driver-only ABI
> [suppress_type]
> name = rte_cryptodev_ops
> @@ -18,3 +17,15 @@
> [suppress_type]
> type_kind = struct
> name = rte_event_ring
> +; Explicit ignore ABI 20.0.1
> +[suppress_function]
> + symbol_version = DPDK_20.0.1
> +[suppress_variable]
> + symbol_version = DPDK_20.0.1
> +; Explicit ignore of const lpm6_lookup change
> +[suppress_function]
> + name = rte_lpm6_delete
> + parameter = '1 uint8_t*
> +[suppress_function]
> + name = rte_lpm6_is_rule_present
> + parameter = '1 uint8_t*
--
David Marchand
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-24 14:10 ` David Marchand
@ 2020-04-24 14:50 ` Ray Kinsella
2020-04-24 15:01 ` David Marchand
2020-04-29 12:19 ` Dodji Seketeli
0 siblings, 2 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-24 14:50 UTC (permalink / raw)
To: David Marchand, Dodji Seketeli
Cc: dev, Andrzej Ostruszka, Stephen Hemminger, Thomas Monjalon,
Neil Horman, Jingjing Wu, Wenzhuo Lu, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu, Wang,
Haiyue
ah ok, the particular system I made the change on was Ubuntu 18.04.2.
which is libabigail 1.2.0.
Given we still support v19.11 on Ubuntu 18.04.2.
I think it's worthwhile keeping the suppression until v20.11?
Ray K
On 24/04/2020 15:10, David Marchand wrote:
> On Thu, Apr 23, 2020 at 8:48 AM Ray Kinsella <mdr@ashroe.eu> wrote:
>>
>> Change references to abi 20.0.1 to use abi v21, add myself as the map
>> file maintainer to more closely monitor future abi changes. Add
>> suppressions that were missed on changes to librte_lpm.
>
> About the lpm change below, this might be because you are using an old
> version of libabigail.
> I think the change went in:
> $ git describe --contains 215b7eb4
> libabigail-1.4~8
>
> I use either libabigail 1.7 or the current master (when testing Dodji
> enhancements).
>
>
>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
>> index cd86d89ca..20c821cee 100644
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -2,7 +2,6 @@
>> symbol_version = EXPERIMENTAL
>> [suppress_variable]
>> symbol_version = EXPERIMENTAL
>> -
>> ; Explicit ignore for driver-only ABI
>> [suppress_type]
>> name = rte_cryptodev_ops
>> @@ -18,3 +17,15 @@
>> [suppress_type]
>> type_kind = struct
>> name = rte_event_ring
>> +; Explicit ignore ABI 20.0.1
>> +[suppress_function]
>> + symbol_version = DPDK_20.0.1
>> +[suppress_variable]
>> + symbol_version = DPDK_20.0.1
>> +; Explicit ignore of const lpm6_lookup change
>> +[suppress_function]
>> + name = rte_lpm6_delete
>> + parameter = '1 uint8_t*
>> +[suppress_function]
>> + name = rte_lpm6_is_rule_present
>> + parameter = '1 uint8_t*
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-24 14:50 ` Ray Kinsella
@ 2020-04-24 15:01 ` David Marchand
2020-04-29 12:19 ` Dodji Seketeli
1 sibling, 0 replies; 24+ messages in thread
From: David Marchand @ 2020-04-24 15:01 UTC (permalink / raw)
To: Ray Kinsella
Cc: Dodji Seketeli, dev, Andrzej Ostruszka, Stephen Hemminger,
Thomas Monjalon, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu, Wang, Haiyue
On Fri, Apr 24, 2020 at 4:50 PM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> ah ok, the particular system I made the change on was Ubuntu 18.04.2.
> which is libabigail 1.2.0.
>
> Given we still support v19.11 on Ubuntu 18.04.2.
> I think it's worthwhile keeping the suppression until v20.11?
1.2 is fairly old and does not seem maintained by Ubuntu (asked for
backport, and got ignored so far).
https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607
Dodji told me that there were new checks added in newer sersions.
I also fear that supporting an old libabigail version will force us to
add a lot of other rules.
In Travis, we currently use libabigail 1.6 (mainly because I did not
update to 1.7 when it was released).
--
David Marchand
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-24 14:50 ` Ray Kinsella
2020-04-24 15:01 ` David Marchand
@ 2020-04-29 12:19 ` Dodji Seketeli
2020-04-30 8:23 ` Ray Kinsella
1 sibling, 1 reply; 24+ messages in thread
From: Dodji Seketeli @ 2020-04-29 12:19 UTC (permalink / raw)
To: Ray Kinsella
Cc: David Marchand, dev, Andrzej Ostruszka, Stephen Hemminger,
Thomas Monjalon, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu, Wang, Haiyue
Hello,
Ray Kinsella <mdr@ashroe.eu> writes:
> ah ok, the particular system I made the change on was Ubuntu 18.04.2.
> which is libabigail 1.2.0.
Whoah, 1.2 is super old.
In my opinion, one of the hallmarks of static analysis tools (and
libabigail is just a static analysis framework) is to be able to
recognize patterns used by developers, as much as we can.
Because we can't really do that at once, we try to add recognition of
new patterns (of ABI changes) at every single release. Furthermore,
there are some change patterns that ought to be recognized and
categorized as harmless, whereas some others out to be categorized as
harmful. That categorization is also the result of input coming from
users as you, fine fellows.
All this to say that with every new version, the number of new supported
features and bug fixes is potentially big.
To alleviate that, some distributors update libabigail even in their old
stable distros, because the value of having an up to date version there
outweighs the potential drawbacks.
> Given we still support v19.11 on Ubuntu 18.04.2.
So maybe that's a discussion worth having with the maintainer of the
Ubuntu package of Libabigail?
> I think it's worthwhile keeping the suppression until v20.11?
[...]
David Marchand <david.marchand@redhat.com> writes:
> In Travis, we currently use libabigail 1.6 (mainly because I did not
> update to 1.7 when it was released).
Right, that's probably another way to stay up to date independently from
the underlying distribution.
I hope this helps,
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21
2020-04-29 12:19 ` Dodji Seketeli
@ 2020-04-30 8:23 ` Ray Kinsella
0 siblings, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-30 8:23 UTC (permalink / raw)
To: Dodji Seketeli
Cc: David Marchand, dev, Andrzej Ostruszka, Stephen Hemminger,
Thomas Monjalon, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu, Wang, Haiyue
On 29/04/2020 13:19, Dodji Seketeli wrote:
> Hello,
>
> Ray Kinsella <mdr@ashroe.eu> writes:
>
>> ah ok, the particular system I made the change on was Ubuntu 18.04.2.
>> which is libabigail 1.2.0.
>
> Whoah, 1.2 is super old.
I have a huge clunking raid'ed "build" server,
that I am pretty conservative about upgrading on v18.04.2 :-)
> In my opinion, one of the hallmarks of static analysis tools (and
> libabigail is just a static analysis framework) is to be able to
> recognize patterns used by developers, as much as we can.
>
> Because we can't really do that at once, we try to add recognition of
> new patterns (of ABI changes) at every single release. Furthermore,
> there are some change patterns that ought to be recognized and
> categorized as harmless, whereas some others out to be categorized as
> harmful. That categorization is also the result of input coming from
> users as you, fine fellows.
>
> All this to say that with every new version, the number of new supported
> features and bug fixes is potentially big.
>
> To alleviate that, some distributors update libabigail even in their old
> stable distros, because the value of having an up to date version there
> outweighs the potential drawbacks.
Well it falls into the same category of problems of upgrading compilers.
User's typically build their software build reliably on a given distro version.
(or number of versions).
If the maintainer upgrades compilers between distro versions, it introduces new
warnings and errors, and all hell will generally break loose, when the user least expects it.
They typically expect that mayhem when upgrading to new distro versions.
Even tools like GNU indent can cause enormous problems.
I would imagine that most maintainers would be pretty conservative about making
such changes.
>
>> Given we still support v19.11 on Ubuntu 18.04.2.
>
> So maybe that's a discussion worth having with the maintainer of the
> Ubuntu package of Libabigail?
yes - I think it would be an interesting discussion alright.
I imagine the response might be inline with my understanding above.
Let's find out - as we can expect v18.04 to be around for at least another
two years I guess.
Another common way to handle this, is to be really explicit about what
OS distros DPDK formally supports building on, which will then imply
we support a small handful of versions of libabigail.
We then simply say we don't support 18.04 anymore - FD.io VPP are planning
this formal switch at the moment.
>
>> I think it's worthwhile keeping the suppression until v20.11?
>
> [...]
>
> David Marchand <david.marchand@redhat.com> writes:
>
>> In Travis, we currently use libabigail 1.6 (mainly because I did not
>> update to 1.7 when it was released).
>
> Right, that's probably another way to stay up to date independently from
> the underlying distribution.
You typically don't want to encourage this, you end up with some people
on a newer version, some people on an old version and never upgrading.
Then you never end up with a consistent view of what mitigations are actually required.
Solving issues, becomes like a game of whack-a-mole.
>
> I hope this helps,
It does, greatly thanks.
>
> Cheers,
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [dpdk-dev] [PATCH v3] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
2020-04-20 11:57 ` Ray Kinsella
2020-04-23 6:41 ` [dpdk-dev] [PATCH v2] " Ray Kinsella
@ 2020-04-27 9:06 ` Ray Kinsella
2020-04-27 9:06 ` Ray Kinsella
2020-04-27 13:45 ` [dpdk-dev] [PATCH v4] " Ray Kinsella
` (2 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Ray Kinsella @ 2020-04-27 9:06 UTC (permalink / raw)
To: dev
Cc: aostruszka, stephen, david.marchand, Ray Kinsella,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Matan Azrad,
Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu
v3:
* Removed libabigail supressions in previous version.
* Clarified abi policy for only major abi versions in git commit.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
8 files changed, 9 insertions(+), 7 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 24+ messages in thread* [dpdk-dev] [PATCH v3] abi: change references to abi 20.0.1 to abi v21
2020-04-27 9:06 ` [dpdk-dev] [PATCH v3] " Ray Kinsella
@ 2020-04-27 9:06 ` Ray Kinsella
0 siblings, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-27 9:06 UTC (permalink / raw)
To: dev
Cc: aostruszka, stephen, david.marchand, Ray Kinsella,
Thomas Monjalon, Jingjing Wu, Wenzhuo Lu, Matan Azrad,
Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI version is declared."
Add myself as the map file maintainer to more closely monitor future abi
changes.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 2 ++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
8 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d31a809..7d521f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,6 +86,8 @@ F: doc/
ABI Policy
M: Ray Kinsella <mdr@ashroe.eu>
F: doc/guides/contributing/abi_*.rst
+F: drivers/*/*/*.map
+F: lib/*/*.map
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67..92ceac1 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index b58a378..564a9a7 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404b..01279c3 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d..acdaf58 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d..acdaf58 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1..4a76d1d 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0..2c7dadb 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;
--
2.7.4
^ permalink raw reply [flat|nested] 24+ messages in thread
* [dpdk-dev] [PATCH v4] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
` (2 preceding siblings ...)
2020-04-27 9:06 ` [dpdk-dev] [PATCH v3] " Ray Kinsella
@ 2020-04-27 13:45 ` Ray Kinsella
2020-04-27 13:45 ` Ray Kinsella
2020-04-30 10:21 ` [dpdk-dev] [PATCH v5] " Ray Kinsella
2020-04-30 10:27 ` [dpdk-dev] [PATCH v6 1/1] " Ray Kinsella
5 siblings, 1 reply; 24+ messages in thread
From: Ray Kinsella @ 2020-04-27 13:45 UTC (permalink / raw)
To: dev
Cc: aostruszka, stephen, david.marchand, Ray Kinsella,
Thomas Monjalon, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu
v4:
* restored suppressions for v20.0.1 incorrectly removed in v3.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 14 insertions(+), 7 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 24+ messages in thread* [dpdk-dev] [PATCH v4] abi: change references to abi 20.0.1 to abi v21
2020-04-27 13:45 ` [dpdk-dev] [PATCH v4] " Ray Kinsella
@ 2020-04-27 13:45 ` Ray Kinsella
0 siblings, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-27 13:45 UTC (permalink / raw)
To: dev
Cc: aostruszka, stephen, david.marchand, Ray Kinsella,
Thomas Monjalon, Neil Horman, Jingjing Wu, Wenzhuo Lu,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI version is declared."
Add myself as the map file maintainer to more closely monitor future abi
changes.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 2 ++
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d31a809..7d521f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,6 +86,8 @@ F: doc/
ABI Policy
M: Ray Kinsella <mdr@ashroe.eu>
F: doc/guides/contributing/abi_*.rst
+F: drivers/*/*/*.map
+F: lib/*/*.map
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 986a527..b0147fd 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -29,3 +29,8 @@
type_kind = enum
name = rte_eth_event_type
changed_enumerators = RTE_ETH_EVENT_MAX
+; Explicit ignore ABI 20.0.1
+[suppress_function]
+ symbol_version = DPDK_20.0.1
+[suppress_variable]
+ symbol_version = DPDK_20.0.1
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67..92ceac1 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index b58a378..564a9a7 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404b..01279c3 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d..acdaf58 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d..acdaf58 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1..4a76d1d 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0..2c7dadb 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;
--
2.7.4
^ permalink raw reply [flat|nested] 24+ messages in thread
* [dpdk-dev] [PATCH v5] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
` (3 preceding siblings ...)
2020-04-27 13:45 ` [dpdk-dev] [PATCH v4] " Ray Kinsella
@ 2020-04-30 10:21 ` Ray Kinsella
2020-04-30 10:27 ` [dpdk-dev] [PATCH v6 1/1] " Ray Kinsella
5 siblings, 0 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-30 10:21 UTC (permalink / raw)
To: dev
Cc: david.marchand, Ray Kinsella, Thomas Monjalon, Neil Horman,
Jingjing Wu, Beilei Xing, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI version is declared."
Combined abi policy and versioning in maintainers, add map files to the
filter to more closely monitor future abi changes.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 10 +++++-----
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
.../common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
.../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e05c80504..9756cb752 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -83,10 +83,6 @@ M: Marko Kovacevic <marko.kovacevic@intel.com>
F: README
F: doc/
-ABI Policy
-M: Ray Kinsella <mdr@ashroe.eu>
-F: doc/guides/contributing/abi_*.rst
-
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
F: MAINTAINERS
@@ -140,10 +136,12 @@ M: Michael Santana <maicolgabriel@hotmail.com>
F: .travis.yml
F: .ci/
-ABI versioning
+ABI policy & versioning
+M: Ray Kinsella <mdr@ashroe.eu>
M: Neil Horman <nhorman@tuxdriver.com>
F: lib/librte_eal/include/rte_compat.h
F: lib/librte_eal/include/rte_function_versioning.h
+F: doc/guides/contributing/abi_*.rst
F: doc/guides/rel_notes/deprecation.rst
F: devtools/check-abi.sh
F: devtools/check-abi-version.sh
@@ -155,6 +153,8 @@ F: devtools/update_version_map_abi.py
F: devtools/validate-abi.sh
F: buildtools/check-symbols.sh
F: buildtools/map-list-symbol.sh
+F: drivers/*/*/*.map
+F: lib/*/*.map
Driver information
M: Neil Horman <nhorman@tuxdriver.com>
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 986a52771..b0147fde6 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -29,3 +29,8 @@
type_kind = enum
name = rte_eth_event_type
changed_enumerators = RTE_ETH_EVENT_MAX
+; Explicit ignore ABI 20.0.1
+[suppress_function]
+ symbol_version = DPDK_20.0.1
+[suppress_variable]
+ symbol_version = DPDK_20.0.1
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67c0..92ceac108 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index b58a37827..564a9a7fb 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404bd9..01279c339 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1ae..4a76d1d52 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0bf..2c7dadbca 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;
--
2.23.0
^ permalink raw reply [flat|nested] 24+ messages in thread* [dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21
2020-04-20 9:34 [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21 Ray Kinsella
` (4 preceding siblings ...)
2020-04-30 10:21 ` [dpdk-dev] [PATCH v5] " Ray Kinsella
@ 2020-04-30 10:27 ` Ray Kinsella
2020-04-30 10:27 ` Ray Kinsella
2020-05-04 22:05 ` Thomas Monjalon
5 siblings, 2 replies; 24+ messages in thread
From: Ray Kinsella @ 2020-04-30 10:27 UTC (permalink / raw)
To: dev
Cc: david.marchand, Ray Kinsella, Thomas Monjalon, Neil Horman,
Jingjing Wu, Beilei Xing, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu
Sending again, as I missed the cover letter last time.
v6:
* combined policy and versioning in the maintainers file.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 10 +++++-----
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
.../common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
.../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 17 insertions(+), 12 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 24+ messages in thread* [dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21
2020-04-30 10:27 ` [dpdk-dev] [PATCH v6 1/1] " Ray Kinsella
@ 2020-04-30 10:27 ` Ray Kinsella
2020-05-04 22:23 ` Thomas Monjalon
2020-05-04 22:05 ` Thomas Monjalon
1 sibling, 1 reply; 24+ messages in thread
From: Ray Kinsella @ 2020-04-30 10:27 UTC (permalink / raw)
To: dev
Cc: david.marchand, Ray Kinsella, Thomas Monjalon, Neil Horman,
Jingjing Wu, Beilei Xing, Matan Azrad, Shahaf Shuler,
Viacheslav Ovsiienko, Jerin Jacob, Nithin Dabilpuram,
Alfredo Cardigliano, Mahipal Challa, Cristian Dumitrescu
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI version is declared."
Combined abi policy and versioning in maintainers, add map files to the
filter to more closely monitor future abi changes.
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
MAINTAINERS | 10 +++++-----
devtools/libabigail.abignore | 5 +++++
drivers/common/iavf/rte_common_iavf_version.map | 2 +-
drivers/common/mlx5/rte_common_mlx5_version.map | 2 +-
.../common/octeontx2/rte_common_octeontx2_version.map | 2 +-
drivers/net/ionic/rte_pmd_ionic_version.map | 2 +-
.../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +-
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +-
lib/librte_meter/rte_meter_version.map | 2 +-
9 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e05c80504..9756cb752 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -83,10 +83,6 @@ M: Marko Kovacevic <marko.kovacevic@intel.com>
F: README
F: doc/
-ABI Policy
-M: Ray Kinsella <mdr@ashroe.eu>
-F: doc/guides/contributing/abi_*.rst
-
Developers and Maintainers Tools
M: Thomas Monjalon <thomas@monjalon.net>
F: MAINTAINERS
@@ -140,10 +136,12 @@ M: Michael Santana <maicolgabriel@hotmail.com>
F: .travis.yml
F: .ci/
-ABI versioning
+ABI policy & versioning
+M: Ray Kinsella <mdr@ashroe.eu>
M: Neil Horman <nhorman@tuxdriver.com>
F: lib/librte_eal/include/rte_compat.h
F: lib/librte_eal/include/rte_function_versioning.h
+F: doc/guides/contributing/abi_*.rst
F: doc/guides/rel_notes/deprecation.rst
F: devtools/check-abi.sh
F: devtools/check-abi-version.sh
@@ -155,6 +153,8 @@ F: devtools/update_version_map_abi.py
F: devtools/validate-abi.sh
F: buildtools/check-symbols.sh
F: buildtools/map-list-symbol.sh
+F: drivers/*/*/*.map
+F: lib/*/*.map
Driver information
M: Neil Horman <nhorman@tuxdriver.com>
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 986a52771..b0147fde6 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -29,3 +29,8 @@
type_kind = enum
name = rte_eth_event_type
changed_enumerators = RTE_ETH_EVENT_MAX
+; Explicit ignore ABI 20.0.1
+[suppress_function]
+ symbol_version = DPDK_20.0.1
+[suppress_variable]
+ symbol_version = DPDK_20.0.1
diff --git a/drivers/common/iavf/rte_common_iavf_version.map b/drivers/common/iavf/rte_common_iavf_version.map
index 2f11d67c0..92ceac108 100644
--- a/drivers/common/iavf/rte_common_iavf_version.map
+++ b/drivers/common/iavf/rte_common_iavf_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
iavf_init_adminq;
diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map
index b58a37827..564a9a7fb 100644
--- a/drivers/common/mlx5/rte_common_mlx5_version.map
+++ b/drivers/common/mlx5/rte_common_mlx5_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
global:
mlx5_class_get;
diff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map
index 8f2404bd9..01279c339 100644
--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
@@ -34,7 +34,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
otx2_eth_dev_is_sec_capable;
diff --git a/drivers/net/ionic/rte_pmd_ionic_version.map b/drivers/net/ionic/rte_pmd_ionic_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/net/ionic/rte_pmd_ionic_version.map
+++ b/drivers/net/ionic/rte_pmd_ionic_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
index bc8fd6d4d..acdaf587d 100644
--- a/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
+++ b/drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map
@@ -1,4 +1,4 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
index 179f7f1ae..4a76d1d52 100644
--- a/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
+++ b/drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.1 {
+DPDK_21 {
local: *;
};
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index fc12cc0bf..2c7dadbca 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -13,7 +13,7 @@ DPDK_20.0 {
local: *;
};
-DPDK_20.0.1 {
+DPDK_21 {
global:
rte_meter_trtcm_rfc4115_color_aware_check;
--
2.23.0
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21
2020-04-30 10:27 ` Ray Kinsella
@ 2020-05-04 22:23 ` Thomas Monjalon
0 siblings, 0 replies; 24+ messages in thread
From: Thomas Monjalon @ 2020-05-04 22:23 UTC (permalink / raw)
To: Ray Kinsella
Cc: dev, david.marchand, Neil Horman, Jingjing Wu, Beilei Xing,
Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko, Jerin Jacob,
Nithin Dabilpuram, Alfredo Cardigliano, Mahipal Challa,
Cristian Dumitrescu, Ray Kinsella
30/04/2020 12:27, Ray Kinsella:
> Change references to abi 20.0.1 to use abi v21, see
> https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
>
> "Major ABI versions are declared no more frequently than yearly.
> Compatibility with the major ABI version is mandatory in subsequent
> releases until a new major ABI version is declared."
>
> Combined abi policy and versioning in maintainers, add map files to the
> filter to more closely monitor future abi changes.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Applied with added change for recent igc PMD:
--- a/drivers/net/igc/rte_pmd_igc_version.map
+++ b/drivers/net/igc/rte_pmd_igc_version.map
@@ -1,3 +1,3 @@
-DPDK_20.0.2 {
+DPDK_21 {
local: *;
};
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21
2020-04-30 10:27 ` [dpdk-dev] [PATCH v6 1/1] " Ray Kinsella
2020-04-30 10:27 ` Ray Kinsella
@ 2020-05-04 22:05 ` Thomas Monjalon
1 sibling, 0 replies; 24+ messages in thread
From: Thomas Monjalon @ 2020-05-04 22:05 UTC (permalink / raw)
To: Ray Kinsella
Cc: dev, david.marchand, Ray Kinsella, Neil Horman, Jingjing Wu,
Beilei Xing, Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko,
Jerin Jacob, Nithin Dabilpuram, Alfredo Cardigliano,
Mahipal Challa, Cristian Dumitrescu
30/04/2020 12:27, Ray Kinsella:
> Sending again, as I missed the cover letter last time.
You don't need a cover letter for a single patch.
The changelog can be added below --- in a patch.
^ permalink raw reply [flat|nested] 24+ messages in thread