From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 6F7445B1C
 for <dev@dpdk.org>; Wed, 17 Oct 2018 13:43:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 707999E1;
 Wed, 17 Oct 2018 07:43:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 17 Oct 2018 07:43:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=vK+6n6SdTGvd0WaBb8jsfxXbV5FhaH8PsnjoyZmVl8I=; b=ApxAlvotVCQ/
 wIok8LtWEwxoht78HdrL28eHkkUP8j7k5xB69gJLm53ggc+WE0opfNdChvHGNVLn
 B4J8MguFPefttENq+BcNjd1i2DDddhKmQrGaGlGl3JUzxr8Hc9uUiPVFFA6EOez4
 SGgVHbtiOydSzYeFewOP1RpO4EOq6l8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=vK+6n6SdTGvd0WaBb8jsfxXbV5FhaH8PsnjoyZmVl
 8I=; b=X5zj1dlEBAx+Z8zVF8md+n5Ky9wrYHBJP4OKK1g1JoSY7YsiTubwKvmWj
 alHzg05objR7hHFEs8gk+uTr5M7YrxZUgb7FZpzDLGII8TYjdszN7bbqnjfG+TuO
 2QNJT7Z4IvpRqlyzTuUYclP0grTGOxu1nmUzLtpEg4VEx7So/nfSUCZJzplpQQLK
 DalrQEPVx8nrAfewZpXnOL/HZuSeVgPLpY9P4k1U8iMwdICR44KBXjUgm+31ym+z
 HR61NyWR++Vx5UnXmjuIJ+wfCsDnHIgPuWZLDRjEopwsHmUwrX+ROpHSfXAj7985
 QmJbd7RhS8PWsZ7H81Ht8GiOyFHUw==
X-ME-Sender: <xms:ViDHWxo41DzLiUfAKIbqaCAnKDCYbhZgmjTAnWOSvUSxefxLh-1RsQ>
X-ME-Proxy: <xmx:ViDHW58V3k-YxskeHPrwWpNGh6lzNdKwRZuHaWKcu8ZY0D9MVeIGqw>
 <xmx:ViDHW94E2Y2atr4hBxlu9XKLK4qcZSmB2s3tdyd6mtJLTSYAFg_ZYg>
 <xmx:ViDHW43PSIj2G8t1BM2jplENj066Gp-z57hIJWjYm0z8kQC4hura3Q>
 <xmx:ViDHW8CKO_e8SHgwslBjZmXMdXoDy53lnJh0J7L4dICDDEb7R8wcvg>
 <xmx:ViDHWy1_mslii4ufdeBuEDP1Ly2iH7O0maxJwIQceyfg3zaREdYNdA>
 <xmx:VyDHW8QueC8TNBYX4Iakzw0mxTmq9EnVMaHqtIrsBG-O_GsaWjPoqg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B6390E4119;
 Wed, 17 Oct 2018 07:43:17 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Date: Wed, 17 Oct 2018 13:43:21 +0200
Message-ID: <19031454.2TYKyzlM3p@xps>
In-Reply-To: <20181017112350.19811-1-david.hunt@intel.com>
References: <20181017112350.19811-1-david.hunt@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] Update release notes for container power
	policies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Oct 2018 11:43:22 -0000

17/10/2018 13:23, David Hunt:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  doc/guides/rel_notes/release_18_11.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Why this patch is alone? It is for a change already applied?
If you forgot the release notes, you should add a Fixes: line
so we know which code change it refers.
Thanks

> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
> index 9c00e33cc..3174a0f80 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -88,6 +88,13 @@ New Features
>    the specified port. The port must be stopped before the command call in order
>    to reconfigure queues.
>  
> +* **Added JSON power policy interface for containers .**
> +
> +  Extended the Power Library and vm_power_manger sample app to allow power
> +  policies to be submitted via a FIFO using JSON formatted strings. Previously
> +  limited to Virtual Machines, this feature extends power policy functionality
> +  to containers and host applications that need to have their cores frequency
> +  controlled based on the rules contained in the policy.
>  
>  API Changes
>  -----------

You must keep a double blank line before before next heading.

Anyway you should move it before testpmd note, as explained in the comment:
     Suggested order in release notes items:
     * Core libs (EAL, mempool, ring, mbuf, buses)
     * Device abstraction libs and PMDs
       - ethdev (lib, PMDs)
       - cryptodev (lib, PMDs)
       - eventdev (lib, PMDs)
       - etc
     * Other libs
     * Apps, Examples, Tools (if significative)