From: Thomas Monjalon <thomas@monjalon.net>
To: 11 <caowenbo@mucse.com>, yaojun@mucse.com
Cc: dev@dpdk.org, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru
Subject: Re: [PATCH v5 1/8] net/rnp: add skeleton
Date: Wed, 30 Aug 2023 18:27:43 +0200 [thread overview]
Message-ID: <1906580.taCxCBeP46@thomas> (raw)
In-Reply-To: <5BDBD6571B89977B+005b01d9d412$6d346370$479d2a50$@mucse.com>
21/08/2023 11:32, 11:
> Hi Thomas,
>
> Thanks for your useful advice, previously only focused on code format
> and Ignored document format.
no worries
> > > +#. Running testpmd:
> > > +
> > > + Follow instructions available in the document
> > > + :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
> > > + to run testpmd.
> >
> > Do we really need that referencing the same document as above?
> For this block, there's really no need to add this.
> Previous ideas I want to add new content as the subsequent code is
> submitted.
> Do I need to add full features and NIC Description at the first code commit
> ?
The best is to introduce doc when code is added, in the same patch.
So no full features in the first patch :)
next prev parent reply other threads:[~2023-08-30 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 2:16 [PATCH v4 0/8] [v4]drivers/net Add Support mucse N10 Pmd Driver Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 1/8] net/rnp: add skeleton Wenbo Cao
2023-08-15 11:10 ` Thomas Monjalon
2023-08-21 9:32 ` 11
2023-08-30 16:27 ` Thomas Monjalon [this message]
2023-08-07 2:16 ` [PATCH v5 2/8] net/rnp: add ethdev probe and remove Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 3/8] net/rnp: add device init and uninit Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 4/8] net/rnp: add mbx basic api feature Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 5/8] net/rnp add reset code for Chip Init process Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 6/8] net/rnp add port info resource init Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 7/8] net/rnp add devargs runtime parsing functions Wenbo Cao
2023-08-07 2:16 ` [PATCH v5 8/8] net/rnp handle device interrupts Wenbo Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1906580.taCxCBeP46@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=caowenbo@mucse.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=yaojun@mucse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).