From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9BB16568A for ; Wed, 13 Mar 2019 12:19:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 27628221EE; Wed, 13 Mar 2019 07:19:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 13 Mar 2019 07:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AxY20emzSBUnonNPkh1CM0BnjQHvkNMrQqV7puOLDjE=; b=OKZZZHQyxQbX Ha/8pTUaxj2yQCx7ihVuql+vBRvC5VF99RESVxEymkueLFbSUky8yBCnWFEpBf5r D6Y8RhCgWvuGG+7JW2DwIzkr5EAF0mGcHRjh0/h9XJFQw6COxZ4w6nVtO3amNTob HGcUD7NUpkiOsBzo768uCOWHBQYOExo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AxY20emzSBUnonNPkh1CM0BnjQHvkNMrQqV7puOLD jE=; b=swcr816axPCOJ+UUy0yvW2y1DRJkJ0mSGXzN9IlKRryNyuoMBPRnwiVAb LbO8+uhWg7D1Xu92g0rsiPer42pQrxmQ88ojfnvRFBPw/TDVxSNiKEbtDv7tPu6R 5MkTJ3DSCH0GJQs55mGfiWGNRReQga60X43yXhcbVMqpTowVzBH9LPf8A7DN2b17 hj+eMnsUqYghQVkVvAzS2E2+sE6JzHZDavxsIoMFA5nsrrJeD8Dv5nMqQZOTG4Pa quFdQvFDMhAyPx3IbzNB9OU9UQ6AYiCxSPCIiKIjxZM/44dyMLVHpeqS/Q3B85pL VSRWZzNmnSuAiGD0mIJWYIOEPe7nw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrhedtgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1B39BE46B8; Wed, 13 Mar 2019 07:19:24 -0400 (EDT) From: Thomas Monjalon To: Shahaf Shuler Cc: "anatoly.burakov@intel.com" , "dev@dpdk.org" , Yongseok Koh , "ferruh.yigit@intel.com" , "nhorman@tuxdriver.com" , "gaetan.rivet@6wind.com" Date: Wed, 13 Mar 2019 12:19:22 +0100 Message-ID: <1907286.xmCKSEcAjO@xps> In-Reply-To: References: <1698312.TEgN2QzQvo@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:19:26 -0000 13/03/2019 12:12, Shahaf Shuler: > From: Thomas Monjalon > > > +/** > > > + * Device level DMA map function. > > > + * After a successful call, the memory segment will be mapped to the > > > + * given device. > > > + * > > > + * @note: Memory must be registered in advance using rte_extmem_* > > APIs. > > > > Could we make more explicit that this function is part of the "external > > memory API"? > > How do you suggest? There could be an explicit comment. > This function belongs to rte_dev therefore the rte_dev prefix. better rte_dev_extmem_dma_map ? Not sure about the prefix. Anatoly?