From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B38DA0471 for ; Mon, 15 Jul 2019 19:18:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A02A62E81; Mon, 15 Jul 2019 19:18:34 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2977A2C6A for ; Mon, 15 Jul 2019 19:18:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6D3C21385; Mon, 15 Jul 2019 13:18:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Jul 2019 13:18:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wwcu9r+Jl6Vi2ZJF98M6UhXnRP8NYTYS5WpFqtiGOho=; b=GmXjlfrIqHAH sd6I6iw8PgiGnyKsGjFd64FuTB42Oj3rs09lscE3kLx/0dfwIfF14R9SkjbfjjSq tdLflZFz4s/kvc7S7x1Q9EsgpS50/xJXVsJc3qyV/sPchJSmKsjzFIMdg7z8zNnV /EJVonPjI+YO6V7NkfDJWFrKT4mTJy4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Wwcu9r+Jl6Vi2ZJF98M6UhXnRP8NYTYS5WpFqtiGO ho=; b=DGlh2CpsfoZrBR7c/A6s3VvuL3Oz4BSqN4OIpu8LO5IBukfkJwL6meCbY /Rv49XhVziqKW0g+uU3H9J8uRwqV2LANLfkbVzZSabUVT87odYybGybLRNVfVnXr ZmOFkWmpvjbafv9lav98Cq4fyHRDwGGQJ14WV6GRiw0T1fdWBh5qx9rAaxYjVqJF VIQP1M56pBahhlQLIdfN0BUEgkbOoNKU5AD7ZG5fUO1v5eFJ4uwU1pyfdWWenHrB RJS4xelRTD0Czu4BFKD/Z5w2tdsMkf+8YVU3Kpw1/M3zOozPsw4hKtczLrEjfOQr QfA+iCSERbVLqKlB2+SeS93ZWEeDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrheekgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87F3880060; Mon, 15 Jul 2019 13:18:30 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 15 Jul 2019 19:18:29 +0200 Message-ID: <1908272.KHashDMTnH@xps> In-Reply-To: <9f57a144-6601-9288-8084-d5eb1b3e9f47@intel.com> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190624164714.6560-1-stephen@networkplumber.org> <9f57a144-6601-9288-8084-d5eb1b3e9f47@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 0/9] kni: fixes and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/07/2019 19:03, Ferruh Yigit: > On 6/24/2019 5:47 PM, Stephen Hemminger wrote: > > While testing KNI with netvsc, saw lots of places more code > > could be safely removed from KNI kernel driver. > > > > v6 - more updates to documentation > > v5 - add minimal ethtool, fix checkpath author complaints > > v4 - add more style fixes > > v3 - rebase to current master, add style fix patch > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > Stephen Hemminger (9): > > kni: don't need stubs for rx_mode or ioctl > > kni: use netdev_alloc_skb > > kni: don't keep stats in kni_net > > kni: drop unused fields > > kni: use proper type for kni fifo's > > kni: return -EFAULT if copy_from_user fails > > kni: fix style issues > > kni: add minimal ethtool > > doc: update KNI documentation > > For series, > Acked-by: Ferruh Yigit > > Thanks for the cleanup. > > I am OK to get the set for rc2, but if we will do this please lets merge this > early so that we can still have time to test and fix any possible issues before rc2. Applied, thanks