From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 33E2F2BE3 for ; Tue, 2 Oct 2018 12:43:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF3C520CA5; Tue, 2 Oct 2018 06:43:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Oct 2018 06:43:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=im6H0brB+Q7JN4t75VD3GISke7 R7+IDoSBK6ZqrbSdQ=; b=MzOefQKyxye3znK475K+UCASUAcTQHuVL2BMmHHU2d ASq7M2ZGOUPPZKYs38u7EolGlv+b1WsZlmHto41dy6dlNtYibSPFwXU5CFykMTTv BRyk0HAwCk+lTLHlCe01YH3uo7PgKEJv/dnAyvGEjE29QVzSp95eOqTKwSPocT86 Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=im6H0b rB+Q7JN4t75VD3GISke7R7+IDoSBK6ZqrbSdQ=; b=a9R5IrzwP+3feF5mXG/cgU kKmryI0ViPgB8CSimA69hhOHQz4pLWZs4EfX9Jqrr8sOdQ4gMCKrU7cxLXfyIUsW c+qLHIeqWuMM1PuDEw+McJYIsev4q5GNOuTFD9AZ4i8oWpt0OODf6Eluz2l4gcEb 6Nbc9ctz/+qMh0X+vLIawuHGWE3gX8tys4wbXt28fUFujC1RRo27xIXDAQh8K7By qyezQrpIJrFjJvI6KTz5ntGQlNn8EhAlFvs/d0w32FqmOS0WAkMmA+t2iaQnO4dw wUO080lT+F8vD5QM+aSNIhFZctsrhOpCwRtAFW6Y6aizL7c4x4wkQzjBVvqJ09/w == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79A4FE49CB; Tue, 2 Oct 2018 06:43:43 -0400 (EDT) From: Thomas Monjalon To: Raslan Darawsheh Cc: dev@dpdk.org, "keith.wiles@intel.com" , Shahaf Shuler , Ori Kam Date: Tue, 02 Oct 2018 12:43:42 +0200 Message-ID: <1910504.ryvcqbe86A@xps> In-Reply-To: <1538476438-20891-2-git-send-email-rasland@mellanox.com> References: <1538047196-13789-2-git-send-email-rasland@mellanox.com> <1538476438-20891-1-git-send-email-rasland@mellanox.com> <1538476438-20891-2-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 10:43:45 -0000 02/10/2018 12:34, Raslan Darawsheh: > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > @@ -67,6 +67,10 @@ New Features > SR-IOV option in Hyper-V and Azure. This is an alternative to the previous > vdev_netvsc, tap, and failsafe drivers combination. > > +* **Added TAP Rx/Tx queues sharing with a secondary process.** > + > + A secondary process can attach a TAP device created in the primary process, > + probe the queues, and process Rx/Tx in a secondary process. A blank line is missing here. > @@ -2006,9 +2115,23 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > TAP_LOG(ERR, "Failed to probe %s", name); > return -1; > } > - /* TODO: request info from primary to set up Rx and Tx */ > eth_dev->dev_ops = &ops; > eth_dev->device = &dev->device; > + eth_dev->rx_pkt_burst = pmd_rx_burst; > + eth_dev->tx_pkt_burst = pmd_tx_burst; > + if (!rte_eal_primary_proc_alive(NULL)) { > + TAP_LOG(ERR, "Primary process is missing"); > + return -1; > + } > + process_private = (struct pmd_process_private *) > + rte_zmalloc_socket(name, > + sizeof(struct pmd_process_private), > + RTE_CACHE_LINE_SIZE, > + eth_dev->device->numa_node); > + > + ret = tap_mp_attach_queues(name, eth_dev); > + if (ret != 0) > + return -1; > rte_eth_dev_probing_finish(eth_dev); > return 0; > } Should we manage rte_pmd_tun_probe too?