From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D022A0547; Mon, 8 Feb 2021 12:21:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F36AC4014E; Mon, 8 Feb 2021 12:21:21 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 2986140147 for ; Mon, 8 Feb 2021 12:21:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 785C4580108; Mon, 8 Feb 2021 06:21:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 08 Feb 2021 06:21:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= RXK9KbnTBBaXE5D8Te2quHE4bXp1mokUztakLs+7gm4=; b=IIdtkj8Xl7TPJfRi Hz/Infq1sFDgFCrwBTKZ9mW3v1RmQynXJbSa1N/lqKA0nFQIrFDuXsAoZpWEz5PF hQMT2dU/7W5YFUy/fZ72fE2Vp0o+6iZhCeYEyUKpm237kktJT9ees1wGVadEDknc FsCf0cTEf22AiMRE30ohBCBI/RXoAknjIBccCqiJiwobw3pNInX54AswK7+iJSU+ cULVjnd1997JO0vG58eQOW9KfVXb+KdvPohUuiM3ZQ52eR8IQqd+DRPna/hyhPJX VhiAJsJKrUiLY4JGasGZhKSmjZPPtLH8Hm0MpsvmdLnKXif5iln/ZNDJrN8El7Xd wav/Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RXK9KbnTBBaXE5D8Te2quHE4bXp1mokUztakLs+7g m4=; b=mQ/sRUjcLaWu6Mh6H/X1m6mM2PMdrmOSflb6uFr3Im9rIDy9hpN6MxUSy 4XSc6ckalkgY3NItpvhvI1/LOv/COyChkt2z3Py0x1n4igk+lhOPTklb9MFdQdZR eODb/bZgyNejh/tQRj9iY3oHYAVvg8yjFxL7WTGgJnMYUmuvo63Ahr5RuuhZ8+M9 M6OQxE7NBs2wbcIA+8HPMC5/JnDZWx/VrTnLd3kS0/VGoqeIp6VxFV3njHWYcpOq 6vQp4xgcMOCXS8QLU1xyDzpF+qN6ktQ2ZDLdHH3jQbAD58Sp+VznYN+R11L/TZXb wMF3q4/aRSsF6Yz7udKs0f+M1qYDQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheefgddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 61E17240057; Mon, 8 Feb 2021 06:21:18 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" , "david.marchand@redhat.com" , "bluca@debian.org" Date: Mon, 08 Feb 2021 12:21:17 +0100 Message-ID: <1912027.TsnqTu0DiD@thomas> In-Reply-To: <20210208110531.GB2020@bricha3-MOBL.ger.corp.intel.com> References: <1612536397-18008-1-git-send-email-juraj.linkes@pantheon.tech> <7945884.dXLI3N8YQt@thomas> <20210208110531.GB2020@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/02/2021 12:05, Bruce Richardson: > On Mon, Feb 08, 2021 at 11:56:21AM +0100, Thomas Monjalon wrote: > > 08/02/2021 11:26, Bruce Richardson: > > > On Mon, Feb 08, 2021 at 10:17:56AM +0000, Juraj Linke=C5=A1 wrote: > > > > From: Bruce Richardson > > > > > On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linke=C5=A1 wrote: > > > > > > The kni linux module is using a custom target for building, whi= ch > > > > > > doesn't take into account any cross compilation arguments. The > > > > > > arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) = and CC, > > > > > > LD (for clang). Get those from the cross file and pass them to = the > > > > > > custom target. > > > > > > > > > > > > The user supplied path may not contain the 'build' directory, s= uch as > > > > > > when using cross-compiled headers, so only append that in the d= efault > > > > > > case (when no path is supplied in native builds) and use the > > > > > > unmodified path from the user otherwise. Also modify the instal= l path > > > > > > accordingly. > > > > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > > > --- > > > > >=20 > > > > > Thanks, this all looks ok to me now, bar one very minor nit below= =2E Doing a native > > > > > build on my system with the running kernel also works fine. > > > > >=20 > > > > > However, the bigger question is one of compatibility for this cha= nge. The current > > > > > documentation for the kernel_dir option is: > > > > > option('kernel_dir', type: 'string', value: '', > > > > > description: 'Path to the kernel for building kernel modules. \ > > > > > Headers must be in $kernel_dir/build. Modules will be installed \ > > > > > in $DEST_DIR/$kernel_dir/extra/dpdk.') > > > > >=20 > > > > > Obviously the description now needs an update to reflect the new = use > > > >=20 > > > > I'll change the description. The current patch version is always in= stalling the modules into '/lib/modules/' + kernel_version + '/extra/dpdk',= though. I don't think we want to change the behavior this way, so I'll mak= e the changes to preserve to original behavior ('/lib/modules/' + kernel_ve= rsion + '/extra/dpdk' when kernel_dir is not supplied, kernel_dir + '/extra= /dpdk' when it is). > > > >=20 > > >=20 > > > In the absense of an explicit kernel_install_dir, I actually think th= e new > > > way is better. However, I'd be interested in other opinions on this. > >=20 > > I'm not following. What do you call the "new way"? >=20 > Setting the install path to /lib/modules/ for native builds igno= ring > kernel_dir value. What is the advantage of ignoring an user parameter?