From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id 301A51E20 for ; Wed, 5 Apr 2017 13:51:01 +0200 (CEST) Received: by mail-wr0-f182.google.com with SMTP id w43so10398758wrb.0 for ; Wed, 05 Apr 2017 04:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=HFtdhxNvmP4J438Oe6pYCjC+dm5xduJ6Cz1JuRsDznU=; b=rYacuQPpukQE51GvhTb9f8nuhyhn5UoYTc9b+tYxF0s68hKicmBKbI+Pwrx0n1J1rG 8I+kLF9i2zMGtY8/f3Shh2iqL9c6X6BIFWBnOx6mJ/pOFatXuEUT1whFyLWxvFXvqU6L llLRfMLHg/+sy94Iim4CEfMCIpEWb8vMprfCCZNsEw1qjhpNw5bPsrQabO8jcHX6Wp6M LqMAT6em0vN5qAYhM0jFOdL8Qs1c2LTcEbT7UYEz03j18f79A2OZHK+FBOpZZ4Cn2bZA TZ2BS94tnum0Y5kYYib6P95ZMvQS45dc7+xSvBEJHGuey6nAZmN584mgIS0OPyqNQssj +2cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=HFtdhxNvmP4J438Oe6pYCjC+dm5xduJ6Cz1JuRsDznU=; b=W9vWIdrWwKFRYSbx6xry1gT7S18Ty1CyK4Uavrjytkhhjtj9gJ/rfBsyAzSX/njRos Gfbf+1MFrJ9HIooqRXo7a8amzxhisu/o97XyuwPFTOPN1VFvSm5y/3CTTj+L9qAqhCnv 0LmSSCw2LmpKohX9aYlcuQuV+9+Fyb2KzJp4uaD54T+8n0Z4aWi6/tamNbNMSsF3ocMr ypsOSn1AvceFPdqwhm4ombWFMtRHaxmnXlLwlLra+lwdFQ0ysaFQCmrfyVRdLhtIIAXV NG/CUCMLhBx6Hf1MxDv24ARlJ2WX7V47rqfajPKSMQLajUpGdn7LHcbokk6u8ni7Ti4m CNuw== X-Gm-Message-State: AFeK/H2FjMUvrtFM8VRX1H3R1BD8N6C35ZQCC4WjfuE0WBGqZWjeId08tkLiqFsdBWkbiigT X-Received: by 10.28.12.66 with SMTP id 63mr19364657wmm.47.1491393060602; Wed, 05 Apr 2017 04:51:00 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q129sm26625497wmg.1.2017.04.05.04.50.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 04:50:59 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com, pablo.de.lara.guarch@intel.com Date: Wed, 05 Apr 2017 13:50:58 +0200 Message-ID: <1913108.MtspqzMU4y@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170404164040.24132-1-olivier.matz@6wind.com> References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 11:51:01 -0000 2017-04-04 18:40, Olivier Matz: > The objective of this patchset is to introduce a framework to > support dynamic log types in EAL. It also provides one example of use > (in i40e). > > Features: > - log types are identified by a string > - at registration, a uniq identifier is associated to a log type > - each log type can have its level changed dynamically > - extend command line parameters to set the log level of a specific > type, or logs matching a regular expression > - keep compat with other legacy types (eal, malloc, ring, user*, > etc... keep their hardcoded log type value) Applied, thanks > Next step is to adapt drivers, libs and apps to use this new API. At the > end, we can expect that all non-dataplane logs are moved to be dynamic, > so we can enable/disable them at runtime, without recompiling. Many > debug options can probably be removed from configuration: > $ git grep DEBUG config/common_base | wc -l > 89 Please maintainers, let's remove these useless DEBUG options! Thanks