From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id F108E9E7 for ; Sat, 10 Sep 2016 10:20:07 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id 1so67899766wmz.1 for ; Sat, 10 Sep 2016 01:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z6Mfr86IjESoml/c8qPKVhO8Grvz4gG6cHR0nBwB/94=; b=mjr9K7CRVkXNA0TO/PcEPctPLTBNAShX5yvgzy0IvhtdJTMD1PeLGW21Alj5PDWcoP 0fc6IUXb2z3KD+E/Z7IF8nOeJi6MtIJRC9ZZCnxaEDHHsJ8Okffgb+YjrFM6q6h+9lq4 s49scrdt+chf2ACqT227cotshNzu+7GicjFb/Olrs1Z8fOnEvZ+Ffp+ML58GU3x5Ls9r Gknoy2kHYS6sQQXCw8auuvqv5Qh75pX73YhY0Ty8+ub2EhoZhFsebB8Grc9zIj04heb9 AEIhs3XK+F+7m2tmXoF/ai8C/sj5ZNcVCJd/YvrSRNnEU5zpg3vtre2xzVmPoKCWIQtH Fg5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z6Mfr86IjESoml/c8qPKVhO8Grvz4gG6cHR0nBwB/94=; b=Hl/ePD88SPxUOO43I/6X4dQtJp4Gel9i1RJL2ViuAWDO6wrxe7wcT85F1FGN0wMpBC IJFBS2nqIatWiFNJC2aceIOrneX4LNELWxl0kP9NMg7lbMz5ZCo5goZMVjteeiC7HOPW upHERvohQZH2TcXCIuWX9ptsuEZ+Gk9CFgz96SsV2TFFjx6U1W65kaUQ4YC0cQMiHG2b xG+qS1mVwKdO2jL4g8sq7M5XrId6V/C2C8Ik/mOo93j8MkRst8ulWN3uSbcAecnNH4eU SjdyB9hEYFrDWYFUSGCJTvduY9ZSF5zAG1U7nQycTw+iSXB9F1aur/GlrtEHz5uCuwGt zkLg== X-Gm-Message-State: AE9vXwNtrh6cZnU+77njbWlgkm+D7nXn6jDAnSu17kdboDZsLoCycA7fD8HGpEnPa3oVs+oR X-Received: by 10.194.73.9 with SMTP id h9mr5202079wjv.21.1473495607711; Sat, 10 Sep 2016 01:20:07 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v73sm7143431wmf.19.2016.09.10.01.20.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Sep 2016 01:20:06 -0700 (PDT) From: Thomas Monjalon To: Finn Christensen Cc: Neil Horman , dev@dpdk.org, "stephen@networkplumber.org" Date: Sat, 10 Sep 2016 10:20:06 +0200 Message-ID: <1913786.NX7M2nQ5WY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160908111424.14127-1-fc@napatech.com> <20160909135108.GA15908@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ntnic: add PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 08:20:08 -0000 2016-09-10 07:58, Finn Christensen: > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > On Fri, Sep 09, 2016 at 12:48:38PM +0000, Finn Christensen wrote: > > > This is the Napatech NTNIC Poll Mode Driver (PMD) for DPDK. > > > > > > This patch adds support for Napatech NICs to DPDK. This is the > > > initial implementation. > > > > > > Signed-off-by: Finn Christensen > > > --- > > > v3: > > > * Removed the need for binary libraries on build > > > v2: > > > * Added information how to build the PMD without NIC > > > Board Support Package > > > * Fixed some formatting issues > > > > So, this is a step in the right direction, but I think its solving the wrong > > problem. If you have a dependency on an external library, thats ok, and > > accessing it via dlopen makes it possible to build the library without having > > that library present, but it not really in keeping with the spirit of what I > > meant. This driver is still effectively dependent on a binary blob that we > > have > > no visibility into. The better solution is releasing the source for the ntnic > > and ntos libraries. The license file in the referenced git tree indicates its > > BSD licensed, so I don't think there should be a problem in doing that. > > > > Neil > > > No, unfortunately the ntapi is not BSD licensed, only the header files that > you can freely download are. > We are building this NT NIC by using parts or our technology from our > capture adapters and that is using closed source software. > > We are new to opensource and we want to go that way, but we haven't > yet a complete stand-alone driver ready that we can put into the DPDK > PMD to have a complete self contained and open sourced DPDK PMD, that > only needs the actual HW NIC plugged in to run. > Therefore this version is implemented as a virtual device, exactly like the > PCAP PMD driver is, and it runs on top of a driver that follows the NIC itself. > > In regards to the DPDK functionality we do not see that anything is missing. > I cannot either see where we should add source code, because it is not part > of the DPDK package and it should not be either. > > One of the things I really liked about the DPDK open source project is that it > uses BSD licensing not GPL. Therefore, I must admit, we completely failed > to see that the "spirit" of the DPDK community is not really BSD. Our view > of this community was that the main driving force of it was to be able to > make DPDK run on everything anywhere effectively, in a global contributing > community, without any legally constrains prohibiting us to do so. It is difficult to define what is the spirit of a community, especially only after few mail exchanges. I agree that running on everything anywhere is a nice goal. Here Neil, as a RedHat developer, is probably concerned about enabling your driver in a distribution. It seems your model is not compatible with the "anywhere goal" and will be disabled in that case, until it is fully open. > However, this is our standing, and I don't know what else to do. > Please advise or NAK this PMD. I do not remember having already seen such model in DPDK. So we need to think about the implications a bit more. (Comments/discussions are welcome) Thanks for your patience.