From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AE1192BB5 for ; Fri, 1 Mar 2019 15:30:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3823D22165; Fri, 1 Mar 2019 09:30:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Mar 2019 09:30:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Sj1qPLj48LEBrq+D23TGpX3C3OvgVvyhKJSUlaaPCuc=; b=Pz5A8D6fLtmn S36eZVgS+KNwQ+kx1Rh8vyVMir/yrm+aOYyFk1Z/Gv2HB4LMTwKKybIGA9/uSXNL OGFoK+TfK6smFWS1tifIQofZLFFCDgU35THXsl4oXVjiqiDIOn4tkSn5H6V40s78 raANRvHCiHW0ma4zcLfuvTMiC3W2c6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Sj1qPLj48LEBrq+D23TGpX3C3OvgVvyhKJSUlaaPC uc=; b=P4xtHOdVMYyEVsbIT7rSMPqK1Qkyv8uZGGs15WxQn1xsEPpwu3m5D8G3A +nKAO50m1Mojww30JefoifQ+RWkvaaS5lw/+gFBZ4wbiE9tGdjVKAJa2dfuSKWXA tK4JgrtPWDEa1cqIx+FCTPLtHzlopOszPHmq5aFmf5/pCrLy6gJSSUpJskSvWlz2 er8H5n+BAk98N6Uew0onwVE4nVavxQnFIIqugywnEQ7zAevfz0iIwGWMYDDTEqWx B9VWzAB2Ju5PaZ32Btzmukv8YlhoWmEl+UtINn+yGu6H/lTGVELQ5hQecMWgr9cU DvqCJvXo/3NDmd9ZKJblIqKKsvmOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id CED3EE4309; Fri, 1 Mar 2019 09:30:10 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, jeffrey.b.shaw@intel.com, ranjit.menon@intel.com Date: Fri, 01 Mar 2019 15:30:09 +0100 Message-ID: <1915046.8TnCJQ7qTk@xps> In-Reply-To: <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com> References: <20190301071847.13376-1-anand.rawat@intel.com> <1633455.prhy9BIAj0@xps> <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 14:30:12 -0000 01/03/2019 15:17, Bruce Richardson: > On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote: > > 01/03/2019 08:18, Anand Rawat: > > > +elif host_machine.system() == 'windows' + > > > dpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1) > > > > For consistency, it should RTE_EXEC_ENV_WINAPP. > > > For this one you can partially blame me - early internal review suggested > changing to winapp, but I suggested holding off on the change for community > consensus. Personally, I would prefer a little inconsistency and keep it > as windows for clarity. In future, I also think we should just rename > linxuapp to linux, and bsdapp to freebsd! OK I agree to remove APP suffixes. > However, for now, if the majority prefer winapp, I'm ok with it. [Though I > can't help reading it as winamp half the time! No llamas involved here > though!]