From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B46443C5E; Wed, 6 Mar 2024 15:43:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38B4B42E17; Wed, 6 Mar 2024 15:43:48 +0100 (CET) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id D1CC140276; Wed, 6 Mar 2024 15:43:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 3662C11400B1; Wed, 6 Mar 2024 09:43:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 06 Mar 2024 09:43:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1709736226; x=1709822626; bh=w95uyX0TEgf5AZgjwk/WiheezYje6SGpU0rqkrc7P3Q=; b= bdGF5dMG91vcApRgAUts7Lal3UHX6TKs1z+va3Cu9SCPMDwMipB3S6Zu+jH7jDFN oh8pEa5hdThpEotI8bC55ne7fTLpNiCXQR+hybnKbvNpxKNXM82+XcFRu+WaUwEL obEfZIGq36aSz7PqBZlzNbNlkm9EYFqmQy7zRVDDLU+YkwmfaFkb2Dm4F5MD/xoL ryhcVl/JKoCr2dTBJWIjlaIH9NssEsIpRdoBWv1YJZty3/JvKaTnl3UTjZenyLJY oVykYNmDVvxsoGzRPkjGJ8jya8aVK2PROTRVFCjyLEeK7b34G2KQ/QOD3rcn/UZE HLebhZq6JFP0V4PNcj2j2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709736226; x= 1709822626; bh=w95uyX0TEgf5AZgjwk/WiheezYje6SGpU0rqkrc7P3Q=; b=i 9pHDGnkaDl93gvjE+1D8tWxutqHtZ0BZq/RpSde3OsruRDgFpCJWwH6hjwmlSEaf tMdGUjof9nDRC5JdKNwPlXUC7TJ/UWDz3Q2zeEMuit+/IpZJzwxu5kAJx46SyuTQ HPbtaDVvsEWoLxotR0K8GkNuE40Zyl5D2DLO71AbRL5E2GwnkXjBIITfFf4qnoJf 9QEyBne74ycyG7dm00M6IrJ7JVH/f+weOfUoAXLy/B/VW/UGHM1BW3roPzvbDzT7 5g3c7eOGBAbfF+wLJOiY6u9dixpORU0jo/R02aPafdryGxQNWGJz5zPI9E33S2gt /jurMv2gS1JBP8P28Zsbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledriedugdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Mar 2024 09:43:44 -0500 (EST) From: Thomas Monjalon To: Joyce Kong Cc: Stephen Hemminger , stable@dpdk.org, Ruifeng Wang , "bruce.richardson@intel.com" , "dev@dpdk.org" , nd , "stable@dpdk.org" , Jerin Jacob , Pavan Nikhilesh Bhagavatula , paul.szczepanek@arm.com Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build Date: Wed, 06 Mar 2024 15:43:43 +0100 Message-ID: <1915782.GKX7oQKdZx@thomas> In-Reply-To: References: <20230822074743.3243015-1-joyce.kong@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > The platform value would be 'native' only when not cross build. > > > > Move the operation about modifying cpu_instruction_set while platform > > > > equals 'native' to the not cross build branch. > > > > > > > > Fixes: bf66003b51ec ("build: use platform for generic and native > > > > builds") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Joyce Kong > > > > Reviewed-by: Ruifeng Wang > > > > > > Looks right, what is the impact on existing users doing current cross builds? > > > > The original operation changes cpu_instruction_set to 'native' when both > > 'platform == native' and 'cpu_instruction_set == auto'. > > There was no impact on the existing users for current cross build, as the cross > > files set cpu field to a specific arch, such as 'armv8-a', and this didn't trigger > > the modification for cpu_instruction_set. > > However, if we want to use a common arch in cross files like 'auto', the > > modification operation would override 'native' value to cpu_instruction_set > > and b7676fcccab4 ("config: verify machine arch flag") would break the build > > as it tries to test -march=native. > > > > > > > > Acked-by: Stephen Hemminger > > Tested-by: Pavan Nikhilesh Applied without the second patch of the series, thanks.