From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74838A0C41; Wed, 6 Oct 2021 18:44:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3759140696; Wed, 6 Oct 2021 18:44:54 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id D6DC540685 for ; Wed, 6 Oct 2021 18:44:52 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 77B313200EAD; Wed, 6 Oct 2021 12:44:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 06 Oct 2021 12:44:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= PlLtAjEDREjmhs1rPNPwdycXeTPsK102Wwn9goja+KU=; b=dMNayQVr4z0Y7PQh cmZZ2uWzJxaZQ+Yz8PhxT9jiS7PfyySQ2LXYOyQFJONqigSiXKvnWvzkoLW6tRJJ grBOc6381eM6S8sRD/AmLdqdv+jHFQlz6GTGv6E7RbghSk9Tn4i/FpnmRCr1GKFn 4X+Id54PTd93QH9WT0UStdOqMbDA/V/R1wWqJMKlmPTwXfo2jIn28cuD8YJUw7u0 2NFqMMPT/pckqCSVbDXd2A6d3td+PRiyk6j8zOfc4pOe2FnyKTjSQ3QBYtdi1AiB RpIhYsvMgNajDVSwXgx8GieWN/jG3fUpFibEr1SVELSyH/OGIjyCesND16yLV+Vm avhyxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PlLtAjEDREjmhs1rPNPwdycXeTPsK102Wwn9goja+ KU=; b=Lova31VCxh6p7opcaeYQyBp5wTerwA65FUel+5WGhqRd3NNLgqsuFoq3O qrucxhKXmtXUkE9hcK2v2r5bnopaGVeUV5u2pB7jTsYkK22+Zg40FwAfN5Nv5klS JUpLQTS4F6aUZNDkGcmVu/Y86DwfTfqtO7IvLL/vbq8H6oAoD7IClphOQzttQnQ0 B3t53qA6m+dsPtEK27Zc3fA9WGCf1SEn2YHOS+OE27Kt385HTfQNIqPBSMsqMPYo cNkGkfcV/93bJpBmusIQXqKUMzyR0Gu6GbpLjgQhUVExs80b4Bw8jjT+ZK19lNNJ mI7fEJLK7vMTGZehE7VfPH7IAR8lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeliedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Oct 2021 12:44:49 -0400 (EDT) From: Thomas Monjalon To: "Morrissey, Sean" , Bruce Richardson Cc: dev@dpdk.org, Conor Fogarty , david.marchand@redhat.com Date: Wed, 06 Oct 2021 18:44:47 +0200 Message-ID: <1917283.qDRZx0JjB0@thomas> In-Reply-To: References: <20211004101058.2396458-1-sean.morrissey@intel.com> <2ed06f29-fabd-c8b6-0157-11d72451c045@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/10/2021 18:28, Bruce Richardson: > On Wed, Oct 06, 2021 at 04:19:46PM +0100, Morrissey, Sean wrote: > > > > On 06/10/2021 14:37, Thomas Monjalon wrote: > > > 04/10/2021 12:10, Sean Morrissey: > > > > This script can be used for removing headers flagged for removal by the > > > > include-what-you-use (IWYU) tool. The script has the ability to remove > > > > headers from specified sub-directories or dpdk as a whole. > > > My fear is that it could flag an include as useless, > > > while it is required for a different system (BSD, Windows). > > > > > > > > Hi Thomas, > > > > Stephen raised a similar concern. Please see Bruce's reply here: https://patches.dpdk.org/project/dpdk/cover/20211004101058.2396458-1-sean.morrissey@intel.com/ > > > One additional data point. Checking the output of a run I did of IWYU a > month or two ago, shows 2254 header includes that IWYU thinks should be > removed. With that sort of scale of an issue, I think automation will be > needed. I agree to integrate this tool, but we must make clear there are false positives. Please add a warning when running it.