From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C5B32239
 for <dev@dpdk.org>; Fri, 29 Dec 2017 14:29:38 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6A2A421007;
 Fri, 29 Dec 2017 08:29:38 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Fri, 29 Dec 2017 08:29:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=zs9frsX/IV6KOXLD/IxB4Wfqit
 k6a3HRltAlr7INQxI=; b=b71A1uP+6gbSWQkcJ4q5lCKY0KryL5K8ncn6F4BPHK
 zqWuHXjaJeVxNiVhPj60aCpYKjPLJCSNrUK9DXcHG9kDtgEP/MigFv8gTADYIFC9
 a8dHVBMkjE1l11/PLQkIw2Ewf39MzR1u5hDP92EhpIyjnRkIXkmfpZjwscIKLpxG
 E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zs9frs
 X/IV6KOXLD/IxB4Wfqitk6a3HRltAlr7INQxI=; b=f0GMdXRSwEBCFZPb25Otb0
 qAdPKvUGWOLaCuUMBMddQGfFrmEUqObU21IhhvH2vLUZ7BaRjHYvsbzctU4doHN8
 O51V2/BfjQISLYdddN2KZ8PbjAwWV5ifxzR7XfyAkcp/u8TB4QB9lyyNyfB7E3MO
 ZDV/IB8YkKnCW1lCGNPOjB5G+fFJelsLmLt5xIUVTPuAIbwyUh+os5UajxEqR9NK
 d4LQftchuryujOVEvb+I9+1gEKnxqi/c4wTSGbII4wztAjLgqOVTnnaYO53e2udL
 S0P0ksyHAmdAqFk/JQhez6Ee4PlRu3cakgutO/6Ba3c7wofNVvymLPdypLfhH0dw
 ==
X-ME-Sender: <xms:QkNGWkUOBw9glvjAZk3fbvJ5Hfc8Ata2HZX3Tz6UvQDowmLgsHNCew>
Received: from xps.localnet (240.16.136.77.rev.sfr.net [77.136.16.240])
 by mail.messagingengine.com (Postfix) with ESMTPA id 022AD244C7;
 Fri, 29 Dec 2017 08:29:38 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bernard.iremonger@intel.com, ferruh.yigit@intel.com
Date: Fri, 29 Dec 2017 14:29:21 +0100
Message-ID: <19178544.sblBIO1mag@xps>
In-Reply-To: <20171228221013.1141-1-thomas@monjalon.net>
References: <53c8669c-79b9-2f6d-4008-7679aa2cf377@intel.com>
 <20171228221013.1141-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: remove useless parameter in
	callback process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 13:29:39 -0000

28/12/2017 23:10, Thomas Monjalon:
> The pointer to the user parameter of the callback registration is
> automatically pass to the callback function.
> There is no point to allow changing this user parameter by a caller.
> That's why this parameter is always set to NULL by PMDs and set only
> in ethdev layer before calling the callback function.
> 
> The history is that the user parameter was initially used
> by the callback implementation to pass some information
> between the application and the driver:
> 	c1ceaf3ad056 ("ethdev: add an argument to internal callback function")
> Then a new parameter has been added to leave the user parameter
> to its standard usage of context given at registration:
> 	d6af1a13d7a1 ("ethdev: add return values to callback process API")
> 
> The NULL parameter in the internal callback processing function
> is now removed. It makes clear that the callback parameter is user
> managed and opaque from a DPDK point of view.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v2: add history explanation

This patch is now part of the patchset v3 for new ethdev notifications.