From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B8C9F1B24D for ; Mon, 2 Oct 2017 17:39:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1A75A2296B; Mon, 2 Oct 2017 11:39:49 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 02 Oct 2017 11:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=6HDaP6zoIL2HX9V 0gKfabIyogNa5ONWXa5zPpXxK6Rc=; b=eEISftsp3ya7/1VJD7Nmj/yjFsF3YXt u4RgES3Br00cIEgQE8QAZ6KcuOqr+rqzrXMtBUIVQ71wYEjZkHC80YFQF7vb9AZ8 MI+7JDaeN3l0wjHXKfD+xcpT1umb6oduigprH4qAAhKiOz4d8MepZaYwfCsHXF71 3a5MGSSO5zPM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=6HDaP6zoIL2HX9V0gKfabIyogNa5ONWXa5zPpXxK6Rc=; b=h98Ukm2I tjny4fvPuNa11mGsc3AQLbOA6mDZMoZzyXBHWM5hTt4dNRi4lwNl4/ajMNhnU9GA am6UYo0IkSRc8l68X6XlK3vWVwNpg5JG0a0gr0dhxg5YHSN7HZcCLe5xAgKa2Yy/ 8VKaLv02lhWWdwomMNtKjt/+LQPP8lWnS5QDq6pysZdmdhS4aDC20/FATXHhu91R wjwhb5csGcnFJl49MXKUM8rpoE5jAOgYMKD36HLuWC7/Fh4Ff2xgoeg1UsYZzOA4 uLMmF8+m12eKar9tmXXBAekD00/svxeczg65Lc3rSBV3+NyffJvHeZV2LSkIMavv UNKhvjVniD2rcw== X-ME-Sender: X-Sasl-enc: IHZhGZD4vrvZP9xLg5CfNYChI+RvWhTWPDAp9l1bQxel 1506958788 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CA46624772; Mon, 2 Oct 2017 11:39:48 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org Date: Mon, 02 Oct 2017 17:39:47 +0200 Message-ID: <1917865.rASfWJCVJS@xps> In-Reply-To: <1eefa9bb-6f61-f5ba-383f-cfe9ae62862c@intel.com> References: <1506946848-173847-1-git-send-email-david.hunt@intel.com> <1556159.HUIlaTtd6f@xps> <1eefa9bb-6f61-f5ba-383f-cfe9ae62862c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 15:39:49 -0000 02/10/2017 17:06, Hunt, David: > On 2/10/2017 3:55 PM, Thomas Monjalon wrote: >> +DPDK_17.11 { > >> + global: > >> + > >> + rte_power_acpi_turbo_status; > > Is it really the function you want to expose? > > rte_power_turbo_status seems more generic. > > Not really, it was in there for completeness, but users should be able > to keep track of the turbo'd cores, so not really needed. > > > More comments about what is part of the API: > > If you do not want to expose ACPI and VM implementations, > > it should not be part of the rte_* include files. > > I'll address the above comments in the next version. You did not address the comment about what is rte_*.h. If you do not want to expose everything, you should move it to another .h file. Files starting with rte_ are included in doxygen API doc. Only rte_power.h is installed. The installed include, the doxygen doc and the map file should all expose the same API consistently. I think a cleanup is needed.