From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id E60B6FA66 for ; Thu, 9 Feb 2017 17:53:55 +0100 (CET) Received: by mail-wr0-f174.google.com with SMTP id i10so87939445wrb.0 for ; Thu, 09 Feb 2017 08:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Fp9rzyE0CrJ3d2sJN8TEt0EG8ZTCS+4bwoTtmXs+VU=; b=weuk506oM2SYNQdYr6Ew+Z+lUqddGq/xkpEYuHyc0TlS7h0Xev2n4EYgSBesJ9RCn1 sn/PernQAmna6GBcW60CtkI6Drh349lx0+nESrxDOnuaHEOwJ5IfsryRqq+YpJOhQD/b Fz40awfgSAtY3j9Cd5Z5tIepieCw7Y/71w7KN+IyJl5khrFpDEalUQpN1lUeNB5onDM5 NnrYHUhTkvX59bR9BYfpOT+m6nFkqF6wagFAj+3i/hvnw5UEcHx1Fw3ty7X0yBlHjBte XSN96LFC6YXWRnB1ZHD5ilKh/NvVui2ocFSyhYkWRqXyrtXC1r1TQBQ1iG6lpubSMzoS wZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=8Fp9rzyE0CrJ3d2sJN8TEt0EG8ZTCS+4bwoTtmXs+VU=; b=ABsxYl286yOzm2Ux0YaIjM3SQtzApebLDNlcSeANy+ZWufuiFmonuv4SVL2RFTXYAH S8zP+4TUBUlmTyVJYkCC827+q09x3Hc2hcWP7tVxtlTQ+hTsl3TjVDXlNpvwcMNHRkbq SlTehKLcnRJPLNCbRvIoqgA1t7XsEL9nV2Iuqluagxj0KP10SlO53tq6N9AJQM+duNH/ 7aDqnd0GvgvljCK2C08bc1oAs9WdU2rn1lijoT30Et9weA36sBUQghR7qIsg3F3Z1/nC G81bBowjYJA/fphFdGT/t9vi7HQCmzO+bQI6JZPD1vhO3rXASbtzQ0lzIvm5EKx8e/eq tEYA== X-Gm-Message-State: AMke39l/o+U8MKukR92v1znCNHF1TgJMpC05JJqKAr8ys4DQfnrKtTcAawvbcayCLHnHLWsD X-Received: by 10.223.164.150 with SMTP id g22mr3792613wrb.148.1486659235686; Thu, 09 Feb 2017 08:53:55 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id k195sm9730728wmd.7.2017.02.09.08.53.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 08:53:55 -0800 (PST) From: Thomas Monjalon To: Nikhil Rao , bruce.richardson@intel.com, Konstantin Ananyev Cc: dev@dpdk.org Date: Thu, 09 Feb 2017 17:53:54 +0100 Message-ID: <1919498.PKpEFfz702@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2431986.cxPJYuksjQ@xps13> References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com> <4122748.D2hJ4kS1ho@xps13> <2431986.cxPJYuksjQ@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 16:53:56 -0000 2016-11-06 22:09, Thomas Monjalon: > 2016-09-29 18:34, Thomas Monjalon: > > 2016-09-30 02:54, Nikhil Rao: > > > The original code used movl instead of xchgl, this caused > > > rte_atomic64_cmpset to use ebx as the lower dword of the source > > > to cmpxchg8b instead of the lower dword of function argument "src". > > > > Could you please start the explanation with a statement of > > what is wrong from an user point of view? > > It could help to understand how severe it is. > > Please, we need a clear explanation of the bug, and an acknowledgement. Should we close this bug?