From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B59FFA00C2; Wed, 30 Nov 2022 11:44:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F4A240151; Wed, 30 Nov 2022 11:44:12 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) by mails.dpdk.org (Postfix) with ESMTP id 103D54014F; Wed, 30 Nov 2022 11:44:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjrfPXna83wN98gKQ8XLZRWl0NEGs+lu07GlxkgLvH4Z1xmVUV+9oaw+nq3zAboeXZrLdcz1XIIFWK/I17RfcqqZkdCfxc7/35VcjXGlfzBGNln5Pf1WrXiliOIHJqbRCSOiZYEWazTI6VbI8b0YjCdRQDnF4eLghB48J6/BBlqXL5wIiGzxEGlKmkhvuw86CiQW3Wgp4evSiKm9Bq8dUuMmShdtgBfuG3qzDZ55v0A8WjyElitHRBORPcB2OUwUVJ7myjCtvT5oEbO+8pcir61kQsS8bX7jTYRSd22aEcbmR4gM30nXZen0XbsA9Feq0mLyYFsfAMUF4R74nt1uQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7mDrya2RHnufav3ra63WHzJFpjA5253BT8WR19sfva8=; b=GdFyjGriz1SeRwPVl2AbIF9nJpR8js2fe8R11BKiOW7kx+lpDsGgIuE7N0+JdOzWvLyH3SGKDvWWpb4UTkTvdEuu4+HBbwDZN6ZWiavT7AjZlLVAVZnnLVN/DzecTjKhJXBNOF6ZP/cYwE6IvpR7XLOzbDvspY5dPoRuBobQvkXslp+mTO5K+p2oCQ3QKWyu1v9g22Uv7dHLNjWMmQICxfPOwsU+vDOnucmXerRMkJkg2Yp5i4Qow8QdGA04aaj49uvvybNVE2iC3x2A2nADX4HkV2YPdX3A5FqSEPYlx7HWER0cwLKepoVRXCO27LpomE1hGNpVe4R+YZRv4QdkCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7mDrya2RHnufav3ra63WHzJFpjA5253BT8WR19sfva8=; b=BGks2ZMh8+MkXUmVYbx4g//TpFaJvfCkaPeYf2skPT+nbE6XpB8rMkkZGQhf0WtG+jZi6C/KJvZd933Np2rP8mGrEkS/OQ5lEIJ5Y6S5A8lx1ID93Hy9XwPRLJY46aLDmlKFUEmwYJ7j2OXSOi7i3MfXjXhliBbP26DLdMJSxak= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6037.namprd12.prod.outlook.com (2603:10b6:8:b0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 10:44:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 10:44:09 +0000 Message-ID: <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> Date: Wed, 30 Nov 2022 10:44:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] drivers: fix symbol exports when map is omitted Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Luca Boccassi , Thomas Monjalon , Bruce Richardson , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= References: <20221129140032.35940-1-david.marchand@redhat.com> <20221130100204.214181-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20221130100204.214181-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: df4ee595-689b-4362-a7dc-08dad2bfcedf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MaQUPuDX51KOLk7A3oGS9gt4rAyY9DW5SPLrYbcx3/SLyP0w2Tc5mB1rlV66sNT7+94JChDXVMY6nsL6HnxM//OeDE/SjwDLIzpJUxNgcJVfgR/BN4oTScSI7pdjcc5g5GWH3pRfFdS+TmTpcJCUOwvwSOj8c+O0BMPFPSSQmC87HEy0GDN8KFNMOtNpMn1N4EUpmNP73YGzAoRqDufJZlcl0wMjeyx2f6YPl7Qd/aE63+j/6ctpBv9RoZr1AScgL/GUtTpsTcMJYh4ifbp02OY+a2z6zaW9BsCBxuazRb0yxs8Z+zxB4YGb9SK8cXH118ciU+pYrhrVR2nnmjKh8gA+zphjIENjTe2BLjtmYO0mnk6wDg/0oPoqNKfrHtoHY2KrhySaJv9xKmUkhyLC/jbn0nqg1AjMD7LcyNynqe3u1hmb8a3oTnH/TBZg8YtbyH1nkX7mGmHS7nTD8WIIPWS+9lLWJivtQbbZSiDsfxw0pJs/cTdDbs/GEvJfq/VJUDtinkOUt6in8SoCjpW8voo/+F04pdZdy8fgtHMDpmC7mOP0D4eamv8A828HxhwIBeWVjMd5sd6pzwYK3105t6VLagniDSJg1MrQgoYHY60a5CKyOGZC5YoL1Q/aNJn3sw4bID4Xgbcp/+oRwqttbNj/BEFCNAHV54kyUKvnUBeCNk4mi7Mh+0yI4tP6apSdRSMGm87HVIZnLFIVsQMLyOXNAwPEcNYyssCGshWyHtM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199015)(6666004)(83380400001)(86362001)(31696002)(31686004)(6486002)(53546011)(6506007)(45080400002)(478600001)(54906003)(316002)(8936002)(2616005)(41300700001)(6512007)(4744005)(44832011)(36756003)(5660300002)(4326008)(2906002)(38100700002)(26005)(66476007)(186003)(66946007)(8676002)(66556008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N011MGswSUo3NWdOdmlscFNHemVWYThUMUkxb3R5NlA5d01LL29hRG1SZnFO?= =?utf-8?B?dGo4Q3ZPUVZXai9MSXRJWmc1cTZGaGtTM2VYQmRYN1pta21CcnNpbTJPM29S?= =?utf-8?B?elNPZnJpNnNXbTZNY3MyZEhoQXYwK2sybkthc3Q4cThWSWVFbzFPT1NLdmpo?= =?utf-8?B?V01EUHd5U3kxbjFoYUdORTBxUEVTRzNRWW1EbjZjOVpJV3Z1eXdybXFuNDZo?= =?utf-8?B?bmNuR1RnOHBzOWJTWTJvUzVWaU50QWRSQmJMUm1kMTZhR1QxVmFmK3FiNHdw?= =?utf-8?B?cFhKSDM0Tkx3cVl3YXNsY093RzEwZ1B4bHB0WkVEQktZSnErb1pvT0cwdGZ6?= =?utf-8?B?ZFE1dzVGUmNYMC82dHRaUmpuOGU3ekdhUVBDQ2hHWXVvem9oZUtZR1NHWERL?= =?utf-8?B?MEZqamFxaDhqT2p1SUwvbjZWbkxTS3pML2cyclJ5dXNGcjJibExpNTBRdHdL?= =?utf-8?B?QkhoVXQzWWVad2h1djJLM0dkaE1RVHV5M1liN2FESHhIZVJDQndrYlQ2eVBn?= =?utf-8?B?cnpSTVN1U2l6RGUzRHdWN2w1NnZBdHhzMnlsMjBteXVqbkQ1c2VDbDRXZ1R5?= =?utf-8?B?MzVoeXkrdHF1cUdKUmdFK1pzWWdrdzVJL0cwVkFrSkNYalF2UnBMOEs0QldK?= =?utf-8?B?RWtDVFlmVExTWTNOVXZEay96RHFaRTR5eVJSRXlJT05FR1JjYnNrU3FGOGdz?= =?utf-8?B?VmJHcnBSSDJKZmt2My9zV1E1dEhlRmFUMmRUdnU5QytCb3RTM1o0eGpjN0Nj?= =?utf-8?B?ZTVmWTBKakJNMFhRR1Fzcnd5Q2lXL2t0eTlFNmVCb0ZyMm1McnZRaWorTXZo?= =?utf-8?B?Vm82bVkzOU9BRU5ib01INkhRbU5UMFRTL3k2ZlhjVFA4c3ZXUHdzYUNQb0Jr?= =?utf-8?B?OFdSYVFNNmlOckpuZ1Fyc2M3bVNhWG1YelQ3MkZxb0pSdDVMMDVaYTgrUkh0?= =?utf-8?B?Y0lPc2tEYllIRXZENldHZFMvL2kxcFNjbFhJRnFrT2c1N3NPWWlKVUpaRVlK?= =?utf-8?B?dkxoRXUyVXBzWG5iaHdISkNnazZ5cU5XQXVGaDNNN2FvZmR1U3FvYTh5WHRz?= =?utf-8?B?bUVCQ0JMTTRmeWw5enV0UHBEYkM0UTZhT1pOZ3lyWlMwajFFbndTU3dSYVZ4?= =?utf-8?B?K05UUWNKeWRCdWJMbUIrSU1nRjh0Nm1Oc1h1YVpkWUxFdTZUT3grbjc0K3NG?= =?utf-8?B?cDZDaTcvYmQvczB0NlBoZy9FWGR0bkcyQ3hCNEpKaXBSaTA0OVZXd2o2RVli?= =?utf-8?B?YmxaSW4zaUtVYVgyTSszaDNYUUExODdLbUhuQlNic01KMS9xUXpRUzJiQ21H?= =?utf-8?B?NmRiU0xuRGJLMHFlZnpNUnJ1RUhZb3QxYVlrRCtBdFJpYTBaZEVleVFaczBt?= =?utf-8?B?QUJoUFQzNjFibVNXOFRlTjlIWUdEOTU3aDJnMkR0Q2RnV0g1YTV2TzR5SXFU?= =?utf-8?B?UzhhazErV2ZmOFJ2UW1ERTlkZ3BTWGNhbXZ2NEVUT011djVlQmd6R09OdEJ5?= =?utf-8?B?OWNucnRjNnhKTDduQ2dURWVBZGJGd3JIajJORDgxZkdVMk84OGVRaFVBcG5Y?= =?utf-8?B?ZUlVeXE0UHNaOVFWUllpcjJFeEMvUjlraUxvT2FKSXlBVmZ6QjA4M2JLN1RW?= =?utf-8?B?dHQ1b210TXZrN1IrckQyZTE0NHQ0Z0Ivc1JwSFdqM3RoRHlMbmFBN1c1bFRq?= =?utf-8?B?a3ZYK2hnTXlobGpXeExKcmdQNHZSVEp2OXFiTEVOTE9qRkxWTExXTFlxY3dl?= =?utf-8?B?WXBBOEliU3BRQ0ZBeHJ3djFCN2hJNEV5WndiTXBNR0VsclpudjZHUWY5UlFi?= =?utf-8?B?WXRGRENuYmdUWk15Y1oray8waTJZcUxRU1oxdVM2RGlBT3ByY1M3emtIN1h0?= =?utf-8?B?Zys0aUpwZmpSUVhVMzVyeWxqclRUNDhaWC9yWTA4a1ViTzYyTFVheUw4RW1k?= =?utf-8?B?TDVnSUk5bTRMRkltdlhCSmI2OWp1cmJNdHNqdVRBVDZRK3dQTW1SQS9zNklX?= =?utf-8?B?cjF5QXlCT1JHN21DUlpheFc0bkdWL0NseHJrQi8xV3orRFV4c09XUkN4RUdN?= =?utf-8?B?akMwRnViTnpDdmZod1Fpb1lCdVNveXYxME9qZGNocnJWcGhkQlpqbDQrTGVp?= =?utf-8?Q?E0KuvVBCe7FBnO/AY3bhPNss6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: df4ee595-689b-4362-a7dc-08dad2bfcedf X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 10:44:09.3634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rbVIqvIsfJR6Tjg8jdnW7yXpJjVIyxStB2FxAAJsnCb1ZFeoyzsUaVCecElu7Gyq X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6037 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/30/2022 10:02 AM, David Marchand wrote: > ld exports any global symbol by default if no version script is passed. > As a consequence, the incriminated change let any public symbol leak > out of the driver shared libraries. > > Hide again those symbols by providing a default map file which > unexports any global symbol using a local: * catch-all statement. > > The checks are skipped for this default map file as it is intentionnally > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > maps")) and there is nothing else to check in this map. > > While at it, move Windows specific objects where needed for better > readability. > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > Cc: stable@dpdk.org > > Reported-by: Luca Boccassi > Signed-off-by: David Marchand > Tested-by: Ferruh Yigit Tested v2, looks good. 'check-symbol-maps.sh' warning fixed too.