From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 16E3B1B678 for ; Wed, 9 May 2018 21:03:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 82A9B229FE; Wed, 9 May 2018 15:03:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 15:03:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ok9YE5bHrmGGKm1v6imYAZR821 EXrP9PK/xBFfo3mSc=; b=PnMaAPesNp9KD0my5wbSylk7fXT+nc0jLkZ4Lo8c2O yuv9cTeFmz9K0iJUlGttjD7F/NSniFd0hAPAcX8XHrlSDyUlr1O9ivpARnYy1Ys5 hn/kbBnyY+RRv2UPNcovuvcynlA0muSPBGfiQCWU3j9naWk6jdbHVReEMW6auImk g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ok9YE5 bHrmGGKm1v6imYAZR821EXrP9PK/xBFfo3mSc=; b=C6+w9KQtLbXegPv50JT48s 4AEH+UcdBYOnrmDb7VMWjC3cEjzg9l/GlaDAye8s3d0AP2ndg0d48GveK5fb2Bit jr7U1XhRhlDPe4Iogp551TbCkvDK99cGO2KIDo5aRqYHpaXxQmKyxS+HgljwrmJa 4d+G+neIV9zADud5ReJQZ0sXgLoGx5NUL4Gx1TNHC3GIiQ7/Pi5+XxHS9brXEdM7 iM6guuJyuZSTL70HRNJ1pHn2S1eO/VdkWEy55MykXEuGrtzHjtTUsV82RetgJODc eI1AVkspIigH+6/M0v7GlbJw6Y3asAdPXczpuoDtQfJHQRWkSVV2vWb0E4tHaMjg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A40DBE5088; Wed, 9 May 2018 15:03:03 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , "Van Haaren, Harry" , "Burakov, Anatoly" Cc: "dev@dpdk.org" Date: Wed, 09 May 2018 21:03:01 +0200 Message-ID: <1920136.Nh2Sl1zDJV@xps> In-Reply-To: <20180509161142.GA14700@bricha3-MOBL.ger.corp.intel.com> References: <20180509161142.GA14700@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/4] Clean up EAL runtime data paths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 19:03:05 -0000 09/05/2018 18:11, Bruce Richardson: > On Wed, May 09, 2018 at 04:59:39PM +0100, Van Haaren, Harry wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov > > > Sent: Monday, April 30, 2018 1:09 PM > > > To: dev@dpdk.org > > > Cc: Richardson, Bruce ; thomas@monjalon.net > > > Subject: [dpdk-dev] [PATCH v2 0/4] Clean up EAL runtime data paths > > > > > > As has been suggested [1], all DPDK runtime paths should be put > > > into a single place. This patchset accomplishes exactly that. > > > > > > If running as root, all files will be put under /var/run/dpdk/, > > > otherwise they will be put under $XDG_RUNTIME_PATH/dpdk/, or, if > > > that environment variable is not defined, all files will go under > > > /tmp/dpdk/. > > > > > > [1] http://dpdk.org/dev/patchwork/patch/38688/ > > > > > > v2: > > > - Rebase on rc1 > > > > > > Anatoly Burakov (4): > > > eal: remove unused define > > > eal: rename function returning hugepage data path > > > eal: add directory for DPDK runtime data > > > eal: move all runtime data into DPDK runtime dir > > > > > > > > > > No full code review, high level comments: > > > > We have to be careful in changing /var/run/.rte_config, which has always been > > the default DPDK primary application lockfile. This has been used to identify > > if a primary DPDK application is alive (see rte_eal_primary_proc_alive()) and > > possibly the write-lock on this file is checked by other tools/utilities directly > > without any DPDK function call. > > > > Changing the filepath just before a release isn't a good idea - we should treat > > this as an ABI/API break, as the change will break functionality in other projects > > such as CollectD[1], which (by default ;) rely on the defaults. There is a config > > file for CollectD to manually override the location, but this will cause headaches > > from a usability POV. > > > > I'm not opposed to the change - particularly as I gather the new memory subsystem > > causes a number of lockfiles to be created - but we must do our due diligence and > > give other projects fair-warning that this change is coming. > > > > As such, I recommend this patchset in its current form (particularly patches 2,3,4) > > to be deferred past 18.05. > > > > > What about if we keep the .rte_config file in the same place but move the > rest? The number of new files causes quite a bit of clutter. We can then > have a deprecation notice for the move in 18.05 and finish the cleanup in > 18.08. I agree