From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>,
ferruh.yigit@intel.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size
Date: Thu, 30 Mar 2017 02:37:44 +0200 [thread overview]
Message-ID: <1920337.9E3jvcbJyk@xps13> (raw)
In-Reply-To: <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
2017-03-20 16:04, Yongseok Koh:
> In rte_eth_check_reta_mask(), it is required to align the size of the RETA
> table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit,
> this should be removed. The change is also applied to a command of testpmd.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
[...]
> - if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
> - RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
> - RTE_RETA_GROUP_SIZE);
> - return -EINVAL;
> - }
> -
> - num = reta_size / RTE_RETA_GROUP_SIZE;
> + num = (reta_size + RTE_RETA_GROUP_SIZE - 1) / RTE_RETA_GROUP_SIZE;
There is no comment for this constraint neither in the code nor in the
commit: http://dpdk.org/commit/66c594904
So, I guess it can be removed.
If a check is needed, it could be added in the relevant drivers.
Helin, Konstantin, please check for Intel drivers.
Ferruh, please take care of this series.
next prev parent reply other threads:[~2017-03-30 0:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 22:40 [dpdk-dev] [PATCH 0/3] net/mlx5: fix updating RETA Yongseok Koh
2017-03-16 22:40 ` [dpdk-dev] [PATCH 1/3] lib/librte_ether: remove requirement of aligned RETA size Yongseok Koh
2017-03-17 17:19 ` Yongseok Koh
2017-03-16 22:40 ` [dpdk-dev] [PATCH 2/3] net/mlx5: use correct RETA table size Yongseok Koh
2017-03-16 22:40 ` [dpdk-dev] [PATCH 3/3] net/mlx5: rebuild flows on updating RETA Yongseok Koh
2017-03-17 9:11 ` Nélio Laranjeiro
2017-03-17 17:14 ` Yongseok Koh
2017-03-20 7:56 ` Nélio Laranjeiro
2017-03-20 23:04 ` [dpdk-dev] [PATCH v2 0/3] net/mlx5: fix " Yongseok Koh
2017-03-20 23:04 ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size Yongseok Koh
2017-03-30 0:37 ` Thomas Monjalon [this message]
2017-03-31 7:33 ` Zhang, Helin
2017-04-01 7:28 ` Lu, Wenzhuo
2017-04-03 10:02 ` Ferruh Yigit
2017-03-20 23:04 ` [dpdk-dev] [PATCH v2 2/3] net/mlx5: use correct RETA table size Yongseok Koh
2017-03-20 23:04 ` [dpdk-dev] [PATCH v2 3/3] net/mlx5: rebuild flows on updating RETA Yongseok Koh
2017-03-21 7:45 ` [dpdk-dev] [PATCH v2 0/3] net/mlx5: fix " Nélio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1920337.9E3jvcbJyk@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).