From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
[209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 3BB1AFC07
for <dev@dpdk.org>; Thu, 30 Mar 2017 02:37:46 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id l43so38745929wre.1
for <dev@dpdk.org>; Wed, 29 Mar 2017 17:37:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=0361i6j98AeFWMf03ocLdIjcwCdBu9Ll0lFmcpCQnQc=;
b=cFmX+abFtUcFNOet1OoQDHES8KCc+TcHmqUlgNrsVoAFYBB0axweuTgG4NwJgni9g/
Rc/bBZIbtOz1jptuYEeaLyWNN+VKhsgASsNsaPI10uGBSQ0zzDr7CeyykClVcBviuagi
Gw3ipcZBtJGmAQmsLSdqzl9hNhJ8GSL3Xvwi9xj0u1wOPWVn7t5cbebGmyM0fT2ob6N8
Eoa0inLwNVOywJedHMWaydXFEGOnYWFj8BEWJmKu2vRoHVh+JFtZKUq7CAxmzyYA//uf
nwVF2kie3i+F9zxYf6ijnp01QT0Yu3U1V1DaECR5kfIJass9mf/EpthiLbX0DI0E7wDC
oa3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=0361i6j98AeFWMf03ocLdIjcwCdBu9Ll0lFmcpCQnQc=;
b=Hf+a+jut8KdW5MUUmL6zLxBpxneNxeOP4Sxi0mTXprRbguInYbI65clsR3+nGyv7jk
zRMrLDDK3Ol9gN7/dMIe/REuVYQ/+M9FyTx6Mz49zYzOR8mGVZlxxag+zO5/5hdcULNh
zoqzpK6zZUNw1UDDkXnMaDdOhI1leBCOeyxRw3IApR1V9Oxt07XOo5bCuhsdb7zlgC4K
uzkr2giUIBqb95Gi8DYL0Z/rjRMjOfxQ0ndOw8Hd0Y7q5Iu0853tI1MnDBgZ6xU/Jfke
H/Wh1fOCUMugbmxOM5dE/XjlLI4eoBsDqjwZDDmHjMpZWNZU1lfBZ7c0xDwGuAF0lU8n
4DAA==
X-Gm-Message-State: AFeK/H0BFHbFAfL6TOWbVbyhcjknoOg7Me4+Eqo5awoW0vbL8pwuRMz+uMW1TitpkoDZXkwD
X-Received: by 10.223.154.199 with SMTP id a65mr2704914wrc.78.1490834266029;
Wed, 29 Mar 2017 17:37:46 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id c8sm603112wrd.57.2017.03.29.17.37.45
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 29 Mar 2017 17:37:45 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>, ferruh.yigit@intel.com,
helin.zhang@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Date: Thu, 30 Mar 2017 02:37:44 +0200
Message-ID: <1920337.9E3jvcbJyk@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
References: <20170316224056.19685-1-yskoh@mellanox.com>
<cover.1490050764.git.yskoh@mellanox.com>
<7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement
of aligned RETA size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 00:37:46 -0000
2017-03-20 16:04, Yongseok Koh:
> In rte_eth_check_reta_mask(), it is required to align the size of the RETA
> table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit,
> this should be removed. The change is also applied to a command of testpmd.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
[...]
> - if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
> - RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
> - RTE_RETA_GROUP_SIZE);
> - return -EINVAL;
> - }
> -
> - num = reta_size / RTE_RETA_GROUP_SIZE;
> + num = (reta_size + RTE_RETA_GROUP_SIZE - 1) / RTE_RETA_GROUP_SIZE;
There is no comment for this constraint neither in the code nor in the
commit: http://dpdk.org/commit/66c594904
So, I guess it can be removed.
If a check is needed, it could be added in the relevant drivers.
Helin, Konstantin, please check for Intel drivers.
Ferruh, please take care of this series.