From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8D91C5F57
 for <dev@dpdk.org>; Mon, 24 Sep 2018 18:59:52 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 3E66921F16;
 Mon, 24 Sep 2018 12:59:52 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 24 Sep 2018 12:59:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=glgEpHAMMB4IXW+aU9PQJpYsHE
 enM80uPu2SKBSJ8Ts=; b=i7PTAmEQHCQTXrBJF7ys4bz1/L+GbQrJPJY/1UDHUS
 vvO6Q5vooTJjGeg+7UbJ3+uJTz+QlZKyVqtAO8Mk1UpGPq1l8BDP1gOe2C8l387g
 hzvC03THTYYflefQzMOWMnGfCQiXGnQ+S7ty+FbSX0fYMw6cGWvdB/24cIbuQeX1
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=glgEpH
 AMMB4IXW+aU9PQJpYsHEenM80uPu2SKBSJ8Ts=; b=avCwCpXB4YTfrIl0T/O9wX
 NfvzAiQghgZpJUVDtOCdRCQDkdVed1mwtWbvVqkhdXjsgC01HjgSyLCtk0q7CnoU
 vrUoUIFRRQJwxPUqhgF7aTdtWP3jAUTAJjLweU5al4lkCBKRhZwXcGR35ufQaXkn
 Pbrg7lnhMnGEPeDAANVsAeg/scyGOn4XUPIUaCE02qAzOXf5qNeEn1IPUYaxl5um
 pHELOULIzpIM89nZnxwyIZvVSgheOHU6AXALbQNuoESMItxNfrElNmSqQesTvBIi
 C49yv2fEE+yHI0m3jhmVFguqcTs0o56BTxDp262rzYYNhVr6jjWbZyLfbMxMdjlA
 ==
X-ME-Proxy: <xmx:BxipW0VhfKBa2EXwYe8k2auDjP9TuSSQScAjsrm7KisR6Ez_aw44bA>
 <xmx:BxipWys6xvjks1YUiS3AKHl-W8hEDR1BnOTGluSJ7WJuUqXYfzVPUg>
 <xmx:BxipW9bvnwBvJba6rbqFyuIarRmbh0jjqvXYOAfJsZvgvHrJUW9Tbg>
 <xmx:BxipW3dtIKrIMBjv7ZslN-XdGp9uzx_LVNek8fNGnpQte5xZ60iDuw>
 <xmx:BxipW-Cp96Dul6_ml2c36ye6MYEYTw3X3OC226WvNXbw0MBKO6zVPA>
 <xmx:CBipW_5SKEwx_4ntX_o1qmvcNkxfIfPqJ4ZMQgwnmUr3EWBO27V4kA>
X-ME-Sender: <xms:BxipW5xB2seKPurJFNUDI2B0fACdsZw8qwJEd7TGFBnHUPhy4xZqNA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 0B71D102E5;
 Mon, 24 Sep 2018 12:59:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil <harish.patil@cavium.com>,
 Shahed Shaikh <shahed.shaikh@cavium.com>, Yong Wang <yongwang@vmware.com>,
 dev@dpdk.org
Date: Mon, 24 Sep 2018 18:59:48 +0200
Message-ID: <1920676.XclAJlGjTg@xps>
In-Reply-To: <e6f6c647-a28c-a294-ec56-ad6cad7dbaec@intel.com>
References: <20180920001853.23454-1-thomas@monjalon.net>
 <e6f6c647-a28c-a294-ec56-ad6cad7dbaec@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2018 16:59:52 -0000

24/09/2018 17:06, Ferruh Yigit:
> On 9/20/2018 1:18 AM, Thomas Monjalon wrote:
> > -#define false                         FALSE
> > -#define true                          TRUE
> 
> TRUE and FALSE also defined in this patch, can we remove them too?

I don't see the need to remove TRUE and FALSE.
The base drivers use them on other platforms, and it is convenient to not
change the base drivers.

[...]
> >  static int
> >  ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
> > -		   int *link_up, int wait_to_complete)
> > +		   bool *link_up, int wait_to_complete)
> 
> Also need to change "wait_to_complete" to bool because below changes start
> sending bool type to this function.

[...]
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> >  		struct ixgbe_rx_entry *next_rxe = NULL;
> >  		struct rte_mbuf *first_seg;
> >  		struct rte_mbuf *rxm;
> > -		struct rte_mbuf *nmb;
> > +		struct rte_mbuf *nmb = NULL;
> 
> This change is unrelated. Can we separate this one?

Yes it looks unrelated but it becomes necessary when including stdbool.h.
I don't know the root cause, but yes, it may deserve a separate commit.
Maybe an ixgbe maintainer can take care of it?