From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 517C341E38; Thu, 9 Mar 2023 08:29:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC79040ED7; Thu, 9 Mar 2023 08:29:44 +0100 (CET) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by mails.dpdk.org (Postfix) with ESMTP id 69663400D7 for ; Thu, 9 Mar 2023 08:29:43 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id BA5672B06889; Thu, 9 Mar 2023 02:29:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 09 Mar 2023 02:29:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678346978; x=1678354178; bh=onJTQwBhQMfKbEf2lo/Wx3K3oOJ9NE6EBFo 2Kq46LtY=; b=QfYtwtgcM+utB6wJb6e45t8MUuqEgWn9xf0T9EgOkBKd4D6WxJQ w8HGTnKyL7eoifoxrBy0C6ebr778tAooY9g56ZAdKtMFjAAR+A9gs0VhB+jFAYbR II+CN8FsSqk7vUSAK3zQA78DSIALfd8VatXqF7LPRxzGhpLHxxKofeZLTHwdGUKT ix5TpWEEOkwWu+OTWSb2GaKz0kpGiInD6n7uY90kS2i1aNAxvUI0xOAWWHlnYVC5 KQ/1fNTtrOW5FSWl8DB4msHuitR4N0q9Uta9JXeK+CWLMa6DlV09UCoYpqNofoT8 AcvT0TMhdtfyFAUPkDDlJ9uDt1J29dJDloQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678346978; x=1678354178; bh=onJTQwBhQMfKbEf2lo/Wx3K3oOJ9NE6EBFo 2Kq46LtY=; b=rc0toYK2w5FzYQmBiqJa9CvJGBjjkII1idiHBeI4e4Wgdo193aj jgfd03u8N1P2lETiO40mjZsstBzc940K4D+VRHp8I6RUn00/tpLm6wtvaauG9HFr 1w8NVzAQLfIkjtSs+S0EMXUReLWvUWKFYRHfIRkyhZdbJd28pjmc2TuZMreZQ6k2 x1AV9/lET20moXd6/0MDCHdbzUtluSU2BSyFC4ZDQM49dMouLZeb3V6r87MLh99O COJLFSZIaMCQ9wZPermxVARL8915Qs5NP6qGhljdIHlYVJ/UKnRntNoN0Le3w7xT OEyRIaXd0lx8FP2bbx5DdXxKq87Iz5CKzrg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduhedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Mar 2023 02:29:32 -0500 (EST) From: Thomas Monjalon To: fengchengwen Cc: dev@dpdk.org, David Marchand , Bruce Richardson , Qi Zhang , Morten =?ISO-8859-1?Q?Br=F8rup?= , Shijith Thotton , Olivier Matz , Ruifeng Wang , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jingjing Wu , Beilei Xing , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Kai Ji , Pablo de Lara , Radha Mohan Chintakuntla , Veerasenareddy Burru , Kevin Laatz , Pavan Nikhilesh , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Liang Ma , Peter Mccarthy , Jerin Jacob , Harry van Haaren , "Artem V. Andreev" , Andrew Rybchenko , Ashwin Sekhar T K , "John W. Linville" , Ciara Loftus , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Dongdong Liu , Yisen Zhuang , Konstantin Ananyev , Qiming Yang , Jakub Grajciar , Tetsuya Mukawa , Jakub Palider , Tomasz Duszynski , Sachin Saxena , Hemant Agrawal Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf Date: Thu, 09 Mar 2023 08:29:30 +0100 Message-ID: <1921837.PYKUYFuaPT@thomas> In-Reply-To: <5a0d4a65-d0d4-ed81-9f44-35ef9fd29d48@huawei.com> References: <20230219115529.3260580-1-thomas@monjalon.net> <20230306161328.3802696-2-thomas@monjalon.net> <5a0d4a65-d0d4-ed81-9f44-35ef9fd29d48@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/03/2023 02:43, fengchengwen: > On 2023/3/7 0:13, Thomas Monjalon wrote: > > --- a/doc/guides/rel_notes/release_22_11.rst > > +++ b/doc/guides/rel_notes/release_22_11.rst > > @@ -504,7 +504,7 @@ ABI Changes > > ``rte-worker-`` so that DPDK can accommodate lcores higher than 99. > > > > * mbuf: Replaced ``buf_iova`` field with ``next`` field and added a new field > > - ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_AS_PA`` is 0. > > + ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_IN_MBUF`` is 0. > > Should add to release 23.03 rst. Yes we could add a note in API changes. > The original 22.11 still have RTE_IOVA_AS_PA definition. Yes it was not a good idea to rename in the release notes. > > -if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 > > - build = false > > - reason = 'driver does not support disabling IOVA as PA mode' > > +if not get_option('enable_iova_as_pa') > > subdir_done() > > endif > > Suggest keep original, and replace RTE_IOVA_AS_PA with RTE_IOVA_IN_MBUF: > if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0 > subdir_done() > endif Why testing the C macro in Meson? It looks simpler to check the Meson option in Meson. > Meson build 0.63.0 already support deprecated a option by a new option. > When update to the new meson verion, the drivers' meson.build will not be modified. I don't understand this comment.