DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: fix max supported packet len for virtio driver
@ 2022-11-18  1:26 liyi1
  2022-11-18 10:14 ` Zhang, Fan
  2022-11-19  8:24 ` [PATCH v2] " liyi1
  0 siblings, 2 replies; 5+ messages in thread
From: liyi1 @ 2022-11-18  1:26 UTC (permalink / raw)
  To: dev

From: Yi Li <liyi@chinatelecom.cn>

According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver
currently supported pkt size is 9728.

Signed-off-by: Yi Li <liyi@chinatelecom.cn>
---
 doc/guides/nics/virtio.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index aace780249..c422e7347a 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -43,7 +43,7 @@ Features and Limitations of virtio PMD
 In this release, the virtio PMD provides the basic functionality of packet reception and transmission.
 
 *   It supports merge-able buffers per packet when receiving packets and scattered buffer per packet
-    when transmitting packets. The packet size supported is from 64 to 1518.
+    when transmitting packets. The packet size supported is from 64 to 9728.
 
 *   It supports multicast packets and promiscuous mode.
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc: fix max supported packet len for virtio driver
  2022-11-18  1:26 [PATCH] doc: fix max supported packet len for virtio driver liyi1
@ 2022-11-18 10:14 ` Zhang, Fan
  2022-11-19  8:24 ` [PATCH v2] " liyi1
  1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Fan @ 2022-11-18 10:14 UTC (permalink / raw)
  To: liyi1, dev

Hi Yi,

Please add "Fixes: xxxxx" description to the commit message.

You may find more information in https://core.dpdk.org/contribute/.

Regards,

Fan

On 11/18/2022 1:26 AM, liyi1@chinatelecom.cn wrote:
> From: Yi Li <liyi@chinatelecom.cn>
>
> According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver
> currently supported pkt size is 9728.
>
> Signed-off-by: Yi Li <liyi@chinatelecom.cn>
> ---
>   doc/guides/nics/virtio.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index aace780249..c422e7347a 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -43,7 +43,7 @@ Features and Limitations of virtio PMD
>   In this release, the virtio PMD provides the basic functionality of packet reception and transmission.
>   
>   *   It supports merge-able buffers per packet when receiving packets and scattered buffer per packet
> -    when transmitting packets. The packet size supported is from 64 to 1518.
> +    when transmitting packets. The packet size supported is from 64 to 9728.
>   
>   *   It supports multicast packets and promiscuous mode.
>   

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] doc: fix max supported packet len for virtio driver
  2022-11-18  1:26 [PATCH] doc: fix max supported packet len for virtio driver liyi1
  2022-11-18 10:14 ` Zhang, Fan
@ 2022-11-19  8:24 ` liyi1
  2022-11-22  9:36   ` Maxime Coquelin
  1 sibling, 1 reply; 5+ messages in thread
From: liyi1 @ 2022-11-19  8:24 UTC (permalink / raw)
  To: dev; +Cc: fanzhang.oss

From: Yi Li <liyi1@chinatelecom.cn>

According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver
currently supported pkt size is 9728.

Fixes: fc1f2750a3ec ("doc: programmers guide")

Signed-off-by: Yi Li <liyi1@chinatelecom.cn>
---

v2 change: Add "Fixes:" description in commit message.

 doc/guides/nics/virtio.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index aace780249..c422e7347a 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -43,7 +43,7 @@ Features and Limitations of virtio PMD
 In this release, the virtio PMD provides the basic functionality of packet reception and transmission.
 
 *   It supports merge-able buffers per packet when receiving packets and scattered buffer per packet
-    when transmitting packets. The packet size supported is from 64 to 1518.
+    when transmitting packets. The packet size supported is from 64 to 9728.
 
 *   It supports multicast packets and promiscuous mode.
 
-- 
2.38.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] doc: fix max supported packet len for virtio driver
  2022-11-19  8:24 ` [PATCH v2] " liyi1
@ 2022-11-22  9:36   ` Maxime Coquelin
  2022-11-22 13:12     ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Maxime Coquelin @ 2022-11-22  9:36 UTC (permalink / raw)
  To: liyi1, dev; +Cc: fanzhang.oss



On 11/19/22 09:24, liyi1@chinatelecom.cn wrote:
> From: Yi Li <liyi1@chinatelecom.cn>
> 
> According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver
> currently supported pkt size is 9728.
> 
> Fixes: fc1f2750a3ec ("doc: programmers guide")
> 
> Signed-off-by: Yi Li <liyi1@chinatelecom.cn>
> ---
> 
> v2 change: Add "Fixes:" description in commit message.
> 
>   doc/guides/nics/virtio.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index aace780249..c422e7347a 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -43,7 +43,7 @@ Features and Limitations of virtio PMD
>   In this release, the virtio PMD provides the basic functionality of packet reception and transmission.
>   
>   *   It supports merge-able buffers per packet when receiving packets and scattered buffer per packet
> -    when transmitting packets. The packet size supported is from 64 to 1518.
> +    when transmitting packets. The packet size supported is from 64 to 9728.
>   
>   *   It supports multicast packets and promiscuous mode.
>   

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] doc: fix max supported packet len for virtio driver
  2022-11-22  9:36   ` Maxime Coquelin
@ 2022-11-22 13:12     ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2022-11-22 13:12 UTC (permalink / raw)
  To: liyi1; +Cc: dev, fanzhang.oss, Maxime Coquelin

22/11/2022 10:36, Maxime Coquelin:
> 
> On 11/19/22 09:24, liyi1@chinatelecom.cn wrote:
> > From: Yi Li <liyi1@chinatelecom.cn>
> > 
> > According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver
> > currently supported pkt size is 9728.
> > 
> > Fixes: fc1f2750a3ec ("doc: programmers guide")

+Cc: stable@dpdk.org

> > Signed-off-by: Yi Li <liyi1@chinatelecom.cn>
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-22 13:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18  1:26 [PATCH] doc: fix max supported packet len for virtio driver liyi1
2022-11-18 10:14 ` Zhang, Fan
2022-11-19  8:24 ` [PATCH v2] " liyi1
2022-11-22  9:36   ` Maxime Coquelin
2022-11-22 13:12     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).