From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 1C6738DA6 for ; Wed, 11 Nov 2015 11:15:07 +0100 (CET) Received: by wmww144 with SMTP id w144so37834016wmw.0 for ; Wed, 11 Nov 2015 02:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=3UmDk1TBKSYbHrd7AHOqyIOJdsXpM02dxA3Cud6tU7A=; b=Gft8J2fFiwuBsjpfNebBrEPTHH+/r30UiYOG9vLzPTQs5JjLutEzcQdmLP1CQkIZd9 y1V0uB5Ba0otm7YdpfRZ+x8AcTgS3Edg5jL3G153XlUS9fhh0q58KV8UUGit4Vo5GzeE sn/NSrj/5Dq84xSWQPB6y2bwi5mP3BnDgy3TG26yNpTXCL/WkknJso5v9BNIrED6HnK4 WSSKM8h5OHIT5ohk3f5nCqVpT8N2BFwHLg70XtbA+7couzXOsGJbNCVnTFJBUruh1aNZ X+NPdE4IMZQbI3f0DFXDCCAHfmM5TFaCiqC6nCU84msXyNMfpT7EzGzXZOSPOxOqq8uG 7tAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3UmDk1TBKSYbHrd7AHOqyIOJdsXpM02dxA3Cud6tU7A=; b=YIdUkokbCEEt3W9D0Q957mKqjhbvygpSMDGGibgVpa3pkvpghmZctaYI1Mx/tfDsyU Sz3IrS3dlEa/G1wnys7ZP6ZGl0hMs836rleCwNjN//T1nxKFbtfrfrCWQ4zfPVWYSfk/ Vc3X6wPXP3uqcae2CL2XrSvEEM3+TRYB0ELsZfBs2QCGqu+SZxXqLN4N2QDhRKdmJ95R 5FU955Bntdglm+QTs48g92tmO8WfE6vEBbpjArukcGW3Ffy2oyP5qNoh8Dls1Tl8kwWR u8bpqSR9lBCrS4nbiozRInVE1ONgSgePxTJBo3MP+3J2IV+qcotZe69Zh+Q1eRKPitKE 6uAg== X-Gm-Message-State: ALoCoQnCOieK9BbadRbLfhh4Rd+oN26jBgBRPxCH+elFLIMooBUersDqxPXpqOlkWGtd4PsM+fCc X-Received: by 10.194.78.162 with SMTP id c2mr8961164wjx.112.1447236906960; Wed, 11 Nov 2015 02:15:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id p75sm8771951wmd.22.2015.11.11.02.15.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 02:15:06 -0800 (PST) From: Thomas Monjalon To: Helin Zhang Date: Wed, 11 Nov 2015 11:13:55 +0100 Message-ID: <1922858.TuGxmDPMa1@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447232205-2339-1-git-send-email-helin.zhang@intel.com> References: <1447232205-2339-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of cannot using more than 1 poor for VMDq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 10:15:07 -0000 Comments on the git message: After the word "fix" in the title, the word "issue" is useless. It's better to have a short title, easy to parse in the commit list. What is a poor? Do you mean pool? 2015-11-11 16:56, Helin Zhang: > It fixes the issue of cannot using more than 1 poor for VMDq, > according to the queues left. You forgot to describe the bug. What happens when we use more than 1? > Fixes: 705b57f82054 ("i40e: enlarge the number of supported queues") Thanks for providing the Fixes line. > Signed-off-by: Helin Zhang