From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 0507D5A58 for ; Fri, 17 Jul 2015 00:10:14 +0200 (CEST) Received: by widic2 with SMTP id ic2so26011003wid.0 for ; Thu, 16 Jul 2015 15:10:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/8oUOvdO1XSlBOKTE9W0OUg8fSeLnW+XgU8UJouqQcM=; b=nLd2pNjA71ted8bvX34E8kW3TKNo2WVCfQ6SBaolVrxkpUkJxr0Ipo8/G2YtwTzeKk dwcAHfe5elPlAu4124K2ZCKLSxr+ELXBonIaeivt3BURnuw9e5vXqgopaF+v7ZVDcucQ QZy6zuOiQmOKAhrJijE4tLO/puBJ/OUXwdylnRBAVh3TinbtHm8RlMDXqGjK8a9OYyrt Oron3Ib9sXJerS4EeqNuVhaMEDzWRPhk1NYgZ4sYhLpSXGmw5/6tWseKk+Fktv1pyS11 UdkwRuJ/gpFfKZaAIVvYTQhYbQQ9N2UhAQkK9Q9qaUfIgmm/tglwcT4mzQ8lO02k4WKX C8Bg== X-Gm-Message-State: ALoCoQnxRiSwMePdWQYyLmtQvE8ITfjhG94UEmlME5P9PqX4fBV8titOMwBo8NYUqPhIRJv5rAT6 X-Received: by 10.180.198.44 with SMTP id iz12mr10687428wic.62.1437084613842; Thu, 16 Jul 2015 15:10:13 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id ho10sm15186999wjb.39.2015.07.16.15.10.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 15:10:12 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Fri, 17 Jul 2015 00:09:01 +0200 Message-ID: <1922905.J0eqSKxbIu@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <3483104.M20H0g0coM@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 22:10:14 -0000 2015-07-16 21:55, Wang, Liang-min: > Thomas, > Do you want me to create a separate patch just include the example/l2fwd-ethtool? Yes > Do you also mean besides the identified Makefiles, you see more rework needs to be done, > or I just need to fix Makefile issue? If just Makefile issue, I could try to make another attempt tomorrow? After checking the build there is probably more review to do. Let's take more time to have something clean and maybe more complete in 2.2. This patchset is your first contribution to DPDK and is already a nice achievement. The new API must now be implemented in more drivers to be effective. > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, July 16, 2015 5:48 PM > > To: Wang, Liang-min > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool > > > > 2015-07-16 09:25, Liang-Min Larry Wang: > > > This implementation is designed to provide a familar interface for > > applications that rely on kernel-space driver to support ethtool_op and > > net_device_op for device management. The initial implementation focuses > > on ops that can be implemented through existing netdev APIs. More ops will > > be supported in latter release. > > > > Applied without example which needs more work, thanks