[dpdk-dev] [PATCH] app/test/test_table_acl: fix incorrect IP header

[dpdk-dev] [PATCH] app/test/test_table_acl: fix incorrect IP header

[Fan Zhang]

This patch fixes the incorrect IP header in ACL table test.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 app/test/test_table_acl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index 38e3a8e..2fc5f24 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -45,7 +45,9 @@
  **/
 
 struct ipv4_5tuple {
+	uint8_t  ttl;
 	uint8_t  proto;
+	uint16_t checksum;
 	uint32_t ip_src;
 	uint32_t ip_dst;
 	uint16_t port_src;
-- 
2.5.0

[dpdk-dev] [PATCH] examples/ip_pipeline: fix configuration parser

[Fan Zhang]

Fixes: 377cd98e ("example/ip_pipeline: add link identification")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config_parse.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c
index e39c23e..152889d 100644
--- a/examples/ip_pipeline/config_parse.c
+++ b/examples/ip_pipeline/config_parse.c
@@ -678,6 +678,8 @@ parse_eal(struct app_params *app,
 				p->pci_blacklist[i] =
 					strdup(entry->value);
 				PARSE_ERROR_MALLOC(p->pci_blacklist[i]);
+
+				break;
 			}
 
 			PARSE_ERROR_MESSAGE((i < APP_MAX_LINKS),
@@ -702,6 +704,8 @@ parse_eal(struct app_params *app,
 
 				p->pci_whitelist[i] = strdup(entry->value);
 				PARSE_ERROR_MALLOC(p->pci_whitelist[i]);
+
+				break;
 			}
 
 			PARSE_ERROR_MESSAGE((i < APP_MAX_LINKS),
@@ -720,6 +724,8 @@ parse_eal(struct app_params *app,
 
 				p->vdev[i] = strdup(entry->value);
 				PARSE_ERROR_MALLOC(p->vdev[i]);
+
+				break;
 			}
 
 			PARSE_ERROR_MESSAGE((i < APP_MAX_LINKS),
-- 
2.5.0

Re: [dpdk-dev] [PATCH] app/test/test_table_acl: fix incorrect IP header

[Thomas Monjalon]

2016-03-14 12:22, Fan Zhang:
> This patch fixes the incorrect IP header in ACL table test.

It is not really a header but a 5-tuple.

Please could you elaborate on the issue?

A "Fixes:" reference is missing.

Thanks

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix configuration parser

[Thomas Monjalon]

2016-03-14 12:22, Fan Zhang:
> Fixes: 377cd98e ("example/ip_pipeline: add link identification")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH] app/test/test_table_acl: fix incorrect IP header

[Zhang, Roy Fan]

Hi Thomas,

     Sorry for lack of detailed description in this patch.
     The patch was not actually a fix but just adding the missing field 
in the ipv4 5tuple area.

     I will send different patch with more detailed description on this.

Regards,
Fan

On 16/03/2016 20:30, Thomas Monjalon wrote:
> 2016-03-14 12:22, Fan Zhang:
>> This patch fixes the incorrect IP header in ACL table test.
> It is not really a header but a 5-tuple.
>
> Please could you elaborate on the issue?
>
> A "Fixes:" reference is missing.
>
> Thanks