From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 232356904
 for <dev@dpdk.org>; Fri, 27 Apr 2018 23:33:51 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6467521495;
 Fri, 27 Apr 2018 17:33:50 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 27 Apr 2018 17:33:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Rda7fx88MVBXNDoYi0EunnJPJm
 ZbIAe+SZFPKx5M58E=; b=fhJfn5baWfTVMSsW7e0wT1UP9PeupuglVb7+65aHbl
 O6MN2m43IXcGQIAKq/hcASmjOROFWkVFlUD/Vm5M95REItputbCGIH07gHeqA0Ok
 RvkPFvs/7GS4t5FLJNzMxDn0eBrNDPmtTXP8/bLCSsaZ9d+c3JHuYQ/XghfsIEbV
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Rda7fx
 88MVBXNDoYi0EunnJPJmZbIAe+SZFPKx5M58E=; b=P97fQIoOzDKL00nq0eMgqL
 u0zk152XnJTtLZQIWGjobFzyGxgYyI/1KrMnFoFatq+gQLQSW/Tn1Pk97c48cLdK
 zRp7cD7bQWKt1kFRKXLkxZfTkx0x6P/k0XTrIKBK+wd0K+XKweSucVvBQYFvyare
 LR95r8E3yL49cs0YuGBNRWT7SXyh+5L6/s1LP7+3vTJ9Z7icFfPnZjcNs1s4U6rV
 3WglU6Lth+n3Ay5y2vz3QUaNvnSngTHMl5Ddr4RDA76u85tAnCNBBrZ4P2dS/vSI
 dVlzEWTbcYkBfB9R786W2Dj87kD6Qus/Vqnv7ugEX7w5uwunYwVlxIvsxRnFkzwA
 ==
X-ME-Sender: <xms:PpfjWntJwWooOOvsdNuav4-kCIX-3wznaLkCwMrZUbGyUcKPUHDsaA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id BD6EEE5098;
 Fri, 27 Apr 2018 17:33:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Date: Fri, 27 Apr 2018 23:33:48 +0200
Message-ID: <1925231.7TIUCjMidO@xps>
In-Reply-To: <cover.1524651111.git.anatoly.burakov@intel.com>
References: <cover.1523979264.git.anatoly.burakov@intel.com>
 <cover.1524651111.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 0/3] Coverity fixes for malloc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 21:33:51 -0000

25/04/2018 12:15, Anatoly Burakov:
> This patchset fixes a few Coverity issues in malloc
> introduced by recent DPDK memory hotplug patchset.
> 
> Coverity issues fixed:
> - 272566 - possible null dereference
> - 272574 - use value before verification
> 
> The following coverity issues were not fixed:
> - 272573 - calling memset with size 0
>   - This is intentional, size will not be 0 in malloc debug
> - 272571 - negative return not handled
>   - False positive, proper API usage ensures no negative returns
> - 272590 - negative return not handled
>   - Same as above
> - 272597 - negative return not handled
>   - Same as above
> 
> Also, replace all instaces of snprintf with strlcpy.
> 
> v2:
> - Dropped fixes for 272571, 272590, 272597 as false positives
> 
> Anatoly Burakov (3):
>   malloc: replace snprintf with strlcpy
>   malloc: fix potential out-of-bounds array access
>   malloc: fix potential dereferencing of NULL pointer

Applied, thanks