From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id D14311288 for ; Sun, 18 Jan 2015 23:04:35 +0100 (CET) Received: by mail-wg0-f52.google.com with SMTP id l2so6734964wgh.11 for ; Sun, 18 Jan 2015 14:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Bj2/LjjBfJhkEWbZm2cqtOBWwg+93DHW5gHaENlgIBE=; b=cfkcbGZT1AwCCvBNSJ16HlER1QLMy35xdkHNANP3xwswdBClUTO834xvEveXY9RjZj BHWvhPeI3MVLOzgfTEVqlDdv5JpiYLjJrSeOud2KIl9r9hR7/Vlm40mBel218G3RTHJt YdhoY5EwfDQ8Ylw4N5v1nKcWeyyizAnrsD79SQfqsEdlqAOh1G4LPJPxUu8Q+xWqn4Cj YNXhqgf6NO02xQWu8xiwKgQUTHvdxIAY4oCIu5iW+33ywTnJZSYmaGTfqokAmBht3Tit 9bcC+y9LTOS1cg02EvMGcc9Sgk5NSEPhJiRVGe2kg7mddCgpdXUAW/lx6S/e5czKY3lr gwEQ== X-Gm-Message-State: ALoCoQlav+RYm6o2jz34uOmOFV/oE+oS2LCY5oazDfm19snHFfuSdvqq6jkN3Cd6PR7u7bT+wnVQ X-Received: by 10.194.2.34 with SMTP id 2mr54180052wjr.58.1421618675725; Sun, 18 Jan 2015 14:04:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ni15sm11852716wic.18.2015.01.18.14.04.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jan 2015 14:04:34 -0800 (PST) From: Thomas Monjalon To: Ouyang Changchun Date: Sun, 18 Jan 2015 23:04:12 +0100 Message-ID: <1929814.KFhfguojKP@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421042352-22399-5-git-send-email-changchun.ouyang@intel.com> References: <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-5-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 4/6] ether: Check VMDq RSS mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2015 22:04:36 -0000 2015-01-12 13:59, Ouyang Changchun: > Check mq mode for VMDq RSS, handle it correctly instead of returning an error; > Also remove the limitation of per pool queue number has max value of 1, because > the per pool queue number could be 2 or 4 if it is VMDq RSS mode; > > The number of rxq specified in config will determine the mq mode for VMDq RSS. > > Signed-off-by: Changchun Ouyang I feel that most of this code is Intel-specific and should go in ixgbe or other PMDs if needed. OK to apply this patch which improves the current codebase, but please, start thinking how RSS/VMDQ/DCB features are generic. -- Thomas