From: Thomas Monjalon <thomas@monjalon.net>
To: "Morrissey, Sean" <sean.morrissey@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Laatz, Kevin" <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"
Date: Wed, 24 Jul 2019 23:34:44 +0200 [thread overview]
Message-ID: <1932425.85ze7CrQjK@xps> (raw)
In-Reply-To: <A21CD6D18EB13E4B84881D350AF40D092A65545C@irsmsx105.ger.corp.intel.com>
24/07/2019 18:28, Morrissey, Sean:
>
> Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry"
>
> 24/07/2019 17:20, Sean Morrissey:
> > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba.
> >
> > Reverting this patch as it currently breaks the initialization of
> > telemetry, more investigation is ongoing to fix the issue for the
> > printed error message for unrecognized argument.
> >
> > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
>
> It's very disapointing.
> Did you or the reviewer tested the previous patch?
>
> The reporter of the bug tested this and verified functionality and closed the internal bug.
So the reverted commit is supposed to work?
I won't apply this revert until I fully understand what happens.
next prev parent reply other threads:[~2019-07-24 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 15:20 Sean Morrissey
2019-07-24 15:31 ` Thomas Monjalon
2019-07-24 16:28 ` Morrissey, Sean
2019-07-24 21:34 ` Thomas Monjalon [this message]
2019-07-25 8:38 ` Morrissey, Sean
2019-07-25 8:42 ` David Marchand
2019-07-28 19:55 ` Thomas Monjalon
2019-07-29 8:40 ` David Marchand
2019-07-29 9:22 ` Gaëtan Rivet
2019-07-29 20:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1932425.85ze7CrQjK@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=sean.morrissey@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).