From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 798ED41E21; Thu, 9 Mar 2023 19:42:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1745B40ED7; Thu, 9 Mar 2023 19:42:50 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 6CEE840695 for ; Thu, 9 Mar 2023 19:42:48 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 106145C00DC; Thu, 9 Mar 2023 13:42:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 09 Mar 2023 13:42:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678387368; x=1678473768; bh=ZyRg4lhLC7m5Vgebhr0kmXzdejeRjOKhqAD RyB8QNas=; b=CB+bHl0pDt8YMYzn81D0iif+Ca/Eqn4t4sfJWyaui6jdSh6d5qO OGkkUvS3SR1SFO6GPZLrC9NLINfVzR6CzLEC/WoRckjaTGsCPxdQhu/eOMCObLC1 RGIV1KqpxbbLxhNE60Ajnsi/3i2BbRGR5qARrTytp99AK66WYe7i0TAY8AZfyKxo fmY/bAtChDCN8xFqNfURfDUhseRye1isH/XDWRrcOvL1Gn9PbO1BzlmY5SwSTANZ Uv44qx7opG0H9dl7MdGg/0Nr5Q2BGA9myUuDXKjixiHBVJJ7L0wQTjV9Hb/iEydN rQHOVdB3QMlzXTYhVM2aEH035t7zTN6TntA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678387368; x=1678473768; bh=ZyRg4lhLC7m5Vgebhr0kmXzdejeRjOKhqAD RyB8QNas=; b=RJujBK3trmfiRFqLmeRfJFPlhJ3jmA3pFh2ZINaViv3BqbkHe/8 JIBHZ+/3N0w6YwO/+BCF1f0wJ+73mbkkR4wu9Onv2XcSpVVZqTIB/WyWE1NfrdFK XUyy4TW/mPMM3eAb1eZCetOCFdawRJHxreW7YlJha5wEeDL7aB1xBRrGlRfRjqR1 WtXqU+nAsGWqW1WovKXP8ws9sgoNtn02OnPqqBd+dUuYBw51RtNlGYL7hRzIp9HK axtUOuZSIypiVJrxFH0uRaFyxpxURv8r0oHAYRLb61m1OYTrVOwpZdsM8CoQvfJX 98WhJddgWLHPJbyHKmoET1VXV90nkOfVWGQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Mar 2023 13:42:46 -0500 (EST) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, pshukla@marvell.com Subject: Re: [PATCH v4 04/12] app/mldev: add test case to validate model ops Date: Thu, 09 Mar 2023 19:42:44 +0100 Message-ID: <1932932.yKVeVyVuyW@thomas> In-Reply-To: <20230207154943.18779-5-syalavarthi@marvell.com> References: <20221129070746.20396-1-syalavarthi@marvell.com> <20230207154943.18779-1-syalavarthi@marvell.com> <20230207154943.18779-5-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 16:49, Srikanth Yalavarthi: > --- a/app/test-mldev/ml_options.c > +++ b/app/test-mldev/ml_options.c > @@ -4,6 +4,7 @@ > > #include > #include > +#include It breaks on non-Linux OS of course. include is enough and more portable. I will fix while merging. In general, I think you have too many includes. You could reduce them by using devtools/process-iwyu.py