From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A0EB12B99 for ; Tue, 2 Apr 2019 14:57:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2E76C21D1E; Tue, 2 Apr 2019 08:57:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 08:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=HXufvB5iPTqwMUeRsyrjgpdcLBxxP4SOgqXWvoEd6M4=; b=LhB5N0WZIVMB A8ej765Fk/jkiX2AiY8foIxWl9gRXs5x1heTHlMhhSbd50CeIGAK8hcy6pgbiyGz 4Owb7Euqg3GIe1ntJ9o6VjQFWI3ONfLc7XpvZvzUlbDZ3A+kB/qmBZqpY260s7Sr 70950uvRPDt5rvMKn3KkxkaTY+x3aWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HXufvB5iPTqwMUeRsyrjgpdcLBxxP4SOgqXWvoEd6 M4=; b=P+6ABsG9ComA8njgm53puNKUbON+hD5UR2gMutWdDcVAwPu+YrOUd/eYC +PxIPXj1ncWpnRx51a/xO3OITSaCpjAoogpyeSMNWtyaneXcflzcMUaWLq+jScHA XOvsh/kbEw00b+TYIJXC/DCATQM5aIJXnyvkZPEdQB0AF6bCwyOaz+qh5eSZFxff cuWVBN4pzlyI0ocVeTXqEe3JtZy2eJD4dgP6Kt09YwELQPjiTzMy7MVeKnsGY65V hRAkaTPoRzmBoc6xt5uibDYSnYyWI+5v7leRfo3AI4N1m4dgr/TlmN9zKLWN70Gi YxVg6WbA+4/0oSZzEW3Twu/4Ko5VQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdefleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F41A210392; Tue, 2 Apr 2019 08:57:04 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, anand.rawat@intel.com, ranjit.menon@intel.com, ferruh.yigit@intel.com, david.marchand@redhat.com Date: Tue, 02 Apr 2019 14:57:03 +0200 Message-ID: <1935282.F1JuZfYupj@xps> In-Reply-To: <20171011143352.GA23500@jerin> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <30782747.pV0nTTKWH9@xps> <20171011143352.GA23500@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 12:57:08 -0000 11/10/2017 16:33, Jerin Jacob: > From: Thomas Monjalon > > 07/08/2017 14:04, Jerin Jacob: > > > baremetal execution environments may have a different > > > method to enable RTE_INIT instead of using compiler > > > constructor scheme. Move RTE_INIT* definition under > > > exec-env to support different execution environments. > > > > > > Signed-off-by: Jerin Jacob > > > --- > > > app/test-eventdev/evt_test.h | 2 +- > > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > > > .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ I sent a patch to flatten the hierarchy, removing exec-env. And I'm not sure about the file name rte_eal.h. Please could you move it to lib/librte_eal//eal/include/rte_exec_env.h or another better name? Note that Windows is introducing rte_os.h. PS: I'm not sure about the intent of rte_os.h. Should it be rte_libc.h? > > > lib/librte_eal/common/eal_common_log.c | 2 + > > > lib/librte_eal/common/include/rte_bus.h | 2 + > > > lib/librte_eal/common/include/rte_eal.h | 6 --- > > > lib/librte_eal/common/include/rte_tailq.h | 2 + > > > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > > > .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > > > > I am not a big fan of duplicating code for Linux and BSD. > > > > Maybe we should have different splits and include a common file > > in Linux and BSD? > > OK. This is doable. After some thoughts about Windows port, I think we need to consider a better split. The constructors are the same for Linux, BSD and Windows, isn't it? Is it related to splitting between POSIX libc and others? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D8CCDA0679 for ; Tue, 2 Apr 2019 14:57:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F98D316B; Tue, 2 Apr 2019 14:57:09 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A0EB12B99 for ; Tue, 2 Apr 2019 14:57:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2E76C21D1E; Tue, 2 Apr 2019 08:57:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 08:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=HXufvB5iPTqwMUeRsyrjgpdcLBxxP4SOgqXWvoEd6M4=; b=LhB5N0WZIVMB A8ej765Fk/jkiX2AiY8foIxWl9gRXs5x1heTHlMhhSbd50CeIGAK8hcy6pgbiyGz 4Owb7Euqg3GIe1ntJ9o6VjQFWI3ONfLc7XpvZvzUlbDZ3A+kB/qmBZqpY260s7Sr 70950uvRPDt5rvMKn3KkxkaTY+x3aWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HXufvB5iPTqwMUeRsyrjgpdcLBxxP4SOgqXWvoEd6 M4=; b=P+6ABsG9ComA8njgm53puNKUbON+hD5UR2gMutWdDcVAwPu+YrOUd/eYC +PxIPXj1ncWpnRx51a/xO3OITSaCpjAoogpyeSMNWtyaneXcflzcMUaWLq+jScHA XOvsh/kbEw00b+TYIJXC/DCATQM5aIJXnyvkZPEdQB0AF6bCwyOaz+qh5eSZFxff cuWVBN4pzlyI0ocVeTXqEe3JtZy2eJD4dgP6Kt09YwELQPjiTzMy7MVeKnsGY65V hRAkaTPoRzmBoc6xt5uibDYSnYyWI+5v7leRfo3AI4N1m4dgr/TlmN9zKLWN70Gi YxVg6WbA+4/0oSZzEW3Twu/4Ko5VQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdefleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F41A210392; Tue, 2 Apr 2019 08:57:04 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, anand.rawat@intel.com, ranjit.menon@intel.com, ferruh.yigit@intel.com, david.marchand@redhat.com Date: Tue, 02 Apr 2019 14:57:03 +0200 Message-ID: <1935282.F1JuZfYupj@xps> In-Reply-To: <20171011143352.GA23500@jerin> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <30782747.pV0nTTKWH9@xps> <20171011143352.GA23500@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402125703.Wm51l72rwMDCBHCGUlofS7FxmDEa-MQRhZNIsT6JO4k@z> 11/10/2017 16:33, Jerin Jacob: > From: Thomas Monjalon > > 07/08/2017 14:04, Jerin Jacob: > > > baremetal execution environments may have a different > > > method to enable RTE_INIT instead of using compiler > > > constructor scheme. Move RTE_INIT* definition under > > > exec-env to support different execution environments. > > > > > > Signed-off-by: Jerin Jacob > > > --- > > > app/test-eventdev/evt_test.h | 2 +- > > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > > > .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ I sent a patch to flatten the hierarchy, removing exec-env. And I'm not sure about the file name rte_eal.h. Please could you move it to lib/librte_eal//eal/include/rte_exec_env.h or another better name? Note that Windows is introducing rte_os.h. PS: I'm not sure about the intent of rte_os.h. Should it be rte_libc.h? > > > lib/librte_eal/common/eal_common_log.c | 2 + > > > lib/librte_eal/common/include/rte_bus.h | 2 + > > > lib/librte_eal/common/include/rte_eal.h | 6 --- > > > lib/librte_eal/common/include/rte_tailq.h | 2 + > > > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > > > .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++++++++++ > > > > I am not a big fan of duplicating code for Linux and BSD. > > > > Maybe we should have different splits and include a common file > > in Linux and BSD? > > OK. This is doable. After some thoughts about Windows port, I think we need to consider a better split. The constructors are the same for Linux, BSD and Windows, isn't it? Is it related to splitting between POSIX libc and others?