[dpdk-dev] cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)

[dpdk-dev] cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)

[Jan Viktorin]

Hi, my testing build for ARMv7 has failed during the last night with
the following output:

...
  AR librte_pmd_octeontx_ssovf.a
  SYMLINK-FILE include/rte_pmd_octeontx_ssovf.h
  INSTALL-LIB librte_pmd_octeontx_ssovf.a
== Build app
== Build app/test-pmd
  CC testpmd.o
  CC parameters.o
  CC cmdline.o
/var/lib/jenkins/jobs/dpdk-armv7/workspace/app/test-pmd/cmdline.c:13813:27: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)
  (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
                           ^
make[3]: *** [cmdline.o] Error 1
make[2]: *** [test-pmd] Error 2
make[1]: *** [app] Error 2
make: *** [all] Error 2


I've bisected the source of the problem to the following commit:

commit 4cfe399f65507f30ddc5df63854638f83f385cce (refs/bisect/bad)
Author: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date:   Thu Jun 1 12:07:22 2017 -0500

    net/bnxt: support to set VF rxmode
    
    This patch adds support to configure the VF L2 Rx settings.
    The per VF setting is maintained in bnxt_child_vf_info.l2_rx_mask
    
    Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

 app/test-pmd/cmdline.c                    | 15 ++++++++++++---
 drivers/net/bnxt/bnxt_hwrm.c              | 24 +++++++++++++++++++++---
 drivers/net/bnxt/bnxt_hwrm.h              |  2 ++
 drivers/net/bnxt/bnxt_rxq.c               | 13 ++++++++++---
 drivers/net/bnxt/bnxt_vnic.h              |  5 +++++
 drivers/net/bnxt/rte_pmd_bnxt.c           | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/net/bnxt/rte_pmd_bnxt.h           | 19 +++++++++++++++++++
 drivers/net/bnxt/rte_pmd_bnxt_version.map |  1 +
 8 files changed, 124 insertions(+), 9 deletions(-)

Regards
Jan

-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic

Re: [dpdk-dev] cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)

[Thomas Monjalon]

15/06/2017 09:26, Jan Viktorin:
> Hi, my testing build for ARMv7 has failed during the last night with
> the following output:
> 
> /var/lib/jenkins/jobs/dpdk-armv7/workspace/app/test-pmd/cmdline.c:13813:27: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)
>   (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>                            ^

I'm working on it and another error due to ixgbe bypass.
Thanks for reporting.

[dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

[Thomas Monjalon]

cmd_set_vf_rxmode_parsed() was defined only in the build context
of RTE_LIBRTE_IXGBE_PMD:
app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here

Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")

Reported-by: Jan Viktorin <viktorin@rehivetech.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 7f5373a7e..105c71f39 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -6803,6 +6803,7 @@ cmdline_parse_inst_t cmd_set_vf_traffic = {
 		NULL,
 	},
 };
+#endif /* RTE_LIBRTE_IXGBE_PMD */
 
 /* *** CONFIGURE VF RECEIVE MODE *** */
 struct cmd_set_vf_rxmode {
@@ -6894,7 +6895,6 @@ cmdline_parse_inst_t cmd_set_vf_rxmode = {
 		NULL,
 	},
 };
-#endif
 
 /* *** ADD MAC ADDRESS FILTER FOR A VF OF A PORT *** */
 struct cmd_vf_mac_addr_result {
-- 
2.13.1

Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

[Thomas Monjalon]

15/06/2017 12:17, Thomas Monjalon:
> cmd_set_vf_rxmode_parsed() was defined only in the build context
> of RTE_LIBRTE_IXGBE_PMD:
> app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here
> 
> Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
> 
> Reported-by: Jan Viktorin <viktorin@rehivetech.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied quickly