* [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization
@ 2017-01-24 20:28 Emmanuel Roullit
2017-01-30 9:40 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Emmanuel Roullit @ 2017-01-24 20:28 UTC (permalink / raw)
To: thomas.monjalon; +Cc: dev, stable
Found with clang static analysis:
lib/librte_ether/rte_ethdev.c:2467:22:
warning: Value stored to 'dev' during its initialization is never read
struct rte_eth_dev *dev = &rte_eth_devices[port_id];
^~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port")
Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
lib/librte_ether/rte_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 61f44e218..d7f78c23a 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2364,7 +2364,7 @@ rte_eth_mirror_rule_set(uint8_t port_id,
struct rte_eth_mirror_conf *mirror_conf,
uint8_t rule_id, uint8_t on)
{
- struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+ struct rte_eth_dev *dev;
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
if (mirror_conf->rule_type == 0) {
@@ -2400,7 +2400,7 @@ rte_eth_mirror_rule_set(uint8_t port_id,
int
rte_eth_mirror_rule_reset(uint8_t port_id, uint8_t rule_id)
{
- struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+ struct rte_eth_dev *dev;
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization
2017-01-24 20:28 [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization Emmanuel Roullit
@ 2017-01-30 9:40 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-01-30 9:40 UTC (permalink / raw)
To: Emmanuel Roullit; +Cc: dev
2017-01-24 21:28, Emmanuel Roullit:
> Found with clang static analysis:
> lib/librte_ether/rte_ethdev.c:2467:22:
> warning: Value stored to 'dev' during its initialization is never read
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> ^~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port")
Wrong commit reference.
Fixes: 88ac4396ad29 ("ethdev: add VMDq support")
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-30 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 20:28 [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization Emmanuel Roullit
2017-01-30 9:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).