From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 6BA6C3237 for ; Mon, 30 Jan 2017 10:40:29 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id uo9so3583361wjc.1 for ; Mon, 30 Jan 2017 01:40:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=otj6CXNQtjFAsU/fReAK2dhIQZBB6XNyGGoi4b9nHm8=; b=J2PVo7mTmSAz1u+L9NJrIWYOBRDLO/MsBtVz4THKYvewFZhaI2PkEhZsLEffD60nUH k4LQ5BZzzbVO6mfUtkiwnhGuokjz48qR98DLlrlk6fi42UNczpIpAjUD4uGg7zZD3D5+ WcoUwW+d9D7e/ki0U3RRzs6lkz+9vxz40dsKYwoKhpC4aAHD4623+VxxU0ZLzXZ0DW2Y z8XfpuAT0CuE7CHxRaa3s4/WvwKocEYknG7AOukNH6YB0iGgVBAS4bAkweaI3fFCnpsC WAvavvB2/yX0TAmicdvDHf78+Z3LhRjh+tXLX0LMFKZBag2i38WL08vlzRF6fbZxC4ZY xR6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=otj6CXNQtjFAsU/fReAK2dhIQZBB6XNyGGoi4b9nHm8=; b=dsYkPJO/pDh2clCsi+StCag2inTcuD3c4ZjDB85/knjt81kHIWMLvZFxP2sLqhlM3C XGhO9ni5zINuCwBHcEgxU5qr5EPpeui2iM15X3oth5RaA6QybsWy0uLWEmKPI53s+piq 6YUVQ5nD1+lzTPEO9Db+Tws65pf9MBwCScHbH3nYfhExiFTk6QynVby1G9HwnDGPMS9m 8I8dy1L9m6CZLFBnUOGRpdbCOQcmfh5/hFwOp7diySYOSqeqatCjlhmCrS+iLuwihYYt AyHbgDoLX/mfvj/2cnZybXvt6fRON92MsYd3iRnY961ncOPRBJxxDSlgswx/2iWSmSJY d1yQ== X-Gm-Message-State: AIkVDXJSoC+zSeUegTVNXgfAHvv704jx08npDYVJZMwDw3tzfhv6mouh7UPW4ql27cygxiP0 X-Received: by 10.223.167.71 with SMTP id e7mr17582111wrd.154.1485769229133; Mon, 30 Jan 2017 01:40:29 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y1sm17831690wme.15.2017.01.30.01.40.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 01:40:28 -0800 (PST) From: Thomas Monjalon To: Emmanuel Roullit Cc: dev@dpdk.org Date: Mon, 30 Jan 2017 10:40:27 +0100 Message-ID: <1935826.gg7Xp02aHW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170124202835.1271-1-emmanuel.roullit@gmail.com> References: <20170124202835.1271-1-emmanuel.roullit@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: remove useless pointer initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 09:40:29 -0000 2017-01-24 21:28, Emmanuel Roullit: > Found with clang static analysis: > lib/librte_ether/rte_ethdev.c:2467:22: > warning: Value stored to 'dev' during its initialization is never read > struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > ^~~ ~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port") Wrong commit reference. Fixes: 88ac4396ad29 ("ethdev: add VMDq support") > Signed-off-by: Emmanuel Roullit Applied, thanks