From: Thomas Monjalon <thomas@monjalon.net>
To: "Ori Kam" <orika@nvidia.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Havlík Martin" <xhavli56@stud.fit.vutbr.cz>,
"Jan Viktorin" <viktorin@cesnet.cz>
Cc: dev@dpdk.org, "Min Hu (Connor)" <humin29@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Chas3 <chas3@att.com>, Slava Ovsiienko <viacheslavo@nvidia.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow
Date: Thu, 15 Jul 2021 15:58:59 +0200 [thread overview]
Message-ID: <19363394.Odk5eMyVqo@thomas> (raw)
In-Reply-To: <20210714170019.40bc169a@coaster.localdomain>
14/07/2021 17:00, Jan Viktorin:
> > > On Tue, 13 Jul 2021 12:26:35 +0300
> > > Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> > > > >>> > > This matters for the bonding case as well, doesn't it?.
> > > > >>> > > It is not desirable to accidently omit a packet that was
> > > > >>> > > received by primary ingress logic instead of being
> > > > >>> > > redirected into the dedicated queue.
> > > > >>> > >
> > > > >>> > > Are there any chances that for mlx5 it would be possible
> > > > >>> > > to insert flow rules before calling rte_eth_dev_start?
> > > > >>> > > Anyway, the behaviour should be specified and documented
> > > > >>> > > in DPDK more precisely to avoid such uncertainty in the
> > > > >>> > > future.
> > > > >>> > I agree the documentation should be fixed.
> > > > >>>
> > > > >>> +1
> > > >
> > > > Cc Thomas and Ferruh since ethdev documentation should be
> > > > clarified.
> > > >
> > > > It looks like there is no consensus if the patch is a right
> > > > direction or wrong. For me it looks wrong taking all above
> > > > arguments in to account (mainly necessity to be able to insert
> > > > flows before pushing start button which enables the traffic if HW
> > > > supports it).
> > > >
> > > > So, I'm applying first two patches and hold on this one.
>
> Andrew, I believe that it would be helpful to start some new thread
> otherwise we would get lost here :). It seems that we will have few
> more fixes for the bonding driver. Do you prefer an entirely new
> patchset or v2 of this topic? Or any other advise how to proceed?
This thread is about 3 things:
- bonding issue
- ethdev doc
- mlx5 design
That's too much topics to address in one thread :)
You may restart the discussion with a doc update
if the stop/start requirement is not clear.
next prev parent reply other threads:[~2021-07-15 13:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 9:25 [dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5 Martin Havlik
2021-06-22 9:25 ` [dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message Martin Havlik
2021-07-08 12:33 ` Min Hu (Connor)
2021-07-13 9:26 ` Andrew Rybchenko
2021-06-22 9:25 ` [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value Martin Havlik
2021-07-08 12:43 ` Min Hu (Connor)
2021-07-08 13:20 ` Havlík Martin
2021-07-09 0:09 ` Min Hu (Connor)
2021-07-13 9:26 ` Andrew Rybchenko
2021-06-22 9:25 ` [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow Martin Havlik
2021-06-23 7:04 ` Min Hu (Connor)
2021-06-24 11:57 ` Havlík Martin
2021-07-04 15:18 ` Matan Azrad
2021-07-07 15:54 ` Jan Viktorin
2021-07-11 8:49 ` Ori Kam
2021-07-11 21:45 ` Jan Viktorin
2021-07-12 13:07 ` Ori Kam
2021-07-13 8:18 ` Havlík Martin
2021-07-13 9:26 ` Andrew Rybchenko
2021-07-13 11:06 ` Jan Viktorin
2021-07-13 17:17 ` Ori Kam
2021-07-14 15:00 ` Jan Viktorin
2021-07-15 13:58 ` Thomas Monjalon [this message]
2021-08-24 13:18 ` Ferruh Yigit
2021-08-26 10:15 ` Jan Viktorin
2021-07-04 15:03 ` [dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5 Andrew Rybchenko
2021-09-25 6:15 [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow Havlík Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19363394.Odk5eMyVqo@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=viktorin@cesnet.cz \
--cc=xhavli56@stud.fit.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).