From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEE7BA0A0C; Thu, 15 Jul 2021 15:58:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F4EE4014D; Thu, 15 Jul 2021 15:58:56 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id EB17D40143 for ; Thu, 15 Jul 2021 15:58:54 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 6AA4D58042D; Thu, 15 Jul 2021 09:58:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 15 Jul 2021 09:58:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= wvnXMvq7T/Qz5Ad1GLR66FhMmAOkG0BJ39MJPkAYbzQ=; b=tqAlLMnE9oYmI3dj Q1DJ8gXWgZzEhyVZGIOV+BLxs4K/kl0Aa+IlXpa7sY6CpN3N3iP58MY9AObTvIbO HffbkT+JQcSX6rrM7y47AU6WpK7j1IlmQFfymdXA4bKCc5snqkqjLtZOV7shReLH vNJKJH51xLuL18r38M3GqQKf1GUye4KMCYwgzbY8ehtJWLavNPgwS08H7kZoN+7C kSh66bdOQWb31BTvFUb0YQF1t/LiQx804i9Y4HO57d+LZXReuy/PcLUcoOO9Q3wY 9sDfVMnQaoDG6KZPEDVBtsJ+hr+ueoOJW8PpG/2eQbBXJ5D+14IIXd6Sbx8zengs 9yej5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=wvnXMvq7T/Qz5Ad1GLR66FhMmAOkG0BJ39MJPkAYb zQ=; b=buxhH6g5J5SYm5fUZVDP9u4msrZEo9dKbPQX5RlyB/G4TSJMor8ck/84E yuzvRWQ1o/VqRg7of6ZzboI/7W7P2gy2YskX+DsJ7Zkzaya5mvap+ja18otme2Fa O4Xihq/0LR6XK1u9hNJ+BujjZjBDXHgkJycNUbrLqxwTNb8VDeThs+E3PqSgew2c fLMvhpEbhIiu3C63G8w/LiPp5aDnRvO4GwUaO6q13cBo3q20DIqjaAEycAN2BcNT 5JsZUN/gwzcEZWfF46hhch6G7c91/sDIKnSz9wn9U3888uBC9q0cAtYEcdpFAKNM x5Ed5DZgvnJnhd4jBU6tW4Ff2BkRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Jul 2021 09:58:51 -0400 (EDT) From: Thomas Monjalon To: Ori Kam , Andrew Rybchenko , =?ISO-8859-1?Q?Havl=EDk?= Martin , Jan Viktorin Cc: dev@dpdk.org, "Min Hu (Connor)" , "dev@dpdk.org" , Matan Azrad , Chas3 , Slava Ovsiienko , Ferruh Yigit Date: Thu, 15 Jul 2021 15:58:59 +0200 Message-ID: <19363394.Odk5eMyVqo@thomas> In-Reply-To: <20210714170019.40bc169a@coaster.localdomain> References: <20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz> <20210714170019.40bc169a@coaster.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/07/2021 17:00, Jan Viktorin: > > > On Tue, 13 Jul 2021 12:26:35 +0300 > > > Andrew Rybchenko wrote: > > > > >>> > > This matters for the bonding case as well, doesn't it?. > > > > >>> > > It is not desirable to accidently omit a packet that was > > > > >>> > > received by primary ingress logic instead of being > > > > >>> > > redirected into the dedicated queue. > > > > >>> > > > > > > >>> > > Are there any chances that for mlx5 it would be possible > > > > >>> > > to insert flow rules before calling rte_eth_dev_start? > > > > >>> > > Anyway, the behaviour should be specified and documented > > > > >>> > > in DPDK more precisely to avoid such uncertainty in the > > > > >>> > > future. > > > > >>> > I agree the documentation should be fixed. > > > > >>> > > > > >>> +1 > > > > > > > > Cc Thomas and Ferruh since ethdev documentation should be > > > > clarified. > > > > > > > > It looks like there is no consensus if the patch is a right > > > > direction or wrong. For me it looks wrong taking all above > > > > arguments in to account (mainly necessity to be able to insert > > > > flows before pushing start button which enables the traffic if HW > > > > supports it). > > > > > > > > So, I'm applying first two patches and hold on this one. > > Andrew, I believe that it would be helpful to start some new thread > otherwise we would get lost here :). It seems that we will have few > more fixes for the bonding driver. Do you prefer an entirely new > patchset or v2 of this topic? Or any other advise how to proceed? This thread is about 3 things: - bonding issue - ethdev doc - mlx5 design That's too much topics to address in one thread :) You may restart the discussion with a doc update if the stop/start requirement is not clear.