* [dpdk-dev] [PATCH] net/netvsc: return the correct chimney index
@ 2020-08-02 6:04 longli
2020-08-02 17:28 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: longli @ 2020-08-02 6:04 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger; +Cc: dev, Long Li, stable
From: Long Li <longli@microsoft.com>
The code should look into "slab" to figure out the index returned from
rte_bitmap_scan().
Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors")
Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_rxtx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 86a4c0d74..6b32c2ca7 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -206,11 +206,13 @@ hn_chim_uninit(struct rte_eth_dev *dev)
static uint32_t hn_chim_alloc(struct hn_data *hv)
{
uint32_t index = NVS_CHIM_IDX_INVALID;
- uint64_t slab;
+ uint64_t slab = 0;
rte_spinlock_lock(&hv->chim_lock);
- if (rte_bitmap_scan(hv->chim_bmap, &index, &slab))
+ if (rte_bitmap_scan(hv->chim_bmap, &index, &slab)) {
+ index += rte_bsf64(slab);
rte_bitmap_clear(hv->chim_bmap, index);
+ }
rte_spinlock_unlock(&hv->chim_lock);
return index;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/netvsc: return the correct chimney index
2020-08-02 6:04 [dpdk-dev] [PATCH] net/netvsc: return the correct chimney index longli
@ 2020-08-02 17:28 ` Stephen Hemminger
2020-08-05 16:10 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-08-02 17:28 UTC (permalink / raw)
To: longli
Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, dev, Long Li, stable
On Sat, 1 Aug 2020 23:04:28 -0700
longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> The code should look into "slab" to figure out the index returned from
> rte_bitmap_scan().
>
> Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors")
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/netvsc: return the correct chimney index
2020-08-02 17:28 ` Stephen Hemminger
@ 2020-08-05 16:10 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-08-05 16:10 UTC (permalink / raw)
To: longli, Long Li
Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, dev, stable,
Stephen Hemminger
02/08/2020 19:28, Stephen Hemminger:
> On Sat, 1 Aug 2020 23:04:28 -0700
> longli@linuxonhyperv.com wrote:
>
> > From: Long Li <longli@microsoft.com>
> >
> > The code should look into "slab" to figure out the index returned from
> > rte_bitmap_scan().
> >
> > Fixes: cc02518132 ("net/netvsc: split send buffers from Tx descriptors")
> > Cc: stable@dpdk.org
> > Signed-off-by: Long Li <longli@microsoft.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-05 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 6:04 [dpdk-dev] [PATCH] net/netvsc: return the correct chimney index longli
2020-08-02 17:28 ` Stephen Hemminger
2020-08-05 16:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).