From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A84CA41FCC; Wed, 30 Aug 2023 13:46:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E5314028A; Wed, 30 Aug 2023 13:46:34 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 28F7C40277 for ; Wed, 30 Aug 2023 13:46:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CAC1E5C008E; Wed, 30 Aug 2023 07:46:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Aug 2023 07:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693395985; x=1693482385; bh=IUQ+JA5rYV1f+a3eT0aHocUj6Qu1mHAum0r gFOYPNug=; b=ZOewkTdrZi3EwqOYhQIwTZnUH6dWUTIIYs5II3XibRFz6RYVtpo Xo1PD67XIpwBWHSM4ycI2FCnk9z1tGIds3paZt6XxZT10R/+SKYuvwA+1BmU17fZ ejw7LUgJXQBG5FAP+pfGfpQnTN24f84Rb4OdOKzF7yEfTHwvdeTLW4uFEXphItxa bFZiNoqQrnZEjRUExPzXdSWNZ7n8lAmPOFnjRwSQ6DF5gAAbvPQlG1MihvvQhOdj mZoUljqph8EfqO3F5uuD/bVGnbF8mFArSiJBnKYRsQjFzalZ0aKaGm9ScqeBTPqm 4QEhKq16rWHoN51nnEiDdriEuj31xEe4Syg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693395985; x=1693482385; bh=IUQ+JA5rYV1f+a3eT0aHocUj6Qu1mHAum0r gFOYPNug=; b=f2wc9cSlJgRW1IKsCAtVYEiesYcblvRdZnRfPBe8E7YKQuoolPG RS6NIH7AI8TdU7FzRckLhgIqiA4rML+D2iggdGqtW4Fl5iEjyfyJ7PQXfK0HO/ys /ws+AyAkydPtI0XzrBTNtCDXkOwcESqTW3SJuIfK5u8G4vrqQNKIRelk8m43PIkP BGxT62pX+SLP5Yt+T9AA5aYzHXvYmkd7aanrQ7X1kdOFWEGSlUvKGWH10YgnLJMa NHTGkhh5njlqJBR3UZahu/FAhzxj9xCCjM0AGNOND7zwj2+0Gw9iQj29eruFqu7f eFWw3+X4lWmz7A6/jU1+qM5dgu+MlzxFidQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 07:46:24 -0400 (EDT) From: Thomas Monjalon To: Jie Hai Cc: dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko , liudongdong3@huawei.com, haijie1@huawei.com, orika@nvidia.com, jerinj@marvell.com, ajit.khaparde@broadcom.com Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm Date: Wed, 30 Aug 2023 13:46:23 +0200 Message-ID: <1939253.PYKUYFuaPT@thomas> In-Reply-To: <20230826074607.16771-2-haijie1@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230826074607.16771-1-haijie1@huawei.com> <20230826074607.16771-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: > Currently, rte_eth_rss_conf supports configuring and querying > rss hash functions, rss key and it's length, but not rss hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "func". This represents the RSS algorithms to apply. The > following API is affected: > - rte_eth_dev_configure > - rte_eth_dev_rss_hash_update > - rte_eth_dev_rss_hash_conf_get So far, the RSS algorithm was used only in flow RSS API. > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -123,6 +123,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > + * ethdev: Added "func" field to ``rte_eth_rss_conf`` structure for RSS hash > + algorithm. As written above, it should start at the margin. > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > +#include "rte_flow.h" It is strange to include rte_flow.h here. It would be better to move the enum. > + * The *func* field of the *rss_conf* structure indicates the hash algorithm > + * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DEFAULT allows > + * the PMD to use its best-effort algorithm rather than a specific one. > */ I don't like commenting a field on top of the structure. By the way, the first sentence does not look helpful. RTE_ETH_HASH_FUNCTION_DEFAULT may be explained in the enum. > struct rte_eth_rss_conf { > uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > uint8_t rss_key_len; /**< hash key length in bytes. */ > uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + enum rte_eth_hash_function func; /**< Hash algorithm to apply. */ You can drop "to apply" words. How the algorithms support combinations in rss_hf?