From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: stable@dpdk.org, dev@dpdk.org,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
mukawa@igel.co.jp, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear
Date: Tue, 19 Nov 2019 23:40:21 +0100 [thread overview]
Message-ID: <1939572.QzvFjc1F9H@xps> (raw)
In-Reply-To: <1573548459-6931-1-git-send-email-matan@mellanox.com>
12/11/2019 09:47, Matan Azrad:
> When a rte_device is unplugged, the driver should be detached from the
> device.
Yes
> The PCI detach driver operation wrongly didn't clear the driver from the
> device structure what remain the device in probe state from the EAL
> point of view.
Are you aware of an use case which is broken because of that?
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -247,6 +247,7 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
The git context above is wrong, it should show the function rte_pci_detach_dev.
> /* clear driver structure */
> dev->driver = NULL;
> + dev->device.driver = NULL;
It looks a good fix.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
I am wondering if there could be a risk for any test application
if applied in 19.11-rc3.
I think we should try to get it and revert if a side effect is discovered.
next prev parent reply other threads:[~2019-11-19 22:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:47 [dpdk-dev] " Matan Azrad
2019-11-12 8:47 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching Matan Azrad
2019-11-12 11:20 ` Iremonger, Bernard
2019-11-20 22:52 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-01-23 13:19 ` [dpdk-dev] " Yigit, Ferruh
2020-01-23 14:05 ` Matan Azrad
2020-01-23 14:48 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-01-23 15:29 ` Matan Azrad
2020-01-23 18:14 ` Ferruh Yigit
2020-01-23 19:25 ` Matan Azrad
2020-01-24 16:28 ` Ferruh Yigit
2020-01-25 18:56 ` Matan Azrad
2020-02-03 15:58 ` Ferruh Yigit
2020-02-03 17:10 ` Matan Azrad
2020-02-12 13:49 ` Ferruh Yigit
2020-02-13 12:37 ` Thomas Monjalon
2020-02-13 13:36 ` Thomas Monjalon
2020-02-13 14:00 ` Ferruh Yigit
2019-11-19 22:40 ` Thomas Monjalon [this message]
2019-11-20 9:02 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear Matan Azrad
2019-11-20 9:47 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2019-11-20 13:03 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-20 13:44 ` Matan Azrad
2019-11-20 13:51 ` Thomas Monjalon
2019-11-20 17:22 ` David Marchand
2019-11-20 22:52 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1939572.QzvFjc1F9H@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
--cc=mukawa@igel.co.jp \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).