From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0B6AA052A; Fri, 10 Jul 2020 22:02:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB82A1DE7B; Fri, 10 Jul 2020 22:02:58 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 48D0F1DE2F for ; Fri, 10 Jul 2020 22:02:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id C63A85800F6; Fri, 10 Jul 2020 16:02:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 16:02:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= a/j1XoXm19GV0/fUieRg5Y5Ofk9/DuItrXHnWDlaWlA=; b=KoVfKeRfE7X/g0gF RLcfZKaKTX8tP1bxZR/N/x/QWdeieEvmNI51ZcePvnV8c7ZsWvJe/UXNKuShsrYW ANEbkVYlS/ltdkly9XM6gzHD0xrT6ywNOe7tTXur6A5fXtn2R17SpSo117oy4CVK ov8FzSsHrfba1lP6XNTfrQMubgjsA6fCv/3of4i66GovrsN4RwkfvrDlGtjflDsy NBlK+BmCIGgpQhbcPjFidNikvqBi7+HtjmDFZnzQcodDqfQ2IbnYVUpDQXnEcQvY 0C0ssCuRiqHEM+Ak1eAClfaS9DXak3RkhgAT5MsXP9In6EY5HMme4K3tJeEIrskG O7wVQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=a/j1XoXm19GV0/fUieRg5Y5Ofk9/DuItrXHnWDlaW lA=; b=HWmPgF6sQajdCqb8Q4bXEhFMqDdQ88J1YsPTBtpFcL6RKJ8UpR/EhRjxn oH2zGYNcpuDTIPjkgqERArdSzYIUJFooMD7wiCFFLiEMBVPRFTLKejKu23/KUUEC XZFCGjYneva5ppJ1hnNgCp6J35L6cAH/hAQVdtSXzOch+32RCtVuYGPjCpbcve1d +DaHaa64nTlbZfdI+ZrJeq17ULjFAkG2WqjjV4FjkyjJJ57C0rnm0h3EptPf78rO iqIrLqbj0t9TYvTCq+cJj3Bfx5+jeOf7o38DVQKJVHvpJr+sb4x5KFgqWy55doE2 3lLIoCYOwlU2y0fJF2iXYToabp6iA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B256F30600B4; Fri, 10 Jul 2020 16:02:51 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, grive@u256.net, alvinx.zhang@intel.com, beilei.xing@intel.com, jia.guo@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@mellanox.com Date: Fri, 10 Jul 2020 22:02:50 +0200 Message-ID: <1939625.Z6HycuXOoL@thomas> In-Reply-To: <20200710213155.7db798b7@sovereign> References: <20200710115324.3902559-1-thomas@monjalon.net> <20200710213155.7db798b7@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2020 20:31, Dmitry Kozlyuk: > On Fri, 10 Jul 2020 13:53:24 +0200, Thomas Monjalon wrote: > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/sys/mman.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright 2020 Mellanox Technologies, Ltd > > + */ > > + > > +/* > > + * The syscall mmap does not exist on Windows, > > + * but this error code is used in a badly defined DPDK API for PCI mapping. > > + */ > > +#define MAP_FAILED ((void *) -1) > > I see why we can't help exposing in , but I'm > against adding this stub header. Why not make #include > conditional and define MAP_FAIELD in for Windows? Yes this macro can be in lib/librte_eal/windows/include/rte_os.h I'll do a v2.