From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id B777A590E for ; Wed, 30 Apr 2014 14:24:25 +0200 (CEST) Received: by mail-we0-f169.google.com with SMTP id u56so1613153wes.0 for ; Wed, 30 Apr 2014 05:24:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=S0SwL8Fa68Sj9qL7zl8bkwJiuDSnoCE3PYiJkHPa/DA=; b=CDfMcZqCqkKUhsuin28Z00spNrtjHbaKdFuAOBZRiZjluVp+1URGPUBzBEJ8Ul5sqU S7bdbl++OgNouQGemifN8UerOq3Kk0Nvn7ynv/rNvUp8OvYSdR6NI9MLpl/5JxdPiD4L HOqZUk6HAUr1Ia11PubH3Bvqzjllixcgg/68cBCExxrGbnx1Qkhj8i1fFRVtBpcPoiK/ htcqn5RxiMRhqdWLiqwvmv2ZVRTluvzoSQjBciRYLX+nAZkPujR9MMUOQc3lr2OmWoDV mVZWoIsyZbTUWCMoTqEZluq8hCO2oWqLfOAuujIArZrUoXbcDsmG0Yq8n3ICc3SvgIbT z5yA== X-Gm-Message-State: ALoCoQnYBalqPce4gfmPDNOLoeRLc4GZ5lO+p+/sZ/hRSmjTLTiVKRTBdMQPw8v5/oGIUkPBkyMC X-Received: by 10.194.187.107 with SMTP id fr11mr1680356wjc.70.1398860669575; Wed, 30 Apr 2014 05:24:29 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id h3sm3313444wiz.16.2014.04.30.05.24.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Apr 2014 05:24:28 -0700 (PDT) From: Thomas Monjalon To: Liu Xiaofeng Date: Wed, 30 Apr 2014 14:24:28 +0200 Message-ID: <1940594.10Qg9mfMu6@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.1-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1397569899-18315-1-git-send-email-david.marchand@6wind.com> References: <1397569899-18315-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check socket id validity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2014 12:24:26 -0000 2014-04-15 15:51, David Marchand: > From: Liu Xiaofeng > > Now socket id is from device's numa_node, if it is invalid, just set it to 0 > as default to avoid crash which will be caused by the reference to > port_per_socket[socket_id]. > > Also one warning is displayed to user that port-numa-config and > ring-numa-config parameters should be used along with --numa for NUMA mode. > > A check for NUMA_NO_CONFIG was also missing from init_fwd_stream(). > > Signed-off-by: Liu Xiaofeng Acked-by: Thomas Monjalon Applied for version 1.6.0r2. Thanks -- Thomas