From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C9567A00C5;
Mon, 6 Jul 2020 17:40:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 273361DB0A;
Mon, 6 Jul 2020 17:40:33 +0200 (CEST)
Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com
[66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 8C59C1D733
for <dev@dpdk.org>; Mon, 6 Jul 2020 17:40:32 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailnew.nyi.internal (Postfix) with ESMTP id CE2965802B3;
Mon, 6 Jul 2020 11:40:31 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute7.internal (MEProxy); Mon, 06 Jul 2020 11:40:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
8Jqrb8AEPmu9DIGVRhOn5D5MLR5++TGaxBy590ySImM=; b=Z1I9gHdHEqB1ZH5C
4b3XhW4jwmLi5S5V+QLu4+rqDMfHI5yxpqwGNPrSeWKQxkUvYTzEUHdrw0CC/Cmg
r5CncasokA2/vOsy4pw57XDB/c6KYNZGGR05Di7guWDudQppycGdGJFtgy6uyXkC
TK9QZBzKJmUva/PzxS6kXMEW/Yc2O7+YqI/KcJClkVEdQFYF78cXAnyMDGIwA+EZ
q4ETWdqw66OsysBcsGENJkri2ue0FTy4ogGlPFDJ1W1LQBDXmg7A5tClpJVRn8g/
AV5wUJyaLiA2d0dU0f1cwN2MC5ysydOdZz8Zy2ekarWXlyErMblfLmZVLMYdJsqH
rzdBNQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=8Jqrb8AEPmu9DIGVRhOn5D5MLR5++TGaxBy590ySI
mM=; b=jldb2EG8MeEZLgmy8iJuAR86Z782z2d//NX1hvWmGQEYtgO4/sdR4BIXa
FLwzFgMT1l9qo3KLseXWEUysEYQu5C4f/taVl3RqpyV+6TBKHCJ5Z0yOB5ogsNhl
nw9sr+CkLQB+H+8P6A6KVMtaOjsYxrq9H6LD927KRBx5dREz7SApjCPHHrTg5PU1
6B0YPiU9jf9iRmlJRRzo526hHKJVcoGHIogWwfxVGaxu+NWWUeM10+8GjRBeX/rQ
NY/pPxcKVGRMf/ropd9s7xc+RgvhL2ynFgJooNBRSN5sQLVbaSEPz8HR/ySECU36
X/oo95hDz/vsar5UL8G9cLfgq5p/w==
X-ME-Sender: <xms:7UUDX0qAugio6YmQrjcD82RI7eHDVxIbIvO1-ND85FlZOHmIf-Lb9w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefgdelgecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpeekhfdufeejveekheeuhfeflefhleefuefhueduhfduieevjedttddu
udeltefggeenucffohhmrghinhepghhouggsohhlthdrohhrghdpughpughkrdhorhhgne
cukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecu
rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:7kUDX6o32f4SthN01Rgug4KE4uGtkYF2eaX_A1E1HHejdamwR-8Y6A>
<xmx:7kUDX5PHl179xPpewI5Bmtj4D9Ud53k0Y-n8aA1dkXD2pnykO7Gmpw>
<xmx:7kUDX753VV6cZPmzpPMjXiTr8H866BNtte7eaRuTt3VMW13jFt3GUA>
<xmx:70UDXwEE0D32rCUwNcqgA6nyJA_jnDfUQ00ZhpIrTDIp50BaVzkpZQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 9ABE130653F5;
Mon, 6 Jul 2020 11:40:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <Phil.Yang@arm.com>
Cc: "erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
nd <nd@arm.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Dodji Seketeli <dodji@redhat.com>
Date: Mon, 06 Jul 2020 17:40:27 +0200
Message-ID: <1943904.n5iF1h13R9@thomas>
In-Reply-To: <VE1PR08MB464059BB58F29658224D4A58E9690@VE1PR08MB4640.eurprd08.prod.outlook.com>
References: <1591960798-24024-1-git-send-email-phil.yang@arm.com>
<3726677.YG9GXOvrMZ@thomas>
<VE1PR08MB464059BB58F29658224D4A58E9690@VE1PR08MB4640.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11
atomics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
06/07/2020 17:32, Phil Yang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 02/07/2020 07:26, Phil Yang:
> > > --- a/lib/librte_eventdev/rte_event_timer_adapter.h
> > > +++ b/lib/librte_eventdev/rte_event_timer_adapter.h
> > > @@ -467,7 +467,7 @@ struct rte_event_timer {
> > > * - op: RTE_EVENT_OP_NEW
> > > * - event_type: RTE_EVENT_TYPE_TIMER
> > > */
> > > - volatile enum rte_event_timer_state state;
> > > + enum rte_event_timer_state state;
> > > /**< State of the event timer. */
> >
> > Why do you remove the volatile keyword?
> > It is not explained in the commit log.
> By using the C11 atomic operations, it will generate the same instructions for non-volatile and volatile version.
> Please check the sample code here: https://gcc.godbolt.org/z/8x5rWs
>
> > This change is triggering a warning in the ABI check:
> > http://mails.dpdk.org/archives/test-report/2020-July/140440.html
> > Moving from volatile to non-volatile is probably not an issue.
> > I expect the code generated for the volatile case to work the same
> > in non-volatile case. Do you confirm?
> They generate the same instructions, so either way will work.
> Do I need to revert it to the volatile version?
Either you revert, or you add explanation in the commit log
+ exception in libabigail.abignore