From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 386C42E8F
 for <dev@dpdk.org>; Wed, 26 Mar 2014 23:14:09 +0100 (CET)
Received: by mail-wi0-f169.google.com with SMTP id hm4so5131265wib.0
 for <dev@dpdk.org>; Wed, 26 Mar 2014 15:15:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=M8A2nSyiO4BcgrPVvtcZ0WR3aMuJ5NSZRP1Y+1egj7c=;
 b=kQgwY30nqzXtk5/1ixWcYp0yUhXqEf48fW/tfJl4OLsnQBL574sTQfM5zewXDjokZi
 AUWIutdkxOozllEst56u2BGnVDsF1wSV+bEQ4JKWldcqa4Ot6D8nzXGMTvRxBYIKYOvc
 c0rtGGDGB6if4XpbCaDOXeAtv3ZDb8tDzc3ATtHpiR5xP1ZXSr7XndEBftxl5zoVoEQv
 ovfRiB9U1rgnl/OoOJRCb+1hAkhZx1u2ClvJy1m6ksu2rc6F4+U7VggbdAQLRQndqXXU
 BQLr+L2GVbupdnxe5qwvLGA9XqY4KAIt114+uQrXLXa7uaBATFtHdH3HuCi6F5yPc8tF
 cC+A==
X-Gm-Message-State: ALoCoQmUi/dL1snS9bCyZ2x5AdUcudce7KJvhKJnCrgCJ5VyPW+KtW3e46CVnYS1XVd/rHt5ooYO
X-Received: by 10.180.89.136 with SMTP id bo8mr240548wib.52.1395872142489;
 Wed, 26 Mar 2014 15:15:42 -0700 (PDT)
Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213])
 by mx.google.com with ESMTPSA id
 gn1sm6138165wib.14.2014.03.26.15.15.40 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 26 Mar 2014 15:15:41 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Date: Wed, 26 Mar 2014 23:14:41 +0100
Message-ID: <1944547.AP9M4ybhh5@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.3 (Linux/3.13.6-1-ARCH; KDE/4.12.3; x86_64; ; )
In-Reply-To: <5332FB65.3000708@6wind.com>
References: <1395228982-24858-1-git-send-email-thomas.monjalon@6wind.com>
 <5332FB65.3000708@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix dependencies when modifying config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Mar 2014 22:14:09 -0000

2014-03-26 17:08, Olivier MATZ: 
> On 03/19/2014 12:36 PM, Thomas Monjalon wrote:
> > If .config file is changed and .depdirs was built before,
> > it must be updated.
> > It is now done silently (-s) in checkconfig rule.
> > Now .depdirs is not redone if .config is older.
> > 
> > It has been tested by enabling PMD_PCAP after a default build.
> > KVARGS dependency should appear in .depdirs.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Looks good to me. Just see one comment below.
> 
> >   ..PHONY: depdirs
> 
> It seems there is a typo (..PHONY instead of .PHONY), it could
> be a good occasion to fix it. In my opinion, it can be done in the
> same patch as this typo does not create a real issue.

Applied with the typo fix.

Thanks for the review
-- 
Thomas