[dpdk-dev] [PATCH] mk: fix dependencies when modifying config

[dpdk-dev] [PATCH] mk: fix dependencies when modifying config

[Thomas Monjalon]

If .config file is changed and .depdirs was built before,
it must be updated.
It is now done silently (-s) in checkconfig rule.
Now .depdirs is not redone if .config is older.

It has been tested by enabling PMD_PCAP after a default build.
KVARGS dependency should appear in .depdirs.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.sdkconfig.mk  | 1 +
 mk/rte.sdkdepdirs.mk | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index 3d05ba5..b4e45f2 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -114,6 +114,7 @@ checkconfig:
 	fi
 	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk \
 		headerconfig NODOTCONF=1
+	$(Q)$(MAKE) -s depdirs
 
 .PHONY: FORCE
 FORCE:
diff --git a/mk/rte.sdkdepdirs.mk b/mk/rte.sdkdepdirs.mk
index 03dbdb1..bd3bac4 100644
--- a/mk/rte.sdkdepdirs.mk
+++ b/mk/rte.sdkdepdirs.mk
@@ -39,7 +39,8 @@ endif
 # use a "for" in a shell to process dependencies: we don't want this
 # task to be run in parallel.
 ..PHONY: depdirs
-depdirs:
+depdirs: $(RTE_OUTPUT)/.depdirs
+$(RTE_OUTPUT)/.depdirs: $(RTE_OUTPUT)/.config
 	@rm -f $(RTE_OUTPUT)/.depdirs ; \
 	for d in $(ROOTDIRS-y); do \
 		if [ -f $(RTE_SRCDIR)/$$d/Makefile ]; then \
-- 
1.9.0

Re: [dpdk-dev] [PATCH] mk: fix dependencies when modifying config

[Olivier MATZ]

Hi Thomas,

On 03/19/2014 12:36 PM, Thomas Monjalon wrote:
> If .config file is changed and .depdirs was built before,
> it must be updated.
> It is now done silently (-s) in checkconfig rule.
> Now .depdirs is not redone if .config is older.
>
> It has been tested by enabling PMD_PCAP after a default build.
> KVARGS dependency should appear in .depdirs.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---

Looks good to me. Just see one comment below.

>   # use a "for" in a shell to process dependencies: we don't want this
>   # task to be run in parallel.
>   ..PHONY: depdirs

It seems there is a typo (..PHONY instead of .PHONY), it could
be a good occasion to fix it. In my opinion, it can be done in the
same patch as this typo does not create a real issue.

Regards,
Olivier

Re: [dpdk-dev] [PATCH] mk: fix dependencies when modifying config

[Thomas Monjalon]

2014-03-26 17:08, Olivier MATZ: 
> On 03/19/2014 12:36 PM, Thomas Monjalon wrote:
> > If .config file is changed and .depdirs was built before,
> > it must be updated.
> > It is now done silently (-s) in checkconfig rule.
> > Now .depdirs is not redone if .config is older.
> > 
> > It has been tested by enabling PMD_PCAP after a default build.
> > KVARGS dependency should appear in .depdirs.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Looks good to me. Just see one comment below.
> 
> >   ..PHONY: depdirs
> 
> It seems there is a typo (..PHONY instead of .PHONY), it could
> be a good occasion to fix it. In my opinion, it can be done in the
> same patch as this typo does not create a real issue.

Applied with the typo fix.

Thanks for the review
-- 
Thomas