From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9197DA00C2; Thu, 24 Nov 2022 18:22:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82EE942DD5; Thu, 24 Nov 2022 18:22:00 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 3B4144113C for ; Thu, 24 Nov 2022 18:21:59 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D27025C0121; Thu, 24 Nov 2022 12:21:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 24 Nov 2022 12:21:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669310518; x= 1669396918; bh=Fd/xvNk4Wu3RuWswokffolQ5LqxKK0ZyHdNNpbEZWAc=; b=B TN+iKAq7zbH2FPRRVF4Ntq3fjTYrGzxosETygVV6ewPwr33D2XBTrIzqwyG831fL YnnWTsTVIrMk8DF99djyLZ0oJOjYlTHhdDWyHWqgNti1u34a4thPdWFvHHpcmLsN uUOMLRGLMBsTLeVlpPAkUBQAzChZa46CT/Sn4Cu1f4PWNZjstVxb9E+jcezJ/T9q uqlB3D76iBH4yJH3aR9WWyk5CnHiixX8yOMIHyLXQ7r+cvJi4YhMo/SgvWL3s6rh jixS9sj9jMx3pnvuuGZ0FYlQqVQlaKv/8sTorKMbk3DtpO2dfTZgC1l4qIOjHxDU /BNr2LBK0S4XT7Nbi5whQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669310518; x= 1669396918; bh=Fd/xvNk4Wu3RuWswokffolQ5LqxKK0ZyHdNNpbEZWAc=; b=S BJIZdqML3mbS+w6K0mocSJhBT7OFnftCHk+jpgMCsx5YeUyTSTMXKXmDEOMjxw3/ hpfthGyd4/wRQxqAb0VAqAkYBkhmDIHs0gPCmFfeBDvD3QXt8821Bb+1slljpM8v tDojm+QFsA4XrLwteOulZBPSAvJtPHs289QGG1wvv2Z2qseEH0l2h9EMtRX09Xy7 EVjO1X5K9N4vNl+rHhJw80jkED48OUtLCKzHFai5KIBAWerUtgOlJaWcydqqESjz RV/xKinvE4NAg1z+bPCEiJKUNlvhpTkU2oZaxs1ZNdOpLa4cUE28/IvFgQIMfYdO /PQgRPXkvTENxf1DyTYXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 12:21:57 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , dev@dpdk.org Subject: Re: [PATCH v4] mailmap: add file to DPDK Date: Thu, 24 Nov 2022 18:21:56 +0100 Message-ID: <1944587.8hb0ThOEGa@thomas> In-Reply-To: References: <20201020130722.304989-1-bruce.richardson@intel.com> <2157985.1BCLMh4Saa@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2022 16:08, Bruce Richardson: > On Thu, Nov 24, 2022 at 02:57:17PM +0100, Thomas Monjalon wrote: > > 24/11/2022 14:49, David Marchand: > > > On Thu, Nov 24, 2022 at 2:43 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, Nov 24, 2022 at 01:13:20PM +0100, David Marchand wrote: > > > > > From: Bruce Richardson > > > > > > > > > > Since a number of contributors to DPDK have submitted patches to DPDK > > > > > under more than one email address, we should maintain a mailmap file to > > > > > properly track their commits using "shortlog". > > > > > > > > > > It also helps fix up any mangled names, for example, with > > > > > surname/firstname reversed, or with incorrect capitalization. > > > > > By keeping this file in the DPDK repository, rather than committers > > > > > maintaining their own copies, it allows individual contributors to edit > > > > > it to update their own email address preferences if so desired. > > > > > > > > > > While at it, update our checkpatches.sh script and add some > > > > > documentation to help new contributors. > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > > Signed-off-by: David Marchand > > > > > --- > > > > > Changes since v3: > > > > > - fixed some issues with non iso characters in names, > > > > > - added .mailmap to MAINTAINERS, > > > > > - populated .mailmap with the contributors file Thomas and I maintain, > > > > > - added a check so that people will stop mangling their own names, > > > > > - added a note in the contributing guide, > > > > > > > > > Do we really want to require all contributors to add their names to the > > > > mailmap file, it seems excessive to me and onerous on new contributors? I > > > > would expect the mailmap to be only necessary for tracking mail updates, or > > > > fixing already-mangled names. > > > > > > As someone who checks those names and fixes some regularly, I prefer > > > developers check this themselves. > > > > If a new contributor does not edit this file, it can be done while merging. > > > That would be ok, I think. I just don't want to have extra hurdles for new > contributors to jump through. Thanks for this. I won't be mandatory and it's very easy. We'll run the check and will fix it as maintainers.