From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 64839E72 for ; Wed, 21 Oct 2015 15:59:11 +0200 (CEST) Received: by wicll6 with SMTP id ll6so92434494wic.0 for ; Wed, 21 Oct 2015 06:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vtawosMkAp6q+gymnPQivPSrmv3NjKK8FOGw2WGRsyw=; b=HyDQL00xw8p3EZ3Xq5d3xXd/o6alZKnJomGqtdhtHRXveKQ6oxZwYoiQcVyKrAW+NN t4QaYYRvXHr1Dz/NRmh8PX0S2wBth5oJmqNtJ5q08a4UEKjTjEqdTaygGQNnWZfqUnSx 27KVpvDoLFnnA9dbKAX8CmK4jvvd2/IkI3fYhmmXpJdVZ3bK6v1AotYqw05s19Aabvzu X8ahZqszug0BotI9UOMfWIdjITQkramrX2C5nrSWOxWGKH3rBldYWiEETqKPaLKzOMUR sJpFGI3/UKyof7rpaXOZOLU+Beq8hAaseRaBNYfZPTuo+5Vq9X0DBACNfqYTnWpGrfJe KbEA== X-Gm-Message-State: ALoCoQmNRlGTF3DiuaH7dMijVwnq/fNol/AvaNDssARhh0aDjfPkh8i+a/4Bl1voq4Q0BDG6oU4Q X-Received: by 10.194.235.39 with SMTP id uj7mr12175924wjc.115.1445435950845; Wed, 21 Oct 2015 06:59:10 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id r9sm10596158wjz.35.2015.10.21.06.59.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 06:59:10 -0700 (PDT) From: Thomas Monjalon To: huawei.xie@intel.com Date: Wed, 21 Oct 2015 15:58:05 +0200 Message-ID: <1945608.IVpO5Mj81A@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <55C1EA34.3000105@6wind.com> References: <1425602726-26538-1-git-send-email-stephen@networkplumber.org> <55C1EA34.3000105@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Ouyang, Changchun" Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 13:59:11 -0000 2015-08-05 12:49, Vincent JARDIN: > > Use '--disable-hw-vlan-filter' in testpmd command line will allow it continue to work. > > You can have a try. > > Yes, but not using this flag should not imply to exit. > > > I am not sure which one is better when app configures one feature but fail to negotiate it with host(which means has > > no such capability to support this feature currently). > > 1)The driver cheat the app, and continue to do the rest of work(of course need some hints). > > 2)give hints and exit, then user re-run app with correct configuration. > > Same as Stephen: > > 3) give hints of capabilities, do not exit, then user app does whatever > it wants (including exit if needed). I would tend to apply this patch but as it was discussed we need some clear acknowledgement. Huawei?