From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E5B61A04E7;
	Mon,  2 Nov 2020 16:49:57 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BE600C92A;
	Mon,  2 Nov 2020 16:49:56 +0100 (CET)
Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com
 [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id CBB8DC926
 for <dev@dpdk.org>; Mon,  2 Nov 2020 16:49:53 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.nyi.internal (Postfix) with ESMTP id 1E6D2580542;
 Mon,  2 Nov 2020 10:49:53 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Mon, 02 Nov 2020 10:49:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 lT52HGP3JJmIF7EgxZLp/qiopHxit1rQ6eozmr9lw2g=; b=rb1f9Z4gdJWyJ4Tb
 J14VnQoNjDFJ8ukysSHyLhjf0CWotewsu/AKtR4XA6YLvcEqntQwcGNZfOm6GWvz
 MLNmcqgMBjmx/IUW+SoP+pPWcfiGE2iWe3kvollm0lGCKkXyWGp/w0+o/LEmmgAU
 r1nC634AzfqGz/NBmFF2SVBxKk7WH7M9PTPreMD46u3B2PjvmBDXqBRPRcEEvZrr
 jDr/rXTGaCuWwILBJADSquYP3IFlARgP8pyN8nga2PoDuKRsOyK9mv9fg5tWo/i5
 0UHZXtSiFLd4BJ9+XcTM80KVQTM2lpdZcjWJ8U2xeKID9jUcfs3SvNLHuEc9pf9F
 xD+8QQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=lT52HGP3JJmIF7EgxZLp/qiopHxit1rQ6eozmr9lw
 2g=; b=eg3JjTqArNxZJTFvSF8DY45CZsrUb7kJ0i18lAuoyJ9GtevmLhr+gD+iq
 7vho6x2qiPqGwiMUuboiMJjoptTS/Tp/cJj/jsgC+Omqwtt4MfMFGf82EnF4tuX9
 KXNpeXckkvX7gKnktggt1wUxnQsNdeXIerlcfkKeUMPiRpOPIvrPYX0Mg29uNApP
 6g0q4gyetP7Dc8b2bVZIy2N+V2pzYovX4Rio8SMZgQ7uQ8q+YlEUWyNcAjxvEV9c
 gO8XOIt4rvaStfZUREigAw2bxdTRW/z274tGdmiKdefjFgV1BfHO1YnXEJJvhKMs
 Ash7GTwWs9gTjdAiwc3hFofb9Tvdg==
X-ME-Sender: <xms:niqgX94_2nSeKXmtL-Zk4SnNv8xxcwsxCulh3A2Dz5sVLHxty-PbXw>
 <xme:niqgX67B7IIOfKtdRRxEjMf5fDepNRzihGLQIZNhytiJLsGWEV_XNstrg-jOl0SSZ
 tanyS-9bPLeZB9N-w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtuddgkedtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:nyqgX0cjmdzB97ib3UsOR6n4UAHvBCAlZSaZD3DobbmUTfIE_N_wUA>
 <xmx:nyqgX2I7Pd8dhIrpZhJk2nZxtRTAcDCpUnRFNDmtpNXrTFdEei2ftA>
 <xmx:nyqgXxIZCAf6DmGnrSE4bBFx2l9Mz2Ld4NSm9ahBpy0pM4YcaiReyg>
 <xmx:oSqgX49rAwkAckNcehxOiIcp6YbQfggOFOeQ9D9ioL9PxA7yB4u5NA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C71B9328005E;
 Mon,  2 Nov 2020 10:49:49 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>,
 David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Slava Ovsiienko <viacheslavo@nvidia.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, Ray Kinsella <mdr@ashroe.eu>,
 Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 02 Nov 2020 16:49:48 +0100
Message-ID: <1945779.j24m6KJYm5@thomas>
In-Reply-To: <CAJFAV8yKvDwhG789WPccFkr1hzWQ=d0mtwTR2+9eFC6-pdz-og@mail.gmail.com>
References: <20201029092751.3837177-1-thomas@monjalon.net>
 <20201102154146.GA1898@platinum>
 <CAJFAV8yKvDwhG789WPccFkr1hzWQ=d0mtwTR2+9eFC6-pdz-og@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 14/14] mbuf: remove deprecated timestamp
	field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/11/2020 16:47, David Marchand:
> On Mon, Nov 2, 2020 at 4:41 PM Olivier Matz <olivier.matz@6wind.com> wrote:
> > > --- a/lib/librte_mbuf/rte_mbuf_core.h
> > > +++ b/lib/librte_mbuf/rte_mbuf_core.h
> > > @@ -149,11 +149,6 @@ extern "C" {
> > >   */
> > >  #define PKT_RX_LRO           (1ULL << 16)
> > >
> > > -/**
> > > - * Indicate that the timestamp field in the mbuf is valid.
> > > - */
> > > -#define PKT_RX_TIMESTAMP     (1ULL << 17)
> > > -
> > >  /**
> > >   * Indicate that security offload processing was applied on the RX packet.
> > >   */
> >
> > nit: can we keep a comment here to highlight the flag 17 is unused?
> 
> What about marking it free in free_flags?

Overkill for a single bit. We will probably use it in future.
I will add a comment as suggested by Olivier.