From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA8B7A0524; Thu, 30 Jan 2020 13:33:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A0A51BFFE; Thu, 30 Jan 2020 13:33:38 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 2FEAF1BFFC for ; Thu, 30 Jan 2020 13:33:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6184245E; Thu, 30 Jan 2020 07:33:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 30 Jan 2020 07:33:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EqAq3sCM10MBZlbL9RqzPWj4kWfzx7X+abIOnUla1ys=; b=jJFtuoY8dwdy P/AlwCg4XYWxNKr/VwNOn7ToABR9OEMHIyZINkwMP8r9M+62BNsuXLwUgK3LC80b HbOuYBn09zv5vz1Lirjd9TpQFosgt7Vgmy0t+xhcRAWmsfhqS6lk6BCJCB8h324+ QqI7tQlmFy6g1xvMbAbyd2b8jlVMpjU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EqAq3sCM10MBZlbL9RqzPWj4kWfzx7X+abIOnUla1 ys=; b=btNH99QmBWw07AIm9ri6Nui/KfJNdjxiHOyN54H/TTz6s7ZT+mIMDhAyJ GMb0aKcKq5KfjaYy/1p8//qNFvrBGq/XEFqE+3tIJecKDsQOgoRzrRqslKPn+H/H CUm0u4usB4ECARsjTjRn7nXAJuqVIR0Nj12teGxFFbDX/GinVH4ntwlv6lPoLZvL eFHRKoEkng+lnkq8CIg2JRriqOJ4apBfT0Wv9CzWrl90I8qBRT5X7WSNGAoRqrSD 15cLD69UzUe4ivpgZJiXekEfNMayaBv2aNbrQldRT6istBRpS0iWcxJVb92OJkP4 3DqTxy8DumRY5JtNXdTkw23r9XuTw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeekgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeeirddvudefrddvhedurddufedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (lfbn-bor-1-555-130.w86-213.abo.wanadoo.fr [86.213.251.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 594B13280059; Thu, 30 Jan 2020 07:33:17 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, Luca Boccassi , David Marchand , Bruce Richardson , Ian Stokes , Andrzej Ostruszka Date: Thu, 30 Jan 2020 13:33:15 +0100 Message-ID: <1948601.PIDvDuAF1L@xps> In-Reply-To: <20200129164350.3724793-1-ferruh.yigit@intel.com> References: <20200129122953.2016199-1-ferruh.yigit@intel.com> <20200129164350.3724793-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I disagree with the need of this patch. The symbol was experimental, meaning we can change it. Removing experimental tag is not an ABI break. 29/01/2020 17:43, Ferruh Yigit: > Duplicated the existing symbol and versioned one as experimental and > other as stable. [..] > --- a/lib/librte_meter/rte_meter_version.map > +++ b/lib/librte_meter/rte_meter_version.map > @@ -20,4 +20,12 @@ DPDK_20.0.1 { > rte_meter_trtcm_rfc4115_color_blind_check; > rte_meter_trtcm_rfc4115_config; > rte_meter_trtcm_rfc4115_profile_config; > + > } DPDK_20.0; > + > +EXPERIMENTAL { > + global: > + > + rte_meter_trtcm_rfc4115_config; > + rte_meter_trtcm_rfc4115_profile_config; > +};