From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C29D5A00C5; Tue, 7 Jul 2020 01:16:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 660A11DBD9; Tue, 7 Jul 2020 01:16:17 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 43ED91DB9D for ; Tue, 7 Jul 2020 01:16:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id C94D25800FA; Mon, 6 Jul 2020 19:16:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Jul 2020 19:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8BKsO1HKSnxhmjsdpeSx36vWpjPOQf/pWFB2isFkeqY=; b=U+ny5rTWptCa27AA nTiFSM9MO1GKC2TO6FYxTEkSjW1MRlLWYinYdCC45O2awfrpEBCyBqwDjmgNo9OI CRqy+HYsCwukFRIcsUDDU9ClsGnT8jdwTeW4w0xeM0aTQR8uQOqI+FfixN4ovcNr Nx+IfyGUsc0nHmfJPcj+OZIbdONTYbFlMQdPPQcqKsQaNrP6D4NbxDGjeCFozVYH f05Cijf3TJO8kW+f8A1SvJMSzW8luPyFhkNNxpl87XfrRZzq7hz8eSNGyff5MOGQ i+OH7QWQT5PzxGtD9d298yvcO1EYPYICJqOYthfasUyQfNIgSbxK2ANcKhCtWTdL m/zXhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8BKsO1HKSnxhmjsdpeSx36vWpjPOQf/pWFB2isFke qY=; b=EG8tjUD0K1kWuIFRIy6GqCeNuQCPW3qHGDvWYiX/DUvGbrmCV/q5gDJrD ob1oOsMZ6azH15fv2Xbpr3DxRhcagxO9tmWDDiZMG9dIg3KRV1p9A9nfDUhTeP8F 9R7knfjPRq/usimmOSDEjXtnE90kIHUGHUcnDgRVCFdFJTUlWuVLW/Nc1kYeRPd5 hZriZa34tuj/r2c4jnRa+D5hzNcTCUtTVIzoudViRpB6ggLv5j1oii7yBZ50dPGF PUaVNayET7M9yUq42nfGdazfzYT8ZRPd+0FrvO4kqFO298BMDrYUd/Q0s4FjxrzW Fi7pbL/8SfFbG/YhgbFVdFBEN+ClA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeggddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07FED30653C5; Mon, 6 Jul 2020 19:16:12 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Fady Bader , dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Tue, 07 Jul 2020 01:16:11 +0200 Message-ID: <1948679.WNsnLzTKOZ@thomas> In-Reply-To: <20200706122208.GE636@bricha3-MOBL.ger.corp.intel.com> References: <20200705134746.26240-1-fady@mellanox.com> <20200706113241.28748-2-fady@mellanox.com> <20200706122208.GE636@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2020 14:22, Bruce Richardson: > On Mon, Jul 06, 2020 at 02:32:39PM +0300, Fady Bader wrote: > > Function versioning implementation is not supported by Windows. > > Function versioning is disabled on Windows. > > > > Signed-off-by: Fady Bader > > --- > > doc/guides/windows_gsg/intro.rst | 4 ++++ > > lib/meson.build | 6 +++++- > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/windows_gsg/intro.rst b/doc/guides/windows_gsg/intro.rst > > index a0285732df..58c6246404 100644 > > --- a/doc/guides/windows_gsg/intro.rst > > +++ b/doc/guides/windows_gsg/intro.rst > > @@ -18,3 +18,7 @@ DPDK for Windows is currently a work in progress. Not all DPDK source files > > compile. Support is being added in pieces so as to limit the overall scope > > of any individual patch series. The goal is to be able to run any DPDK > > application natively on Windows. > > + > > +The :doc:`../contributing/abi_policy` cannot be respected for Windows. > > +Minor ABI versions may be incompatible > > +because function versioning is not supported on Windows. > > diff --git a/lib/meson.build b/lib/meson.build > > index c1b9e1633f..dadf151f78 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -107,6 +107,10 @@ foreach l:libraries > > shared_dep = declare_dependency(include_directories: includes) > > static_dep = shared_dep > > else > > + if is_windows and use_function_versioning > > + message('@0@: Function versioning is not supported by Windows.' > > + .format(name)) > > + endif > > > > This is ok here, but I think it might be better just moved to somewhere > like config/meson.build, so that it is always just printed once for each > build. I don't see an issue with having it printed even if there is no > function versioning in the build itself. Moving such message in config/meson.build is the same as moving it to the doc. I prefer having a message each time a library compatibility is required but not possible. > With or without the code move above, which is just a suggestion, > > Acked-by: Bruce Richardson OK thanks, I'll merge as is.