From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A9EDFF928 for ; Fri, 16 Dec 2016 18:04:31 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t79so42703840wmt.0 for ; Fri, 16 Dec 2016 09:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=XEE6HusvNO1suxzO/05wX6zHCpaxWPaBsoVH++Y49hc=; b=bXzp016VBrvq5qUScyVKMefuRZb5UwfEX3Tf/1YXWTMvDjR9B21Piw3roYWoq2c5L2 7VAFQQh6U9p6MPs08Djp81OpRIT2k9bdPDBE2Ls7+XTTRv/5azu3BOQhQxnHKaDoCcbo zEgirIQfuJZLHu9xobXJLy1PWNFrG2Eog6O+3VR7cFO7UVwJ7Tko6VLtqQem8QK1DLep YH8qLuZuVn3U21kspQ2n37jYb+N8EUcK9vxgHQYkYwwbVg4rpH7BrX/ML5Fw1gryl9A2 WZu8iPaezybG+vhJhabKwuGdw7WgsQnb1Y2le070KrM+gZBMy+P/FFyY7N4ARptRC/tH hSdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XEE6HusvNO1suxzO/05wX6zHCpaxWPaBsoVH++Y49hc=; b=NXatMbr0zumx+1YEclbQP83id7HZvX3rSwMf9vUuTBZe4uR9bKysHOs81EuhlQN/wB UI2Akr+pifImj0Pjs77+9KeMWIJ1RMY/7tGerWTjZOUNw0wvtTNfHXP07o3ujzAdUsS/ cnTFp79LnEyqUV/SOLj3CFdBmotp4BRtbbLhnjvQVPaGaWY9j+rArAm61SF9NzDfYzyU dNYTQfugA82s9fYfhkZZQyUSeKW/naWVybclTP5GcDweSKJzWPpT2TV/Nuj58JiVkElD GQHSa6WqCCXRHkJIgknF7BZpHNGcoRPX3gMxr0n6BwJMRKM08+qKiDJJXHegkKDVaoPH jWRQ== X-Gm-Message-State: AIkVDXL6Ojs5BmyVuAvgTSdPhMVBzWZb80zAMF8XypzmA4bvLmfFUoRSlPOzwgCrgXoTRluX X-Received: by 10.28.46.197 with SMTP id u188mr4228825wmu.61.1481907871317; Fri, 16 Dec 2016 09:04:31 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w79sm4210644wmw.0.2016.12.16.09.04.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 09:04:30 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Cc: Yuanhan Liu , dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@linaro.org, viktorin@rehivetech.com Date: Fri, 16 Dec 2016 18:04:29 +0100 Message-ID: <19499490.j98SqyhBfx@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161214131835.GB4224@localhost.localdomain> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161214025357.GF18991@yliu-dev.sh.intel.com> <20161214131835.GB4224@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/28] introduce I/O device memory read/write operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2016 17:04:31 -0000 2016-12-14 18:48, Jerin Jacob: > On Wed, Dec 14, 2016 at 10:53:57AM +0800, Yuanhan Liu wrote: > > On Wed, Dec 14, 2016 at 07:25:30AM +0530, Jerin Jacob wrote: > > > patchset 14-28: Replace the raw readl/writel in the drivers with > > > new rte_read[b/w/l/q], rte_write[b/w/l/q] eal abstraction > > > > Instead of rte_read[b/w/l/q], there is another typical naming style: > > rte_read[8/16/32/64]. Any preferences? If you ask me, I'd prefer the > > later. > > No strong opinion here. The rte_read[b/w/l/q] naming style is from Linux > kernel. I will change to rte_read[8/16/32/64] in v2 if there is no > objection. Yes please. Let's use numbers where possible. See this recent explanation: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1293045.html