From: Thomas Monjalon <thomas@monjalon.net>
To: alan somers <asomers@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs
Date: Wed, 13 Sep 2017 17:39:43 +0200 [thread overview]
Message-ID: <1950575.vEqoHlsAsr@xps> (raw)
In-Reply-To: <CAOtMX2g2q1kLUdi83hHWAkS9DuMXDmWkRvruGoMHYBbLs1w8_Q@mail.gmail.com>
13/09/2017 16:35, alan somers:
> On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 27/07/2017 22:12, asomers@gmail.com:
> >> From: Alan Somers <asomers@gmail.com>
> >>
> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable.
> >
> > Why is it an issue?
> >
> > Can you run dpdk-setup.sh on a non-Linux system?
>
> Nope, because even dpdk-setup.sh assumes that bash is located at
> /bin/bash. But "/usr/bin/env bash" works everywhere.
No, I mean: can you run dpdk-setup.sh on a non-Linux system after your change?
This script configures a Linux system, so I want to understand
what situation you are trying to fix.
next prev parent reply other threads:[~2017-09-13 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 20:12 asomers
2017-09-13 9:37 ` Thomas Monjalon
2017-09-13 14:35 ` alan somers
2017-09-13 15:39 ` Thomas Monjalon [this message]
2017-09-13 15:55 ` alan somers
2017-09-13 16:51 ` Thomas Monjalon
2017-07-27 20:41 asomers
2017-07-28 9:28 ` Bruce Richardson
2017-07-31 15:11 ` alan somers
2017-07-31 15:22 ` Bruce Richardson
2017-07-31 16:18 ` alan somers
2017-07-31 17:06 ` Wiles, Keith
2017-07-31 19:08 ` alan somers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1950575.vEqoHlsAsr@xps \
--to=thomas@monjalon.net \
--cc=asomers@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).